[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #3959: Disable metrics for very wide tables to reduce metadata size

[GitBox <gi...@apache.org>]

RussellSpitzer commented on a change in pull request #3959:
URL: https://github.com/apache/iceberg/pull/3959#discussion_r791301333



##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -194,7 +194,8 @@ private TableProperties() {
 
   public static final String METRICS_MODE_COLUMN_CONF_PREFIX = "write.metadata.metrics.column.";
   public static final String DEFAULT_WRITE_METRICS_MODE = "write.metadata.metrics.default";
-  public static final String DEFAULT_WRITE_METRICS_MODE_DEFAULT = "truncate(16)";

Review comment:
       This is changing a public API and to a new type. May need to reconsider this. Would probably be safer to just add the new variable below with a slightly different name?
   
   Although if other folks don't mind, I think that's fine.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org