You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/09/19 17:22:19 UTC
Review Request 25827: Alerts: add aggregate alert type and calculation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25827/
-----------------------------------------------------------
Review request for Ambari and Jonathan Hurley.
Bugs: AMBARI-7410
https://issues.apache.org/jira/browse/AMBARI-7410
Repository: ambari
Description
-------
Add aggregates
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java e3e5779
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java c63f063
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertAggregateListener.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertReceivedListener.java 0f1b49a
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java a274089
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java c24ac17
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java b4b8a44
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionFactory.java f16f4a6
ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java 530c1bb
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/alerts.json 3958106
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json 00286b1
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 66c0b3d
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java 7ea2ffe
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java ddfc75a
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java a9d126c
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java cdca3dd
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java 2c3a876
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java a397da4
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java bbf7774
ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/alerts.json f4a3001
Diff: https://reviews.apache.org/r/25827/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 22:12.127s
[INFO] Finished at: Fri Sep 19 11:19:30 EDT 2014
[INFO] Final Memory: 30M/204M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 25827: Alerts: add aggregate alert type and
calculation
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25827/#review53959
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
<https://reviews.apache.org/r/25827/#comment93848>
Here's a nit: == for enums prevents method invocation, possibly saving you a fraction of a millisecond.
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertAggregateListener.java
<https://reviews.apache.org/r/25827/#comment93849>
Should probably not initialize an @Inject to null.
- Jonathan Hurley
On Sept. 19, 2014, 11:22 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25827/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2014, 11:22 a.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-7410
> https://issues.apache.org/jira/browse/AMBARI-7410
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add aggregates
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java e3e5779
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java c63f063
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertAggregateListener.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertReceivedListener.java 0f1b49a
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java a274089
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java c24ac17
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java b4b8a44
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionFactory.java f16f4a6
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java 530c1bb
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/alerts.json 3958106
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json 00286b1
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 66c0b3d
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java 7ea2ffe
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java ddfc75a
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java a9d126c
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java cdca3dd
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java 2c3a876
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java a397da4
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java bbf7774
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/alerts.json f4a3001
>
> Diff: https://reviews.apache.org/r/25827/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 22:12.127s
> [INFO] Finished at: Fri Sep 19 11:19:30 EDT 2014
> [INFO] Final Memory: 30M/204M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 25827: Alerts: add aggregate alert type and
calculation
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25827/#review53961
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Sept. 19, 2014, 11:22 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25827/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2014, 11:22 a.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-7410
> https://issues.apache.org/jira/browse/AMBARI-7410
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add aggregates
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java e3e5779
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java c63f063
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertAggregateListener.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertReceivedListener.java 0f1b49a
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java a274089
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java c24ac17
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java b4b8a44
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionFactory.java f16f4a6
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java 530c1bb
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/alerts.json 3958106
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json 00286b1
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 66c0b3d
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java 7ea2ffe
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java ddfc75a
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java a9d126c
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java cdca3dd
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java 2c3a876
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java a397da4
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java bbf7774
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/alerts.json f4a3001
>
> Diff: https://reviews.apache.org/r/25827/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 22:12.127s
> [INFO] Finished at: Fri Sep 19 11:19:30 EDT 2014
> [INFO] Final Memory: 30M/204M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>