You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/20 03:12:34 UTC

[GitHub] [cloudstack] GraceXiaoYa opened a new issue #4849: Use broken cipher algorithm DES for encryption

GraceXiaoYa opened a new issue #4849:
URL: https://github.com/apache/cloudstack/issues/4849


   
   
   ##### ISSUE TYPE
    * Security Vulnerability
   
   ##### Description:
   We found a security vulnerability in file [cloudstack/services/console-proxy/server/src/main/java/com/cloud/consoleproxy/vnc/NoVncClient.java](https://github.com/apache/cloudstack/blob/0f3f2a09370a18301db28ec3d28efe746b6437c9/services/console-proxy/server/src/main/java/com/cloud/consoleproxy/vnc/NoVncClient.java). The broken cipher DES is used for encryption according to Line 202 and 204. 
   
   ##### Security Impact:
   The DES algorithm is broken. It uses a 56-bits key that is too short to resist brute-forth attacks. 
   
   ##### Useful Resources:
   https://cwe.mitre.org/data/definitions/327.html
   https://link.springer.com/chapter/10.1007/3-540-48071-4_34
   
   ##### Solution we suggest:
   Replace it with AES cipher algorithm with CBC mode.
   
   ##### Please share with us your opinions/comments if there is any:
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on issue #4849: Use broken cipher algorithm DES for encryption

Posted by GitBox <gi...@apache.org>.
davidjumani commented on issue #4849:
URL: https://github.com/apache/cloudstack/issues/4849#issuecomment-803943711


   @DaanHoogland @weizhouapache The token passed between the MS and the CPVM via the URL is encrypted via AES. The VM VNC password sent from the CPVM to the Host is encrypted via DES as is the standard for the RFB protocol


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on issue #4849: Use broken cipher algorithm DES for encryption

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #4849:
URL: https://github.com/apache/cloudstack/issues/4849#issuecomment-803911587


   is this about communication between the webclient and the target or between the console proxy and the target, @davidjumani . This is another static analysis report without exploit, publicly submitted :(
   we'll have to do assesment. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on issue #4849: Use broken cipher algorithm DES for encryption

Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4849:
URL: https://github.com/apache/cloudstack/issues/4849#issuecomment-811710366


   Closing this due to limitation of how VNC works it can't be fixed at client/proxy level @GraceXiaoYa - pl reopen if you can demonstrate/share an exploit from public network/plane/CloudStack.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on issue #4849: Use broken cipher algorithm DES for encryption

Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4849:
URL: https://github.com/apache/cloudstack/issues/4849#issuecomment-803794111


   cc @shwstppr @DaanHoogland 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani edited a comment on issue #4849: Use broken cipher algorithm DES for encryption

Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on issue #4849:
URL: https://github.com/apache/cloudstack/issues/4849#issuecomment-803804755


   The password is sent to the Host via DES as that is the standard auth mechanism for the RFB Protocol.
   https://vncdotool.readthedocs.io/en/0.8.0/rfbproto.html#vnc-authentication
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani edited a comment on issue #4849: Use broken cipher algorithm DES for encryption

Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on issue #4849:
URL: https://github.com/apache/cloudstack/issues/4849#issuecomment-803804755


   The password is sent to the Host via DES as that is the standard auth mechanism.
   https://vncdotool.readthedocs.io/en/0.8.0/rfbproto.html#vnc-authentication
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on issue #4849: Use broken cipher algorithm DES for encryption

Posted by GitBox <gi...@apache.org>.
davidjumani commented on issue #4849:
URL: https://github.com/apache/cloudstack/issues/4849#issuecomment-803801434


   The password is encrypted via DES, added to a ConsoleProxyClientParam object which is in turn encrypted via AES
   https://github.com/apache/cloudstack/blob/master/services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyClientBase.java#L423
   https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/servlet/ConsoleProxyPasswordBasedEncryptor.java#L88


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on issue #4849: Use broken cipher algorithm DES for encryption

Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4849:
URL: https://github.com/apache/cloudstack/issues/4849#issuecomment-810050332


   Based on what I understand this is how VNC works (as per David's comments), unless the attacker is part of the data plane it shouldn't affect CloudStack (i.e. not a security bug).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani removed a comment on issue #4849: Use broken cipher algorithm DES for encryption

Posted by GitBox <gi...@apache.org>.
davidjumani removed a comment on issue #4849:
URL: https://github.com/apache/cloudstack/issues/4849#issuecomment-803801434


   The password is encrypted via DES, added to a ConsoleProxyClientParam object which is in turn encrypted via AES
   https://github.com/apache/cloudstack/blob/master/services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyClientBase.java#L423
   https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/servlet/ConsoleProxyPasswordBasedEncryptor.java#L88


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on issue #4849: Use broken cipher algorithm DES for encryption

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #4849:
URL: https://github.com/apache/cloudstack/issues/4849#issuecomment-803950395


   > @DaanHoogland @weizhouapache The token passed between the MS and the CPVM via the URL is encrypted via AES. The VM VNC password sent from the CPVM to the Host is encrypted via DES as is the standard for the RFB protocol
   
   @davidjumani yes. IMHO, the novnc password encryption is not an issue as it is sent from CPVM to host, which are internal communication.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on issue #4849: Use broken cipher algorithm DES for encryption

Posted by GitBox <gi...@apache.org>.
davidjumani commented on issue #4849:
URL: https://github.com/apache/cloudstack/issues/4849#issuecomment-803804755


   The password is sent to the Host via DES as that is the standard auth mechanism. Will check whether it can be changed to AES


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on issue #4849: Use broken cipher algorithm DES for encryption

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #4849:
URL: https://github.com/apache/cloudstack/issues/4849#issuecomment-803928397


   > is this about communication between the webclient and the target or between the console proxy and the target, @davidjumani . This is another static analysis report without exploit, publicly submitted :(
   > we'll have to do assesment.
   
   @DaanHoogland it is about the token in vm console URL. it is ecrypted/decrypted using a single 'key'.
   it would be better to use a key/iv pair.
   
   @davidjumani you may find some code for CBC encryption/decryption in my closed pr for novnc console:
   https://github.com/apache/cloudstack/pull/3296/files  (search for keyword 'CBC').
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on issue #4849: Use broken cipher algorithm DES for encryption

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #4849:
URL: https://github.com/apache/cloudstack/issues/4849#issuecomment-804058053


   ok, let's await a proper exploit for two weeks or close after that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd closed issue #4849: Use broken cipher algorithm DES for encryption

Posted by GitBox <gi...@apache.org>.
rhtyd closed issue #4849:
URL: https://github.com/apache/cloudstack/issues/4849


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org