You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by Mark Martinec <Ma...@ijs.si> on 2007/08/21 19:11:37 UTC

Re: svn commit: r568168 - in /spamassassin/trunk/lib/Mail/SpamAssassin: ./ BayesStore/ Conf/ Locker/ Logger/ Plugin/ Util/

> - dbg("rules: $rule (pri $basepri) requires $dep (pri $deppri): fixed");
> + dbg("rules: %s (pri %s) requires %s (pri %s): fixed", 
> +     $rule,$basepri, $dep,$deppri);

> I'm afraid I'm -0.5 on this stuff.
>
> I find %s format strings much harder to read (and use) than simple string
> interpolation.  In some cases, of course, they make sense; but for most,
> they don't.
>
> Could you revert those changes that add %s usage? (I'm happy enough about
> the eval changes, though.)

Ok, will revert the straightforward cases involving mostly scalars.
Yell if you feel I missed any.

  Mark