You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2015/11/03 23:17:07 UTC
Review Request 39918: Finalize is invoked when it is sure to fail
when there a failures that have been skipped during RU
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39918/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jayush Luniya.
Bugs: AMBARI-13704
https://issues.apache.org/jira/browse/AMBARI-13704
Repository: ambari
Description
-------
Added server side task that is invoked before POST_CLUSTER that checks for mismatched versions.
Debatable whether Express needs this - can be removed if needed.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckAction.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 22fc4c0
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3730d67
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 677bc8d
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml d41fc36
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 753d1cc
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml f910c90
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 4ef129d
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 5ebaf2c
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/39918/diff/
Testing
-------
Manual. Automated pending.
Thanks,
Nate Cole
Re: Review Request 39918: Finalize is invoked when it is sure to fail
when there a failures that have been skipped during RU
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39918/#review105028
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Nov. 4, 2015, 2:28 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39918/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2015, 2:28 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jayush Luniya.
>
>
> Bugs: AMBARI-13704
> https://issues.apache.org/jira/browse/AMBARI-13704
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added server side task that is invoked before POST_CLUSTER that checks for mismatched versions.
>
> Debatable whether Express needs this - can be removed if needed.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 22fc4c0
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3730d67
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 677bc8d
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml d41fc36
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 753d1cc
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml f910c90
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 4ef129d
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 5ebaf2c
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39918/diff/
>
>
> Testing
> -------
>
> Manual verification + automated:
>
> Tests run: 3326, Failures: 0, Errors: 0, Skipped: 35
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:59.689s
> [INFO] Finished at: Tue Nov 03 17:43:09 EST 2015
> [INFO] Final Memory: 34M/1417M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 39918: Finalize is invoked when it is sure to fail
when there a failures that have been skipped during RU
Posted by Nate Cole <nc...@hortonworks.com>.
> On Nov. 4, 2015, 5:35 a.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml, line 467
> > <https://reviews.apache.org/r/39918/diff/1/?file=1115154#file1115154line467>
> >
> > Does retrying check make sence during upgrade?
No, no it doesn't. Good catch! I somehow thought this was to enable the Retry button, but that's not the case. Will remove.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39918/#review105049
-----------------------------------------------------------
On Nov. 3, 2015, 9:28 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39918/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 9:28 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jayush Luniya.
>
>
> Bugs: AMBARI-13704
> https://issues.apache.org/jira/browse/AMBARI-13704
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added server side task that is invoked before POST_CLUSTER that checks for mismatched versions.
>
> Debatable whether Express needs this - can be removed if needed.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 22fc4c0
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3730d67
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 677bc8d
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml d41fc36
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 753d1cc
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml f910c90
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 4ef129d
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 5ebaf2c
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39918/diff/
>
>
> Testing
> -------
>
> Manual verification + automated:
>
> Tests run: 3326, Failures: 0, Errors: 0, Skipped: 35
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:59.689s
> [INFO] Finished at: Tue Nov 03 17:43:09 EST 2015
> [INFO] Final Memory: 34M/1417M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 39918: Finalize is invoked when it is sure to fail
when there a failures that have been skipped during RU
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39918/#review105049
-----------------------------------------------------------
Ship it!
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml (line 467)
<https://reviews.apache.org/r/39918/#comment163418>
Does retrying check make sence during upgrade?
- Dmitro Lisnichenko
On Nov. 4, 2015, 4:28 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39918/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2015, 4:28 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jayush Luniya.
>
>
> Bugs: AMBARI-13704
> https://issues.apache.org/jira/browse/AMBARI-13704
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added server side task that is invoked before POST_CLUSTER that checks for mismatched versions.
>
> Debatable whether Express needs this - can be removed if needed.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckAction.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 22fc4c0
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3730d67
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 677bc8d
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml d41fc36
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 753d1cc
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml f910c90
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 4ef129d
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 5ebaf2c
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39918/diff/
>
>
> Testing
> -------
>
> Manual verification + automated:
>
> Tests run: 3326, Failures: 0, Errors: 0, Skipped: 35
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:59.689s
> [INFO] Finished at: Tue Nov 03 17:43:09 EST 2015
> [INFO] Final Memory: 34M/1417M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 39918: Finalize is invoked when it is sure to fail
when there a failures that have been skipped during RU
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39918/
-----------------------------------------------------------
(Updated Nov. 3, 2015, 9:28 p.m.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jayush Luniya.
Bugs: AMBARI-13704
https://issues.apache.org/jira/browse/AMBARI-13704
Repository: ambari
Description
-------
Added server side task that is invoked before POST_CLUSTER that checks for mismatched versions.
Debatable whether Express needs this - can be removed if needed.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckAction.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 22fc4c0
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3730d67
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 677bc8d
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml d41fc36
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 753d1cc
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml f910c90
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 4ef129d
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 5ebaf2c
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/39918/diff/
Testing (updated)
-------
Manual verification + automated:
Tests run: 3326, Failures: 0, Errors: 0, Skipped: 35
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 28:59.689s
[INFO] Finished at: Tue Nov 03 17:43:09 EST 2015
[INFO] Final Memory: 34M/1417M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole