You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "James Taylor (JIRA)" <ji...@apache.org> on 2014/06/09 03:49:01 UTC
[jira] [Resolved] (PHOENIX-1025) PhoenixConnection constructor
Peoperties set isn't deep copy
[ https://issues.apache.org/jira/browse/PHOENIX-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Taylor resolved PHOENIX-1025.
-----------------------------------
Resolution: Duplicate
This has already been fixed and will appear in our 3.1/4.1 release, but thanks for the patch.
> PhoenixConnection constructor Peoperties set isn't deep copy
> ------------------------------------------------------------
>
> Key: PHOENIX-1025
> URL: https://issues.apache.org/jira/browse/PHOENIX-1025
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: jay wong
> Fix For: 3.0.0
>
> Attachments: PHOENIX-1025.patch
>
>
> {code}
> public PhoenixConnection(ConnectionQueryServices services, String url, Properties info, PMetaData metaData) throws SQLException {
> this.url = url;
> // Copy so client cannot change
> this.info = info == null ? new Properties() : new Properties(info);
> final PName tenantId = JDBCUtil.getTenantId(url, info);
> if (this.info.isEmpty() && tenantId == null) {
> this.services = services;
> } else {
> .....
> }
> }
> {code}
> As this.info is set with new Properties(info).
> So at the code below info.isEmpty() is always return true.
> I think this.info should be set as PropertiesUtil.deepCopy(info);
--
This message was sent by Atlassian JIRA
(v6.2#6252)