You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@teaclave.apache.org by Chines Wang <no...@github.com.INVALID> on 2023/03/31 15:59:27 UTC

[apache/incubator-teaclave-sgx-sdk] modified atomic::ordering about SHOULD_CAPTURE (PR #428)

https://github.com/wang384670111/incubator-teaclave-sgx-sdk/blob/780dc8999477244d8ff1e6f418321adbec51ee58/sgx_tstd/src/panic.rs#L261
https://github.com/wang384670111/incubator-teaclave-sgx-sdk/blob/780dc8999477244d8ff1e6f418321adbec51ee58/sgx_tstd/src/panic.rs#L287
I think the use of ordering here is irregular, SHOULD_CAPYURE is used not to synchronize access to other shared variables. I think just Ordering::Relaxed needs to be used here to ensure the correctness of the program.
You can view, comment on, or merge this pull request online at:

  https://github.com/apache/incubator-teaclave-sgx-sdk/pull/428

-- Commit Summary --

  * modified atomic::ordering about SHOULD_CAPTURE

-- File Changes --

    M sgx_tstd/src/panic.rs (4)

-- Patch Links --

https://github.com/apache/incubator-teaclave-sgx-sdk/pull/428.patch
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/428.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/428
You are receiving this because you are subscribed to this thread.

Message ID: &lt;apache/incubator-teaclave-sgx-sdk/pull/428@github.com&gt;

Re: [apache/incubator-teaclave-sgx-sdk] modified atomic::ordering about SHOULD_CAPTURE (PR #428)

Posted by volcano <no...@github.com.INVALID>.

@wang384670111 Thanks for reporting this issue.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/428#issuecomment-1498916931
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>