You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/05/08 14:34:12 UTC
[GitHub] [airflow] Dris101 opened a new pull request, #23568: Fix defaultAirflowRepository comment
Dris101 opened a new pull request, #23568:
URL: https://github.com/apache/airflow/pull/23568
closes: #23566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #23568: Fix defaultAirflowRepository comment
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #23568:
URL: https://github.com/apache/airflow/pull/23568#issuecomment-1120429863
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Dris101 commented on a diff in pull request #23568: Fix defaultAirflowRepository comment
Posted by GitBox <gi...@apache.org>.
Dris101 commented on code in PR #23568:
URL: https://github.com/apache/airflow/pull/23568#discussion_r870552749
##########
chart/values.yaml:
##########
@@ -42,7 +42,7 @@ securityContext: {}
# Used for mount paths
airflowHome: /opt/airflow
-# Default airflow repository -- overrides all the specific images below
+# Default airflow repository -- overridden by all the specific images below
Review Comment:
My bad, Had "format on save" turned on. What's the cleanest way to do that? Undo the last commit on my topic branch, revise and re-push?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a diff in pull request #23568: Fix defaultAirflowRepository comment
Posted by GitBox <gi...@apache.org>.
kaxil commented on code in PR #23568:
URL: https://github.com/apache/airflow/pull/23568#discussion_r870556929
##########
chart/values.yaml:
##########
@@ -42,7 +42,7 @@ securityContext: {}
# Used for mount paths
airflowHome: /opt/airflow
-# Default airflow repository -- overrides all the specific images below
+# Default airflow repository -- overridden by all the specific images below
Review Comment:
Yeah :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #23568: Fix defaultAirflowRepository comment
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #23568: Fix defaultAirflowRepository comment
URL: https://github.com/apache/airflow/pull/23568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23568: Fix defaultAirflowRepository comment
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23568:
URL: https://github.com/apache/airflow/pull/23568#issuecomment-1166383972
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a diff in pull request #23568: Fix defaultAirflowRepository comment
Posted by GitBox <gi...@apache.org>.
kaxil commented on code in PR #23568:
URL: https://github.com/apache/airflow/pull/23568#discussion_r870511311
##########
chart/values.yaml:
##########
@@ -42,7 +42,7 @@ securityContext: {}
# Used for mount paths
airflowHome: /opt/airflow
-# Default airflow repository -- overrides all the specific images below
+# Default airflow repository -- overridden by all the specific images below
Review Comment:
Can you undo all the other formatting changes except this one please -- let's us keep the git history better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org