[GitHub] [superset] yeoji commented on a change in pull request #17278: fix: The filter mapping configuration can not be saved in V1.2.0 +

[GitBox <gi...@apache.org>]

yeoji commented on a change in pull request #17278:
URL: https://github.com/apache/superset/pull/17278#discussion_r783540711



##########
File path: superset-frontend/src/dashboard/actions/dashboardInfo.ts
##########
@@ -60,10 +64,12 @@ export const setChartConfiguration = (
   });
 
   try {
+    const filterCondition = JSON.parse(String(filterscopes));

Review comment:
       Hey @xinjingqing, I've come across this issue too and found your fix.
   
   Just wanted to note that this line breaks the saving of cross filter scoping since `filterscopes` is `undefined` (called from `CrossFilterScopingModal.tsx`), so it's probably necessary to check this parameter before attempting to `JSON.parse` it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org