You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by Michael Parker <pa...@pobox.com> on 2005/05/06 20:42:59 UTC

Change to Reporter.pm

Anyone know why this isn't a good change?  or why it was set to 1 in
the first place? (revoke has it set to 0)

Index: lib/Mail/SpamAssassin/Reporter.pm
===================================================================
--- lib/Mail/SpamAssassin/Reporter.pm   (revision 168612)
+++ lib/Mail/SpamAssassin/Reporter.pm   (working copy)
@@ -54,7 +54,7 @@

 sub report {
   my ($self) = @_;
-  $self->{report_return} = 1;
+  $self->{report_return} = 0;
   $self->{report_available} = 0;

   my $text = $self->{main}->remove_spamassassin_markup($self->{msg});


Also, the Plugin.pm documentation for plugin_report/plugin_revoke
seems to be lacking, specifically the fact that the plugin needs to be
setting some variables depending on action taken.  I don't mind adding
something but I'm not totally sure what the intent was.

Michael

Re: Change to Reporter.pm

Posted by Theo Van Dinter <fe...@kluge.net>.
On Fri, May 06, 2005 at 01:42:59PM -0500, Michael Parker wrote:
> Anyone know why this isn't a good change?  or why it was set to 1 in
> the first place? (revoke has it set to 0)

Hrm.  I think that's a left over from changing things around when moving
things to plugins.  I can't think of a reason to leave it as 1 (ok)
by default.

FYI: I'm going to commit a small change to that section of Reporter to check
for revoke_available in the same way as report_available.

-- 
Randomly Generated Tagline:
"Oh gee, there it is, too bad."            - Prof. Farr