You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Mark Struberg (JIRA)" <ji...@apache.org> on 2011/05/27 00:06:47 UTC

[jira] [Created] (FTPSERVER-413) STAT command returns wrong 200 state

STAT command returns wrong 200 state
------------------------------------

                 Key: FTPSERVER-413
                 URL: https://issues.apache.org/jira/browse/FTPSERVER-413
             Project: FtpServer
          Issue Type: Bug
    Affects Versions: 1.0.5
            Reporter: Mark Struberg


I'm now using MINA FtpServer for the Integration Tests of Apache mavens wagon-ftp. While upgrding from a 8 year old avalon based ftpserver jar, I figured that a unit test is broken. 
This has to do with FtpServer returning a 200 state which is imo invalid.

According to the officla RFC http://www.faqs.org/rfcs/rfc959.html STAT may only return the following codes:

               STAT
                  211, 212, 213
                  450
                  500, 501, 502, 421, 530

I think returning 200 (command ok) after a STAT command is a bug.

 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (FTPSERVER-413) STAT command returns wrong 200 state

Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FTPSERVER-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041251#comment-13041251 ] 

Niklas Gustavsson commented on FTPSERVER-413:
---------------------------------------------

Fixed to use another, incorrect reply code first. Now fixed again in rev 1129318 and 1129319.

> STAT command returns wrong 200 state
> ------------------------------------
>
>                 Key: FTPSERVER-413
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-413
>             Project: FtpServer
>          Issue Type: Bug
>    Affects Versions: 1.0.5
>            Reporter: Mark Struberg
>            Assignee: Niklas Gustavsson
>             Fix For: 1.0.6, 1.1.0
>
>
> I'm now using MINA FtpServer for the Integration Tests of Apache mavens wagon-ftp. While upgrding from a 8 year old avalon based ftpserver jar, I figured that a unit test is broken. 
> This has to do with FtpServer returning a 200 state which is imo invalid.
> According to the officla RFC http://www.faqs.org/rfcs/rfc959.html STAT may only return the following codes:
>                STAT
>                   211, 212, 213
>                   450
>                   500, 501, 502, 421, 530
> I think returning 200 (command ok) after a STAT command is a bug.
>  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (FTPSERVER-413) STAT command returns wrong 200 state

Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FTPSERVER-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041264#comment-13041264 ] 

Niklas Gustavsson commented on FTPSERVER-413:
---------------------------------------------

Ha! 

                int replyCode;
                if(file.isDirectory()) {
                	replyCode = FtpReply.REPLY_212_DIRECTORY_STATUS;
                } else {
                	replyCode = FtpReply.REPLY_213_FILE_STATUS;
                }


> STAT command returns wrong 200 state
> ------------------------------------
>
>                 Key: FTPSERVER-413
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-413
>             Project: FtpServer
>          Issue Type: Bug
>    Affects Versions: 1.0.5
>            Reporter: Mark Struberg
>            Assignee: Niklas Gustavsson
>             Fix For: 1.0.6, 1.1.0
>
>
> I'm now using MINA FtpServer for the Integration Tests of Apache mavens wagon-ftp. While upgrding from a 8 year old avalon based ftpserver jar, I figured that a unit test is broken. 
> This has to do with FtpServer returning a 200 state which is imo invalid.
> According to the officla RFC http://www.faqs.org/rfcs/rfc959.html STAT may only return the following codes:
>                STAT
>                   211, 212, 213
>                   450
>                   500, 501, 502, 421, 530
> I think returning 200 (command ok) after a STAT command is a bug.
>  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (FTPSERVER-413) STAT command returns wrong 200 state

Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FTPSERVER-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041253#comment-13041253 ] 

Mark Struberg commented on FTPSERVER-413:
-----------------------------------------

Just out of curiosity, which ret code can we expect in the future? ;)

> STAT command returns wrong 200 state
> ------------------------------------
>
>                 Key: FTPSERVER-413
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-413
>             Project: FtpServer
>          Issue Type: Bug
>    Affects Versions: 1.0.5
>            Reporter: Mark Struberg
>            Assignee: Niklas Gustavsson
>             Fix For: 1.0.6, 1.1.0
>
>
> I'm now using MINA FtpServer for the Integration Tests of Apache mavens wagon-ftp. While upgrding from a 8 year old avalon based ftpserver jar, I figured that a unit test is broken. 
> This has to do with FtpServer returning a 200 state which is imo invalid.
> According to the officla RFC http://www.faqs.org/rfcs/rfc959.html STAT may only return the following codes:
>                STAT
>                   211, 212, 213
>                   450
>                   500, 501, 502, 421, 530
> I think returning 200 (command ok) after a STAT command is a bug.
>  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (FTPSERVER-413) STAT command returns wrong 200 state

Posted by "Sebb (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FTPSERVER-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041347#comment-13041347 ] 

Sebb commented on FTPSERVER-413:
--------------------------------

Or in the case of STAT without a parameter:

ftp> quote STAT
211-Apache FtpServer
Connected to 127.0.0.1
Connected from 127.0.0.1
Logged in as anonymous
211 End of status.

which agrees with the RFC

> STAT command returns wrong 200 state
> ------------------------------------
>
>                 Key: FTPSERVER-413
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-413
>             Project: FtpServer
>          Issue Type: Bug
>    Affects Versions: 1.0.5
>            Reporter: Mark Struberg
>            Assignee: Niklas Gustavsson
>             Fix For: 1.0.6, 1.1.0
>
>
> I'm now using MINA FtpServer for the Integration Tests of Apache mavens wagon-ftp. While upgrding from a 8 year old avalon based ftpserver jar, I figured that a unit test is broken. 
> This has to do with FtpServer returning a 200 state which is imo invalid.
> According to the officla RFC http://www.faqs.org/rfcs/rfc959.html STAT may only return the following codes:
>                STAT
>                   211, 212, 213
>                   450
>                   500, 501, 502, 421, 530
> I think returning 200 (command ok) after a STAT command is a bug.
>  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (FTPSERVER-413) STAT command returns wrong 200 state

Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FTPSERVER-413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Niklas Gustavsson closed FTPSERVER-413.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.0
                   1.0.6
         Assignee: Niklas Gustavsson

Fixed in rev 1128769 and 1128770, thanks for reporting!

> STAT command returns wrong 200 state
> ------------------------------------
>
>                 Key: FTPSERVER-413
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-413
>             Project: FtpServer
>          Issue Type: Bug
>    Affects Versions: 1.0.5
>            Reporter: Mark Struberg
>            Assignee: Niklas Gustavsson
>             Fix For: 1.0.6, 1.1.0
>
>
> I'm now using MINA FtpServer for the Integration Tests of Apache mavens wagon-ftp. While upgrding from a 8 year old avalon based ftpserver jar, I figured that a unit test is broken. 
> This has to do with FtpServer returning a 200 state which is imo invalid.
> According to the officla RFC http://www.faqs.org/rfcs/rfc959.html STAT may only return the following codes:
>                STAT
>                   211, 212, 213
>                   450
>                   500, 501, 502, 421, 530
> I think returning 200 (command ok) after a STAT command is a bug.
>  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira