[GitHub] [accumulo] milleruntime commented on a diff in pull request #2703: Convert tables in monitor `/manager` page to DataTables

[GitBox <gi...@apache.org>]

milleruntime commented on code in PR #2703:
URL: https://github.com/apache/accumulo/pull/2703#discussion_r878102632


##########
server/monitor/src/main/resources/org/apache/accumulo/monitor/resources/js/functions.js:
##########
@@ -268,6 +268,19 @@ function createEmptyRow(col, msg) {
   return '<td class="center" colspan="' + col + '"><i>' + msg + '</i></td>';
 }
 
+/**
+ * Performs an ajax reload for the given DataTable
+ *
+ * @param {DataTable} table DataTable to perform an ajax reload on
+ */
+function ajaxReloadTable(table) {
+  if (table) {
+    table.ajax.reload(null, false); // user paging is not reset on reload
+  } else {
+    console.error('There was an error reloading the given table');

Review Comment:
   This is nice. You could log what was passed in.
   ```suggestion
       console.error('There was an error reloading the given table: ' + table);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org