[GitHub] [incubator-dolphinscheduler] chengshiwen commented on a change in pull request #4411: [Feature][API][backend] Query all upstream and downstream dependencies of the task

[GitBox <gi...@apache.org>]

chengshiwen commented on a change in pull request #4411:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4411#discussion_r554561624



##########
File path: dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/ProcessDefinitionServiceTest.java
##########
@@ -1329,4 +1329,9 @@ public void testImportProcessSchedule() {
         Assert.assertEquals(0, processDefinitionService.importProcessSchedule(loginUser, projectName, processMeta, processDefinitionName, processDefinitionId));
     }
 
+    @Test
+    public void  testQueryTaskDependenciesByTaskName() {

Review comment:
       You should provide UT for `testQueryTaskDependenciesByTaskName`

##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
##########
@@ -1836,5 +1836,10 @@ private void checkBatchOperateResult(String srcProjectName, String targetProject
         }
     }
 
+    public Map<String, Object> queryTaskDependenciesByTaskName(User loginUser, String projectName, Integer processId, String taskName) {
+
+        return null;

Review comment:
       The work seems to be unfinished




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org