You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@s2graph.apache.org by "DOYUNG YOON (JIRA)" <ji...@apache.org> on 2016/02/04 10:31:39 UTC

[jira] [Updated] (S2GRAPH-42) Bug on EdgeTransformer with specific cases.

     [ https://issues.apache.org/jira/browse/S2GRAPH-42?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

DOYUNG YOON updated S2GRAPH-42:
-------------------------------
    Description: 
With following example, EdgeTransform gives wrong transformed result.

{noformat}
given: "transform": [["age_band.slot.$.8", "age_band"]]
expected: "age_band.slot.${age_band}.8"
result: "age_band.slot.${age_band}"
{noformat}

so transform logic lose ".8" 

I think this problem comes from not comparable size on tokens split by "$" and values provided on EdgeTransformer.replace method.

"age_band.slot.$.8" yield ["age_band.slot.", ".8"]  and values provided into replace is only ["age_band"] so zipping these two lose last element of first list.

  was:
With following example, EdgeTransform gives wrong transformed result.

given: "transform": [["age_band.slot.$.8", "age_band"]]
expected: "age_band.slot.${age_band}.8"
result: "age_band.slot.${age_band}"

so transform logic lose ".8" 

I think this problem comes from not comparable size on tokens split by "$" and values provided on EdgeTransformer.replace method.

"age_band.slot.$.8" yield ["age_band.slot.", ".8"]  and values provided into replace is only ["age_band"] so zipping these two lose last element of first list.


> Bug on EdgeTransformer with specific cases.
> -------------------------------------------
>
>                 Key: S2GRAPH-42
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-42
>             Project: S2Graph
>          Issue Type: Bug
>            Reporter: DOYUNG YOON
>            Priority: Minor
>              Labels: easyfix
>
> With following example, EdgeTransform gives wrong transformed result.
> {noformat}
> given: "transform": [["age_band.slot.$.8", "age_band"]]
> expected: "age_band.slot.${age_band}.8"
> result: "age_band.slot.${age_band}"
> {noformat}
> so transform logic lose ".8" 
> I think this problem comes from not comparable size on tokens split by "$" and values provided on EdgeTransformer.replace method.
> "age_band.slot.$.8" yield ["age_band.slot.", ".8"]  and values provided into replace is only ["age_band"] so zipping these two lose last element of first list.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)