You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by "Mikhail Loenko (JIRA)" <ji...@apache.org> on 2006/01/26 10:36:16 UTC
[jira] Commented: (HARMONY-44) some security2 unit tests log
redundant information
[ http://issues.apache.org/jira/browse/HARMONY-44?page=comments#action_12364073 ]
Mikhail Loenko commented on HARMONY-44:
---------------------------------------
I've refactored a number of unit tests to get rid of 208 out of the 231 remaining "logln"s,
so if someone applies the previous patch I'll submit the next one.
To complete it would be good to discuss how do we log when it is necessary
Thanks,
Mikhail Loenko
Intel Middleware Products Division
> some security2 unit tests log redundant information
> ---------------------------------------------------
>
> Key: HARMONY-44
> URL: http://issues.apache.org/jira/browse/HARMONY-44
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Mikhail Loenko
> Assignee: Geir Magnusson Jr
> Priority: Trivial
> Attachments: patch.txt
>
> Information that is logged by security2 unit tests should be revisited. For example the following logs at the beginning of tests
> are not necessary and should be removed:
> logln("==test_02: UnrecoverableKeyException==");
> There are 231 occurrences of this kind out of 534 total logging calls in the security2 unit tests. I'm going to submit a patch
> removing logln("==...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (HARMONY-44) some security2 unit tests log
redundant information
Posted by Geir Magnusson Jr <ge...@pobox.com>.
Sure - maybe start a new thread here?
Mikhail Loenko (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/HARMONY-44?page=comments#action_12364073 ]
>
> Mikhail Loenko commented on HARMONY-44:
> ---------------------------------------
>
> I've refactored a number of unit tests to get rid of 208 out of the 231 remaining "logln"s,
> so if someone applies the previous patch I'll submit the next one.
>
> To complete it would be good to discuss how do we log when it is necessary
>
> Thanks,
> Mikhail Loenko
> Intel Middleware Products Division
>
>
>> some security2 unit tests log redundant information
>> ---------------------------------------------------
>>
>> Key: HARMONY-44
>> URL: http://issues.apache.org/jira/browse/HARMONY-44
>> Project: Harmony
>> Type: Improvement
>> Components: Classlib
>> Reporter: Mikhail Loenko
>> Assignee: Geir Magnusson Jr
>> Priority: Trivial
>> Attachments: patch.txt
>>
>> Information that is logged by security2 unit tests should be revisited. For example the following logs at the beginning of tests
>> are not necessary and should be removed:
>> logln("==test_02: UnrecoverableKeyException==");
>> There are 231 occurrences of this kind out of 534 total logging calls in the security2 unit tests. I'm going to submit a patch
>> removing logln("==...
>