You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/07/10 14:13:59 UTC
[GitHub] [beam] kennknowles opened a new pull request #12216: Re-enable checker in Samza job server
kennknowles opened a new pull request #12216:
URL: https://github.com/apache/beam/pull/12216
This module passes checker, because it has no source. This was previously
blocked by issues with other build infra.
The failure seems to reproduce only on Jenkins, opening PR to test.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | --- | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on a change in pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
kennknowles commented on a change in pull request #12216:
URL: https://github.com/apache/beam/pull/12216#discussion_r452978170
##########
File path: sdks/java/container/build.gradle
##########
@@ -77,7 +77,9 @@ golang {
import com.github.jk1.license.render.*
licenseReport {
outputDir = 'java_third_party_licenses'
- projects = [project.rootProject] + project.rootProject.subprojects
+ projects = [project,
+ project.rootProject.findProject(':sdks:java:harness'),
+ project.rootProject.findProject(':sdks:java:io:kafka')]
Review comment:
Hmmm. When I ran `:sdks:java:container:generateLicenseReport` before this PR I got 50 dependencies. After this PR I got 55. See the diff in the description. It mostly added new deps. The ones removed were:
- `checker-qual-3.4.1.jar`: this is `compileOnly` so we don't need it... but it should be in the configuration I chose...
- `hadoop-apache2-3.2.0-1.jar`: I hope this is not in the container!
- `icu4j-58.2.jar`: I don't know
- `objenesis-2.6.jar`: I don't know
- `woodstox-core-asl-4.4.1.jar`: I don't know
But it sounds like there's another problem because I should be able to repro and get 1400 licenses at head.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang commented on pull request #12216:
URL: https://github.com/apache/beam/pull/12216#issuecomment-657785349
> There was a failure to pull a license from another of the Beam modules because the name was wrong. It was called `fn-execution:2.24.0-SNAPSHOT`. This was already the case and my PR did not change it AFAIK.
>
> Also I did not actually change the PR when I squashed, but I did rebase past the version change to 2.24.0-SNAPSHOT. Perhaps it depends on the daily snapshot? But I do not know why that would fix incorrect artifact names.
[This setting](https://github.com/apache/beam/blob/master/sdks/java/container/build.gradle#L81) should exclude beam moduels. However, I *guess* beam.xxx are no longer considered as own group after changing the `projects` scope with this PR? It sounds like a bug of the third party plugin. I recommend trying with [`excludeGroups` option](https://github.com/jk1/Gradle-License-Report) provided by the plugin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12216:
URL: https://github.com/apache/beam/pull/12216#issuecomment-658299583
Yea interesting. I believe the dep report plugin does not handle project deps properly. The artifact ids it is trying to pull do not make sense. They are internal gradle project coords, not Maven coords. Reviewing the dependency report, they are reasonable deps actually.
I'll roll back. This is a bug in the license report plugin and/or how we are invoking it. This PR only added deps on projects, which previously we not present.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12216:
URL: https://github.com/apache/beam/pull/12216#issuecomment-656974979
Done. I have removed the no-longer-needed deps from dep_urls_java.yaml. If I have made a mistake we can always look in the history to get the data back.
But by the way @robinyqiu and @apilloud the zetasketch & zetasql libraries were in the list of libraries that don't ship with LICENSE in them so we had to work around by putting their URL in this file. It might be a nice-to-have for users at some point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12216:
URL: https://github.com/apache/beam/pull/12216#issuecomment-657694727
Rebasing to squash in fixup commit, then will merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12216:
URL: https://github.com/apache/beam/pull/12216#issuecomment-657780781
https://issues.apache.org/jira/browse/BEAM-9187 which said "sickbay" but is clearly running
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12216:
URL: https://github.com/apache/beam/pull/12216#issuecomment-657735289
Filed https://issues.apache.org/jira/browse/BEAM-10470 to track the flake in https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/12326/testReport/junit/org.apache.beam.sdk.extensions.sql.impl/JdbcDriverTest/testInternalConnect_unbounded_limit/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on a change in pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
kennknowles commented on a change in pull request #12216:
URL: https://github.com/apache/beam/pull/12216#discussion_r452886919
##########
File path: sdks/java/container/build.gradle
##########
@@ -77,7 +77,9 @@ golang {
import com.github.jk1.license.render.*
licenseReport {
outputDir = 'java_third_party_licenses'
- projects = [project.rootProject] + project.rootProject.subprojects
+ projects = [project,
+ project.rootProject.findProject(':sdks:java:harness'),
+ project.rootProject.findProject(':sdks:java:io:kafka')]
Review comment:
@mxm @chamikaramj incidentally, is this Kafka dep in the core Java harness still required?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang commented on pull request #12216:
URL: https://github.com/apache/beam/pull/12216#issuecomment-656882225
> Indeed, it was reduced from 1450 to 200. I think a lot of this is correct: previously the licenses for unrelated things like elasticsearch, flink, spark, hbase, etc, were all in the container.
I see, it sounds good.
I forgot to mention that [dep_urls_java.yaml](https://github.com/apache/beam/blob/master/sdks/java/container/license_scripts/dep_urls_java.yaml) should be updated accordingly, to make it maintainable and up to date.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12216:
URL: https://github.com/apache/beam/pull/12216#issuecomment-658304520
Oh yea definitely thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on a change in pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on a change in pull request #12216:
URL: https://github.com/apache/beam/pull/12216#discussion_r452992552
##########
File path: sdks/java/container/build.gradle
##########
@@ -77,7 +77,9 @@ golang {
import com.github.jk1.license.render.*
licenseReport {
outputDir = 'java_third_party_licenses'
- projects = [project.rootProject] + project.rootProject.subprojects
+ projects = [project,
+ project.rootProject.findProject(':sdks:java:harness'),
+ project.rootProject.findProject(':sdks:java:io:kafka')]
Review comment:
I think this can be removed now that Kafka dependencies are included in "sdks:java:io:expansion-service" which is used and staged by the kafka x-lang wrapper. But have to run some tests to confirm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12216:
URL: https://github.com/apache/beam/pull/12216#issuecomment-657799504
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12216:
URL: https://github.com/apache/beam/pull/12216#issuecomment-656834113
Indeed, it was reduced from 1450 to 200. I think a lot of this is correct: previously the licenses for unrelated things like elasticsearch, flink, spark, hbase, etc, were all in the container.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on a change in pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang commented on a change in pull request #12216:
URL: https://github.com/apache/beam/pull/12216#discussion_r452974413
##########
File path: sdks/java/container/build.gradle
##########
@@ -77,7 +77,9 @@ golang {
import com.github.jk1.license.render.*
licenseReport {
outputDir = 'java_third_party_licenses'
- projects = [project.rootProject] + project.rootProject.subprojects
+ projects = [project,
+ project.rootProject.findProject(':sdks:java:harness'),
+ project.rootProject.findProject(':sdks:java:io:kafka')]
Review comment:
Does this change include all dependencies installed in container? If so, it looks good for now.
This list should evolve if more dependencies are added to container, so we need to make it clear somewhere for developers who add new dependencies to container.
A minor update to [release guide](https://github.com/apache/beam/blob/master/website/www/site/content/en/contribute/release-guide.md) is needed. There is a step to check if all licenses are added by checking the number of licenses. Now we expect to see roughly 1400 dependencies. With this change, I think the number is reduced? Then the guide should be updated with a new number or find a better way to check if all expected licenses are included.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12216:
URL: https://github.com/apache/beam/pull/12216#issuecomment-657737628
There was a failure to pull a license from another of the Beam modules because the name was wrong. It was called `fn-execution:2.24.0-SNAPSHOT`. This was already the case and my PR did not change it AFAIK.
Also I did not actually change the PR when I squashed, but I did rebase past the version change to 2.24.0-SNAPSHOT. Perhaps it depends on the daily snapshot? But I do not know why that would fix incorrect artifact names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12216:
URL: https://github.com/apache/beam/pull/12216#issuecomment-657837672
Ah, green.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik edited a comment on pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
lukecwik edited a comment on pull request #12216:
URL: https://github.com/apache/beam/pull/12216#issuecomment-658277234
This is consistently failing for me to generate a report:
https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Phrase/278/consoleFull
Is there a known JIRA or should we rollback?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik edited a comment on pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
lukecwik edited a comment on pull request #12216:
URL: https://github.com/apache/beam/pull/12216#issuecomment-658277234
This is consistently failing for me:
https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Phrase/278/consoleFull
Is there a known JIRA or should we rollback?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang commented on pull request #12216:
URL: https://github.com/apache/beam/pull/12216#issuecomment-658301480
https://github.com/apache/beam/pull/12216#issuecomment-657785349
Is it worth trying it? explicitly exclude some groups.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12216:
URL: https://github.com/apache/beam/pull/12216#issuecomment-656838437
https://gist.github.com/kennknowles/16ce99d80a7839f68b00f7e37cee9f7f
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Hannah-Jiang commented on a change in pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
Hannah-Jiang commented on a change in pull request #12216:
URL: https://github.com/apache/beam/pull/12216#discussion_r452993301
##########
File path: sdks/java/container/build.gradle
##########
@@ -77,7 +77,9 @@ golang {
import com.github.jk1.license.render.*
licenseReport {
outputDir = 'java_third_party_licenses'
- projects = [project.rootProject] + project.rootProject.subprojects
+ projects = [project,
+ project.rootProject.findProject(':sdks:java:harness'),
+ project.rootProject.findProject(':sdks:java:io:kafka')]
Review comment:
Yep, need to run `pullLicenses` task with `--docker-pull-licenses` options. `generateLicenseReport` task pulls licenses from jars. If licenses are not distributed within jar, they are ignored. `pullLicenses` task pulls those missing licenses, so will have more licenses. But I don't think the gap should be 50 vs 1400.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on a change in pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
kennknowles commented on a change in pull request #12216:
URL: https://github.com/apache/beam/pull/12216#discussion_r452980835
##########
File path: sdks/java/container/build.gradle
##########
@@ -77,7 +77,9 @@ golang {
import com.github.jk1.license.render.*
licenseReport {
outputDir = 'java_third_party_licenses'
- projects = [project.rootProject] + project.rootProject.subprojects
+ projects = [project,
+ project.rootProject.findProject(':sdks:java:harness'),
+ project.rootProject.findProject(':sdks:java:io:kafka')]
Review comment:
I see. I need to run the wrapper script to further process the output of this command. I expect it will be monotonic (more output from generateLicenseReport --> more licenses in the end) but I will double check and do a full diff of the larger output.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles merged pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
kennknowles merged pull request #12216:
URL: https://github.com/apache/beam/pull/12216
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
lukecwik commented on pull request #12216:
URL: https://github.com/apache/beam/pull/12216#issuecomment-658277234
This is consistently failing for me:
https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Phrase/278/consoleFull
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12216:
URL: https://github.com/apache/beam/pull/12216#issuecomment-657736077
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12216: For Java container, generate license report only for container modules
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12216:
URL: https://github.com/apache/beam/pull/12216#issuecomment-657799415
Generating license report succeeded. The gradle scan shows two flakes:
- https://issues.apache.org/jira/browse/BEAM-9187
- https://issues.apache.org/jira/browse/BEAM-8454
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org