You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2023/01/12 06:50:35 UTC
[GitHub] [rocketmq-client-go] NeonToo opened a new pull request, #985: support RequestCode GET_CONSUMER_STATUS_FROM_CLIENT
NeonToo opened a new pull request, #985:
URL: https://github.com/apache/rocketmq-client-go/pull/985
## What is the purpose of the change
Support RequestCode `GET_CONSUMER_STATUS_FROM_CLIENT`
- Broker RequestCode `INVOKE_BROKER_TO_GET_CONSUMER_STATUS` will invoke each individual consumer to get
which message queues the consumer instance is processing
- Client is supposed to handle `GET_CONSUMER_STATUS_FROM_CLIENT` from Broker to return the Map of `<MessageQueue, MemoryOffset>` for the purpose of previous step
## Brief changelog
- `push_consumer` `pull_consumer` implements `getConsumerStatus(topic string, group string) *ConsumerStatus`
- `offset_store` implements `getMQOffsetMap(topic string) map[primitive.MessageQueue]int64` for consumer to get the `MQOffsetMap`
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] ShannonDing merged pull request #985: support RequestCode GET_CONSUMER_STATUS_FROM_CLIENT
Posted by "ShannonDing (via GitHub)" <gi...@apache.org>.
ShannonDing merged PR #985:
URL: https://github.com/apache/rocketmq-client-go/pull/985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] NeonToo commented on pull request #985: support RequestCode GET_CONSUMER_STATUS_FROM_CLIENT
Posted by "NeonToo (via GitHub)" <gi...@apache.org>.
NeonToo commented on PR #985:
URL: https://github.com/apache/rocketmq-client-go/pull/985#issuecomment-1537085002
related #1045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] maixiaohai commented on pull request #985: support RequestCode GET_CONSUMER_STATUS_FROM_CLIENT
Posted by "maixiaohai (via GitHub)" <gi...@apache.org>.
maixiaohai commented on PR #985:
URL: https://github.com/apache/rocketmq-client-go/pull/985#issuecomment-1505372728
hi @NeonToo the code is ok, could you link an related issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-commenter commented on pull request #985: support RequestCode GET_CONSUMER_STATUS_FROM_CLIENT
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #985:
URL: https://github.com/apache/rocketmq-client-go/pull/985#issuecomment-1380296588
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/985?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#985](https://codecov.io/gh/apache/rocketmq-client-go/pull/985?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd5a6de) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/896a8a3453be4bcfcb5bfb5bb9139c4df6d4cdab?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (896a8a3) will **decrease** coverage by `0.32%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #985 +/- ##
==========================================
- Coverage 23.32% 23.00% -0.33%
==========================================
Files 52 52
Lines 7266 7369 +103
==========================================
Hits 1695 1695
- Misses 5339 5442 +103
Partials 232 232
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [consumer/mock\_offset\_store.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3VtZXIvbW9ja19vZmZzZXRfc3RvcmUuZ28=) | `30.61% <0.00%> (-5.98%)` | :arrow_down: |
| [consumer/offset\_store.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3VtZXIvb2Zmc2V0X3N0b3JlLmdv) | `61.32% <0.00%> (-3.82%)` | :arrow_down: |
| [consumer/pull\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3VtZXIvcHVsbF9jb25zdW1lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `12.47% <0.00%> (-0.09%)` | :arrow_down: |
| [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.16% <0.00%> (-0.01%)` | :arrow_down: |
| [internal/model.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvbW9kZWwuZ28=) | `46.22% <0.00%> (-7.04%)` | :arrow_down: |
| [internal/request.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvcmVxdWVzdC5nbw==) | `1.53% <0.00%> (-0.09%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org