[GitHub] [maven-plugin-tools] slawekjaranowski commented on a diff in pull request #165: Use latest m-p-p and m-p-report-p also for the site of m-plugin-tools

[GitBox <gi...@apache.org>]

slawekjaranowski commented on code in PR #165:
URL: https://github.com/apache/maven-plugin-tools/pull/165#discussion_r1006550210


##########
pom.xml:
##########
@@ -325,6 +325,22 @@
             <trimStackTrace>false</trimStackTrace>
           </configuration>
         </plugin>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-plugin-plugin</artifactId>
+          <version>${project.version}</version>
+          <configuration>
+            <internalJavadocBaseUrl>./apidocs/</internalJavadocBaseUrl>
+            <externalJavadocBaseUrls>
+              <externalJavadocBaseUrl>https://docs.oracle.com/javase/8/docs/api/</externalJavadocBaseUrl>
+            </externalJavadocBaseUrls>
+          </configuration>
+        </plugin>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-plugin-report-plugin</artifactId>
+          <version>${project.version}</version>
+        </plugin>

Review Comment:
   IMHO we can't use it now in this way ... there is egg and hen problem
   We should use the latest released version
   
   The `maven-plugin-report-plugin` has not been released yet



##########
maven-plugin-plugin/pom.xml:
##########
@@ -271,7 +271,7 @@
     <plugins>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-plugin-plugin</artifactId>
+        <artifactId>maven-plugin-report-plugin</artifactId>

Review Comment:
   Here we will have a cycle ... `maven-plugin-report-plugin` also requires `maven-plugin-plugin`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org