You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shiro.apache.org by "Matt Traynham (JIRA)" <ji...@apache.org> on 2016/12/12 22:07:58 UTC
[jira] [Created] (SHIRO-605) ShiroWebModule creates out of order
filter chain.
Matt Traynham created SHIRO-605:
-----------------------------------
Summary: ShiroWebModule creates out of order filter chain.
Key: SHIRO-605
URL: https://issues.apache.org/jira/browse/SHIRO-605
Project: Shiro
Issue Type: Bug
Components: Integration: Guice
Affects Versions: 1.4.0-RC2
Reporter: Matt Traynham
Assignee: Jared Bunting
Fix For: 1.4.0-RC2
The ShiroWebModule class is creating a randomly ordered filter chain, because it's using a HashMap instead of a LinkedHashMap.
The offending line is here:
https://github.com/apache/shiro/blob/master/support/guice/src/main/java/org/apache/shiro/guice/web/ShiroWebModule.java#L144
This should be a LinkedHashMap to maintain original user order.
It does add the paths correctly:
https://github.com/apache/shiro/blob/master/support/guice/src/main/java/org/apache/shiro/guice/web/ShiroWebModule.java#L176
And correctly returns to the FilterChainProvider:
https://github.com/apache/shiro/blob/master/support/guice/src/main/java/org/apache/shiro/guice/web/ShiroWebModule.java#L135
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)