You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/01 22:03:48 UTC
[GitHub] [pulsar] mendonk opened a new pull request, #18706: [improve][doc] ConsumerBuilder.java comments
mendonk opened a new pull request, #18706:
URL: https://github.com/apache/pulsar/pull/18706
### Motivation
Improve the comments in ConsumerBuilder.java for clarity and cleanliness.
These can be the first documentation devs see in an IDE, so they should inspire more confidence in users.
### Modifications
Cleaned up the comments in the ConsumerBuilder.java file.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [X] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on a diff in pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#discussion_r1037638986
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -735,8 +736,8 @@
/**
* Buffering large number of outstanding uncompleted chunked messages can create memory pressure and it can be
- * guarded by providing this @maxPendingChunkedMessage threshold. Once, consumer reaches this threshold, it drops
- * the outstanding unchunked-messages by silently acking if autoAckOldestChunkedMessageOnQueueFull is true else it
+ * guarded by providing this @maxPendingChunkedMessage threshold. Once consumer reaches this threshold, it drops
+ * the outstanding unchunked-messages by silently acking if autoAckOldestChunkedMessageOnQueueFull is true, else it
Review Comment:
```suggestion
* the outstanding unchunked-messages by silently acknowledging if autoAckOldestChunkedMessageOnQueueFull is true, else it
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on a diff in pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#discussion_r1037652150
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -200,7 +200,7 @@
ConsumerBuilder<T> ackTimeout(long ackTimeout, TimeUnit timeUnit);
/**
- * Ack returns receipt but does not mean that the message is not resent after get receipt.
+ * Ack returns receipt, but the message is not re-sent after getting receipt.
Review Comment:
Also I think the should be clarified. As I understand, this is used for transactions. It should be explained what ack receipts are for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on a diff in pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#discussion_r1037638638
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -735,8 +736,8 @@
/**
* Buffering large number of outstanding uncompleted chunked messages can create memory pressure and it can be
- * guarded by providing this @maxPendingChunkedMessage threshold. Once, consumer reaches this threshold, it drops
- * the outstanding unchunked-messages by silently acking if autoAckOldestChunkedMessageOnQueueFull is true else it
+ * guarded by providing this @maxPendingChunkedMessage threshold. Once consumer reaches this threshold, it drops
Review Comment:
```suggestion
* guarded by providing this @maxPendingChunkedMessage threshold. Once the consumer reaches this threshold, it drops
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on a diff in pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#discussion_r1037631920
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -339,22 +339,22 @@
* Sets the size of the consumer receive queue.
*
* <p>The consumer receive queue controls how many messages can be accumulated by the {@link Consumer} before the
- * application calls {@link Consumer#receive()}. Using a higher value could potentially increase the consumer
+ * application calls {@link Consumer#receive()}. Using a higher value can potentially increase consumer
* throughput at the expense of bigger memory utilization.
*
* <p><b>Setting the consumer queue size as zero</b>
* <ul>
- * <li>Decreases the throughput of the consumer, by disabling pre-fetching of messages. This approach improves the
- * message distribution on shared subscription, by pushing messages only to the consumers that are ready to process
+ * <li>Decreases the throughput of the consumer by disabling pre-fetching of messages. This approach improves the
+ * message distribution on shared subscriptions by pushing messages only to the consumers that are ready to process
* them. Neither {@link Consumer#receive(int, TimeUnit)} nor Partitioned Topics can be used if the consumer queue
* size is zero. {@link Consumer#receive()} function call should not be interrupted when the consumer queue size is
* zero.</li>
- * <li>Doesn't support Batch-Message: if consumer receives any batch-message then it closes consumer connection with
- * broker and {@link Consumer#receive()} call remains blocked while {@link Consumer#receiveAsync()} receives
- * exception in callback. <b> consumer is not able to receive any further message unless batch-message in pipeline
+ * <li>Doesn't support Batch-Message. If consumer receives a batch-message, it closes consumer connection with
+ * broker and {@link Consumer#receive()} calls remains blocked while {@link Consumer#receiveAsync()} receives
+ * exception in callback. <b> Consumer is not able to receive any further messages unless batch-message in pipeline
Review Comment:
```suggestion
* exception in callback. <b> The consumer is not able to receive any further messages unless batch-message in pipeline
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on a diff in pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#discussion_r1037639639
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -747,8 +748,8 @@
ConsumerBuilder<T> autoAckOldestChunkedMessageOnQueueFull(boolean autoAckOldestChunkedMessageOnQueueFull);
/**
- * If producer fails to publish all the chunks of a message then consumer can expire incomplete chunks if consumer
- * won't be able to receive all chunks in expire times (default 1 minute).
+ * If producer fails to publish all the chunks of a message, then consumer can expire incomplete chunks if consumer
Review Comment:
```suggestion
* If the producer fails to publish all the chunks of a message, then the consumer can expire incomplete chunks if the consumer
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on a diff in pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#discussion_r1037631517
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -339,22 +339,22 @@
* Sets the size of the consumer receive queue.
*
* <p>The consumer receive queue controls how many messages can be accumulated by the {@link Consumer} before the
- * application calls {@link Consumer#receive()}. Using a higher value could potentially increase the consumer
+ * application calls {@link Consumer#receive()}. Using a higher value can potentially increase consumer
* throughput at the expense of bigger memory utilization.
*
* <p><b>Setting the consumer queue size as zero</b>
* <ul>
- * <li>Decreases the throughput of the consumer, by disabling pre-fetching of messages. This approach improves the
- * message distribution on shared subscription, by pushing messages only to the consumers that are ready to process
+ * <li>Decreases the throughput of the consumer by disabling pre-fetching of messages. This approach improves the
+ * message distribution on shared subscriptions by pushing messages only to the consumers that are ready to process
* them. Neither {@link Consumer#receive(int, TimeUnit)} nor Partitioned Topics can be used if the consumer queue
* size is zero. {@link Consumer#receive()} function call should not be interrupted when the consumer queue size is
* zero.</li>
- * <li>Doesn't support Batch-Message: if consumer receives any batch-message then it closes consumer connection with
- * broker and {@link Consumer#receive()} call remains blocked while {@link Consumer#receiveAsync()} receives
- * exception in callback. <b> consumer is not able to receive any further message unless batch-message in pipeline
+ * <li>Doesn't support Batch-Message. If consumer receives a batch-message, it closes consumer connection with
+ * broker and {@link Consumer#receive()} calls remains blocked while {@link Consumer#receiveAsync()} receives
Review Comment:
```suggestion
* the broker and {@link Consumer#receive()} calls remain blocked while {@link Consumer#receiveAsync()} receives
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on a diff in pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#discussion_r1037636374
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -498,8 +498,8 @@
* </pre>
*
* <p><b>Failover subscription</b>
- * Broker selects active consumer for a failover-subscription based on consumer's priority-level and
- * lexicographical sorting of a consumer name.
+ * Broker selects active consumer for a failover subscription based on consumer's priority-level and
Review Comment:
```suggestion
* The broker selects the active consumer for a failover subscription based on consumer's priority-level and
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#discussion_r1039236167
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -747,8 +752,8 @@
ConsumerBuilder<T> autoAckOldestChunkedMessageOnQueueFull(boolean autoAckOldestChunkedMessageOnQueueFull);
/**
- * If producer fails to publish all the chunks of a message then consumer can expire incomplete chunks if consumer
- * won't be able to receive all chunks in expire times (default 1 minute).
+ * If the producer fails to publish all the chunks of a message, then the consumer can expire incomplete chunks if the consumer
+ * doesn't receive all chunks during the expire time duration (default 1 minute).
Review Comment:
```suggestion
* doesn't receive all chunks during the expiration period (default 1 minute).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on a diff in pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#discussion_r1037637997
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -625,38 +625,39 @@
/**
* Set KeyShared subscription policy for consumer.
*
- * <p>By default, KeyShared subscription use auto split hash range to maintain consumers. If you want to
- * set a different KeyShared policy, you can set by following example:
+ * <p>By default, KeyShared subscriptions use auto split hash ranges to maintain consumers. If you want to
+ * set a different KeyShared policy, set a policy by one of the following examples:
*
+ * <p><b>Sticky hash range policy</b></p>
* <pre>
* client.newConsumer()
* .keySharedPolicy(KeySharedPolicy.stickyHashRange().ranges(Range.of(0, 10)))
* .subscribe();
* </pre>
- * Details about sticky hash range policy, please see {@link KeySharedPolicy.KeySharedPolicySticky}.
+ * For details about sticky hash range policies, see {@link KeySharedPolicy.KeySharedPolicySticky}.
*
- * <p>Or
+ * <p><b>Auto-split hash range policy</b></p>
* <pre>
* client.newConsumer()
* .keySharedPolicy(KeySharedPolicy.autoSplitHashRange())
* .subscribe();
* </pre>
- * Details about auto split hash range policy, please see {@link KeySharedPolicy.KeySharedPolicyAutoSplit}.
+ * For details about auto-split hash range policies, see {@link KeySharedPolicy.KeySharedPolicyAutoSplit}.
*
- * @param keySharedPolicy The {@link KeySharedPolicy} want to specify
+ * @param keySharedPolicy The {@link KeySharedPolicy} to specify
*/
ConsumerBuilder<T> keySharedPolicy(KeySharedPolicy keySharedPolicy);
/**
- * Set the consumer to include the given position of any reset operation like {@link Consumer#seek(long) or
+ * Set the consumer to include the given position of any reset operation like {@link Consumer#seek(long)} or
* {@link Consumer#seek(MessageId)}}.
*
* @return the consumer builder instance
*/
ConsumerBuilder<T> startMessageIdInclusive();
/**
- * Set batch receive policy {@link BatchReceivePolicy} for consumer.
+ * Set {@link BatchReceivePolicy} for consumer.
Review Comment:
```suggestion
* Set {@link BatchReceivePolicy} for the consumer.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#discussion_r1039235671
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -623,40 +627,41 @@
ConsumerBuilder<T> autoUpdatePartitionsInterval(int interval, TimeUnit unit);
/**
- * Set KeyShared subscription policy for consumer.
+ * Sets KeyShared subscription policy for consumer.
*
- * <p>By default, KeyShared subscription use auto split hash range to maintain consumers. If you want to
- * set a different KeyShared policy, you can set by following example:
+ * <p>By default, KeyShared subscriptions use auto split hash ranges to maintain consumers. If you want to
+ * set a different KeyShared policy, set a policy by one of the following examples:
Review Comment:
```suggestion
* set a different KeyShared policy, set a policy by using one of the following examples:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun merged pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #18706:
URL: https://github.com/apache/pulsar/pull/18706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on a diff in pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#discussion_r1037631079
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -339,22 +339,22 @@
* Sets the size of the consumer receive queue.
*
* <p>The consumer receive queue controls how many messages can be accumulated by the {@link Consumer} before the
- * application calls {@link Consumer#receive()}. Using a higher value could potentially increase the consumer
+ * application calls {@link Consumer#receive()}. Using a higher value can potentially increase consumer
* throughput at the expense of bigger memory utilization.
*
* <p><b>Setting the consumer queue size as zero</b>
* <ul>
- * <li>Decreases the throughput of the consumer, by disabling pre-fetching of messages. This approach improves the
- * message distribution on shared subscription, by pushing messages only to the consumers that are ready to process
+ * <li>Decreases the throughput of the consumer by disabling pre-fetching of messages. This approach improves the
+ * message distribution on shared subscriptions by pushing messages only to the consumers that are ready to process
* them. Neither {@link Consumer#receive(int, TimeUnit)} nor Partitioned Topics can be used if the consumer queue
* size is zero. {@link Consumer#receive()} function call should not be interrupted when the consumer queue size is
* zero.</li>
- * <li>Doesn't support Batch-Message: if consumer receives any batch-message then it closes consumer connection with
- * broker and {@link Consumer#receive()} call remains blocked while {@link Consumer#receiveAsync()} receives
- * exception in callback. <b> consumer is not able to receive any further message unless batch-message in pipeline
+ * <li>Doesn't support Batch-Message. If consumer receives a batch-message, it closes consumer connection with
Review Comment:
```suggestion
* <li>Doesn't support Batch-Message. If a consumer receives a batch-message, it closes the consumer connection with
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on a diff in pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#discussion_r1037632187
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -339,22 +339,22 @@
* Sets the size of the consumer receive queue.
*
* <p>The consumer receive queue controls how many messages can be accumulated by the {@link Consumer} before the
- * application calls {@link Consumer#receive()}. Using a higher value could potentially increase the consumer
+ * application calls {@link Consumer#receive()}. Using a higher value can potentially increase consumer
* throughput at the expense of bigger memory utilization.
*
* <p><b>Setting the consumer queue size as zero</b>
* <ul>
- * <li>Decreases the throughput of the consumer, by disabling pre-fetching of messages. This approach improves the
- * message distribution on shared subscription, by pushing messages only to the consumers that are ready to process
+ * <li>Decreases the throughput of the consumer by disabling pre-fetching of messages. This approach improves the
+ * message distribution on shared subscriptions by pushing messages only to the consumers that are ready to process
* them. Neither {@link Consumer#receive(int, TimeUnit)} nor Partitioned Topics can be used if the consumer queue
* size is zero. {@link Consumer#receive()} function call should not be interrupted when the consumer queue size is
* zero.</li>
- * <li>Doesn't support Batch-Message: if consumer receives any batch-message then it closes consumer connection with
- * broker and {@link Consumer#receive()} call remains blocked while {@link Consumer#receiveAsync()} receives
- * exception in callback. <b> consumer is not able to receive any further message unless batch-message in pipeline
+ * <li>Doesn't support Batch-Message. If consumer receives a batch-message, it closes consumer connection with
+ * broker and {@link Consumer#receive()} calls remains blocked while {@link Consumer#receiveAsync()} receives
+ * exception in callback. <b> Consumer is not able to receive any further messages unless batch-message in pipeline
* is removed</b></li>
* </ul>
- * Default value is {@code 1000} messages and should be good for most use cases.
+ * Default value is {@code 1000} messages and should be adequate for most use cases.
Review Comment:
```suggestion
* The default value is {@code 1000} messages and should be adequate for most use cases.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on a diff in pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#discussion_r1037638986
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -735,8 +736,8 @@
/**
* Buffering large number of outstanding uncompleted chunked messages can create memory pressure and it can be
- * guarded by providing this @maxPendingChunkedMessage threshold. Once, consumer reaches this threshold, it drops
- * the outstanding unchunked-messages by silently acking if autoAckOldestChunkedMessageOnQueueFull is true else it
+ * guarded by providing this @maxPendingChunkedMessage threshold. Once consumer reaches this threshold, it drops
+ * the outstanding unchunked-messages by silently acking if autoAckOldestChunkedMessageOnQueueFull is true, else it
Review Comment:
```suggestion
* the outstanding unchunked-messages by silently acknowledging if autoAckOldestChunkedMessageOnQueueFull is true, otherwise it
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on a diff in pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#discussion_r1037638246
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -671,7 +672,7 @@
ConsumerBuilder<T> batchReceivePolicy(BatchReceivePolicy batchReceivePolicy);
/**
- * If enabled, the consumer auto retries message.
+ * If enabled, the consumer auto-retries message.
Review Comment:
```suggestion
* If enabled, the consumer auto-retries messages.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on a diff in pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#discussion_r1037624591
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -269,10 +269,10 @@
ConsumerBuilder<T> subscriptionMode(SubscriptionMode subscriptionMode);
/**
- * Sets a {@link MessageListener} for the consumer
+ * Sets a {@link MessageListener} for the consumer.
Review Comment:
There's a mix of third-person verbs (eg,. `Sets`) and infinitives (eg. `Select`).
I think it should be made consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#discussion_r1039232568
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -200,30 +200,34 @@
ConsumerBuilder<T> ackTimeout(long ackTimeout, TimeUnit timeUnit);
/**
- * Ack returns receipt but does not mean that the message is not resent after get receipt.
+ * Acknowledgement returns receipt, but the message is not re-sent after getting receipt.
+ *
+ * Configure the acknowledgement timeout mechanism to redeliver the message if it is not acknowledged after
+ * ackTimeout, or to execute a timer task to check the acknowledgement timeout messages during every
+ * ackTimeoutTickTime period.
*
- * @param isAckReceiptEnabled {@link Boolean} is enable ack for receipt
+ * @param isAckReceiptEnabled {@link Boolean} enables acknowledgement for receipt
* @return the consumer builder instance
*/
ConsumerBuilder<T> isAckReceiptEnabled(boolean isAckReceiptEnabled);
/**
* Define the granularity of the ack-timeout redelivery.
*
- * <p>By default, the tick time is set to 1 second. Using an higher tick time
+ * <p>By default, the tick time is set to 1 second. Using a higher tick time
* reduces the memory overhead to track messages when the ack-timeout is set to
- * bigger values (eg: 1hour).
+ * bigger values (eg: 1 hour).
Review Comment:
```suggestion
* bigger values (e.g., 1 hour).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#issuecomment-1336779814
```
[INFO] There are 3 errors reported by Checkstyle 8.37 with /home/runner/work/pulsar/pulsar/buildtools/src/main/resources/pulsar/checkstyle.xml ruleset.
Error: src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:[358] (sizes) LineLength: Line is longer than 120 characters (found 123).
Error: src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:[744] (sizes) LineLength: Line is longer than 120 characters (found 131).
Error: src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:[755] (sizes) LineLength: Line is longer than 120 characters (found 131).
```
Please fix CI failure @mendonk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#discussion_r1039269394
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -363,25 +367,25 @@
ConsumerBuilder<T> receiverQueueSize(int receiverQueueSize);
/**
- * Group the consumer acknowledgments for the specified time.
+ * Sets amount of time for group consumer acknowledgments.
*
- * <p>By default, the consumer uses a 100 ms grouping time to send out the acknowledgments to the broker.
+ * <p>By default, the consumer uses a 100 ms grouping time to send out acknowledgments to the broker.
*
- * <p>Setting a group time of 0 sends out the acknowledgments immediately. A longer ack group time
- * is more efficient at the expense of a slight increase in message re-deliveries after a failure.
+ * <p>Setting a group time of 0 sends out acknowledgments immediately. A longer acknowledgment group time
+ * is more efficient, but at the expense of a slight increase in message re-deliveries after a failure.
*
* @param delay
- * the max amount of time an acknowledgemnt can be delayed
+ * the max amount of time an acknowledgement can be delayed
* @param unit
* the time unit for the delay
* @return the consumer builder instance
*/
ConsumerBuilder<T> acknowledgmentGroupTime(long delay, TimeUnit unit);
/**
- * Group the consumer acknowledgments for the max size.
+ * Sets number of messages for group consumer acknowledgments.
Review Comment:
```suggestion
* Set the number of messages for group consumer acknowledgments.
```
Is "group" necessary and accurate from tech perspective? From the grammar perspective, it should be "grouped" though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on a diff in pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#discussion_r1037623190
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -200,7 +200,7 @@
ConsumerBuilder<T> ackTimeout(long ackTimeout, TimeUnit timeUnit);
/**
- * Ack returns receipt but does not mean that the message is not resent after get receipt.
+ * Ack returns receipt, but the message is not re-sent after getting receipt.
Review Comment:
I would use `Acknowledgement`, not `Ack` in docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#issuecomment-1338853918
Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on a diff in pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#discussion_r1037633432
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -363,25 +363,25 @@
ConsumerBuilder<T> receiverQueueSize(int receiverQueueSize);
/**
- * Group the consumer acknowledgments for the specified time.
+ * Group consumer acknowledgments for the specified amount of time.
*
- * <p>By default, the consumer uses a 100 ms grouping time to send out the acknowledgments to the broker.
+ * <p>By default, the consumer uses a 100 ms grouping time to send out acknowledgments to the broker.
*
- * <p>Setting a group time of 0 sends out the acknowledgments immediately. A longer ack group time
- * is more efficient at the expense of a slight increase in message re-deliveries after a failure.
+ * <p>Setting a group time of 0 sends out acknowledgments immediately. A longer ack group time
+ * is more efficient, but at the expense of a slight increase in message re-deliveries after a failure.
*
* @param delay
- * the max amount of time an acknowledgemnt can be delayed
+ * the max amount of time an acknowledgement can be delayed
* @param unit
* the time unit for the delay
* @return the consumer builder instance
*/
ConsumerBuilder<T> acknowledgmentGroupTime(long delay, TimeUnit unit);
/**
- * Group the consumer acknowledgments for the max size.
+ * Group consumer acknowledgments for the max size.
Review Comment:
Can this be rephrased ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on a diff in pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#discussion_r1037640109
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -747,8 +748,8 @@
ConsumerBuilder<T> autoAckOldestChunkedMessageOnQueueFull(boolean autoAckOldestChunkedMessageOnQueueFull);
/**
- * If producer fails to publish all the chunks of a message then consumer can expire incomplete chunks if consumer
- * won't be able to receive all chunks in expire times (default 1 minute).
+ * If producer fails to publish all the chunks of a message, then consumer can expire incomplete chunks if consumer
+ * won't be able to receive all chunks in expire time duration (default 1 minute).
Review Comment:
```suggestion
* doesn't receive all chunks during the expire time duration (default 1 minute).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on a diff in pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
cbornet commented on code in PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#discussion_r1037635779
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -477,15 +477,15 @@
/**
* <b>Shared subscription</b>
- * Sets priority level for the shared subscription consumers to which broker gives more priority while dispatching
- * messages. Here, broker follows descending priorities. (eg: 0=max-priority, 1, 2,..)
+ * <p>Sets priority level for shared subscription consumers to determine which consumers the broker prioritizes when
+ * dispatching messages. Here, the broker follows descending priorities. (eg: 0=max-priority, 1, 2,..)
*
- * <p>In Shared subscription mode, broker first dispatches messages to max priority-level
- * consumers if they have permits, else broker considers next priority level consumers.
+ * <p>In Shared subscription mode, the broker first dispatches messages to max priority-level
+ * consumers if they have permits, otherwise the broker considers next priority level consumers.
*
- * <p>If subscription has consumer-A with priorityLevel 0 and Consumer-B with priorityLevel 1
- * then broker dispatches messages to only consumer-A until it runs out permit and then broker
- * starts dispatching messages to Consumer-B.
+ * <p>If a subscription has consumer-A with priorityLevel 0 and Consumer-B with priorityLevel 1,
+ * then broker dispatches messages to only consumer-A until it is drained, and then broker will
Review Comment:
```suggestion
* then the broker dispatches messages to only consumer-A until it is drained, and then the broker will
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#issuecomment-1336741581
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#discussion_r1039232340
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -140,12 +140,12 @@
ConsumerBuilder<T> topicsPattern(Pattern topicsPattern);
/**
- * Specify a pattern for topics that this consumer subscribes on.
+ * Specify a pattern for topics that this consumer subscribes to.
*
- * <p>It accepts regular expression that is compiled into a pattern internally. Eg.
+ * <p>Accepts a regular expression that is compiled into a pattern internally. Eg.
Review Comment:
```suggestion
* <p>It accepts a regular expression that is compiled into a pattern internally. E.g.,
```
I don't think changing it to a third-person verb is a good idea. IMO, it makes the annotation even more complex, especially when it's inconsistent throughout the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #18706: [improve][doc] ConsumerBuilder.java comments
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18706:
URL: https://github.com/apache/pulsar/pull/18706#issuecomment-1337709516
# [Codecov](https://codecov.io/gh/apache/pulsar/pull/18706?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18706](https://codecov.io/gh/apache/pulsar/pull/18706?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (25ed28b) into [master](https://codecov.io/gh/apache/pulsar/commit/bbc7a25d3b2007c84b9bcd3a67205d0256dc4b3c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bbc7a25) will **decrease** coverage by `3.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/pulsar/pull/18706?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18706 +/- ##
============================================
- Coverage 48.34% 45.27% -3.08%
- Complexity 9368 9817 +449
============================================
Files 618 677 +59
Lines 58586 66562 +7976
Branches 6097 7130 +1033
============================================
+ Hits 28326 30134 +1808
- Misses 27078 32912 +5834
- Partials 3182 3516 +334
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `45.27% <ø> (-3.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/18706?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...g/apache/pulsar/broker/service/StreamingStats.java](https://codecov.io/gh/apache/pulsar/pull/18706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL1N0cmVhbWluZ1N0YXRzLmphdmE=) | `0.00% <0.00%> (-83.79%)` | :arrow_down: |
| [...sar/broker/stats/metrics/ManagedLedgerMetrics.java](https://codecov.io/gh/apache/pulsar/pull/18706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zdGF0cy9tZXRyaWNzL01hbmFnZWRMZWRnZXJNZXRyaWNzLmphdmE=) | `23.88% <0.00%> (-76.12%)` | :arrow_down: |
| [...lsar/broker/service/StickyKeyConsumerSelector.java](https://codecov.io/gh/apache/pulsar/pull/18706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL1N0aWNreUtleUNvbnN1bWVyU2VsZWN0b3IuamF2YQ==) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...ersistentStickyKeyDispatcherMultipleConsumers.java](https://codecov.io/gh/apache/pulsar/pull/18706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL25vbnBlcnNpc3RlbnQvTm9uUGVyc2lzdGVudFN0aWNreUtleURpc3BhdGNoZXJNdWx0aXBsZUNvbnN1bWVycy5qYXZh) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...lsar/broker/service/InMemoryRedeliveryTracker.java](https://codecov.io/gh/apache/pulsar/pull/18706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL0luTWVtb3J5UmVkZWxpdmVyeVRyYWNrZXIuamF2YQ==) | `58.82% <0.00%> (-29.42%)` | :arrow_down: |
| [...lsar/broker/loadbalance/impl/ThresholdShedder.java](https://codecov.io/gh/apache/pulsar/pull/18706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9sb2FkYmFsYW5jZS9pbXBsL1RocmVzaG9sZFNoZWRkZXIuamF2YQ==) | `3.27% <0.00%> (-27.87%)` | :arrow_down: |
| [...ersistentStickyKeyDispatcherMultipleConsumers.java](https://codecov.io/gh/apache/pulsar/pull/18706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3BlcnNpc3RlbnQvUGVyc2lzdGVudFN0aWNreUtleURpc3BhdGNoZXJNdWx0aXBsZUNvbnN1bWVycy5qYXZh) | `18.31% <0.00%> (-24.76%)` | :arrow_down: |
| [...ker/loadbalance/impl/LeastLongTermMessageRate.java](https://codecov.io/gh/apache/pulsar/pull/18706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9sb2FkYmFsYW5jZS9pbXBsL0xlYXN0TG9uZ1Rlcm1NZXNzYWdlUmF0ZS5qYXZh) | `73.33% <0.00%> (-20.00%)` | :arrow_down: |
| [.../org/apache/pulsar/broker/lookup/LookupResult.java](https://codecov.io/gh/apache/pulsar/pull/18706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9sb29rdXAvTG9va3VwUmVzdWx0LmphdmE=) | `56.66% <0.00%> (-20.00%)` | :arrow_down: |
| [...e/HashRangeAutoSplitStickyKeyConsumerSelector.java](https://codecov.io/gh/apache/pulsar/pull/18706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL0hhc2hSYW5nZUF1dG9TcGxpdFN0aWNreUtleUNvbnN1bWVyU2VsZWN0b3IuamF2YQ==) | `0.00% <0.00%> (-19.36%)` | :arrow_down: |
| ... and [185 more](https://codecov.io/gh/apache/pulsar/pull/18706/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org