[GitHub] [arrow-datafusion] alamb edited a comment on issue #1540: Replace DataFusionError/Result with impl Error for ObjectStore and Reader

[GitBox <gi...@apache.org>]

alamb edited a comment on issue #1540:
URL: https://github.com/apache/arrow-datafusion/issues/1540#issuecomment-1010301819


   @matthewmturner 
   
   It is possible today to return a `Box<dyn Error>` as a `DatafusionError`which is to return a `DataFusionError::ArrowArrowError::External(Box::new(boxed_error))`. Here is an example which is pretty nasty but works that we use in IOx: 
   
   https://github.com/influxdata/influxdb_iox/blob/e8ddc4e0db4c59f039a34f0e3297c9eb495c1d5a/query/src/exec/non_null_checker.rs#L271
   
   Given how nasty that is, one alternative might be to add a `DataFusion::External` and follow  the model of `ArrowError::External` in https://github.com/apache/arrow-rs/blob/master/arrow/src/error.rs#L29
   
   Or maybe we can add a `From<Box dyn Error> for DataFusionError` to make the conversion nicer
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org