You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "jujoramos (GitHub)" <gi...@apache.org> on 2019/03/13 12:30:11 UTC

[GitHub] [geode] jujoramos commented on pull request #3298: GEODE-6519: Fix CreateGatewaySenderCommand Flags

I actually had doubts about this one as it "breaks" the purpose of the PR... however, this flag is actually [`deprecated`](https://geode.apache.org/docs/guide/18/tools_modules/gfsh/command-pages/create.html#topic_hg2_bjz_ck) and users must avoid using it at all cost: it might cause data loss and several other issues during startup, that's why I just left it as `false` on purpose. Long story short, if a user wants to enable `manual-start`, they actually need to know exactly what they're doing and specify the entire argument as `--manual-start=true`.
Just my two cents, I can revert it if you don't agree with the above.

[ Full content available at: https://github.com/apache/geode/pull/3298 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org