You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by yonzhang <gi...@git.apache.org> on 2016/03/11 21:49:08 UTC
[GitHub] incubator-eagle pull request: Eagle 198 integrate new Siddhi versi...
GitHub user yonzhang opened a pull request:
https://github.com/apache/incubator-eagle/pull/122
Eagle 198 integrate new Siddhi version so that thread should not die when event evaluation fails
when exception happens within Siddhi processing thread, it can continue to work
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yonzhang/incubator-eagle EAGLE-198
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/122.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #122
----
commit 84d4723d8263b1c16b54efff3da04f79373bc583
Author: yonzhang <yo...@gmail.com>
Date: 2016-03-11T19:19:59Z
change dataSource to application
commit 267a8d385e10c000e117b32436ed6b69608a9d39
Author: yonzhang <yo...@gmail.com>
Date: 2016-03-11T20:47:30Z
upgrade siddhi to 3.0.5
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: Eagle 198 integrate new Siddhi versi...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the pull request:
https://github.com/apache/incubator-eagle/pull/122#issuecomment-196721133
If so, then we don't need to customize SiddhiPolicyExceptionHandler then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: Eagle 198 integrate new Siddhi versi...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/122#discussion_r55932462
--- Diff: eagle-core/eagle-policy/eagle-policy-base/src/main/java/org/apache/eagle/policy/siddhi/SiddhiPolicyEvaluator.java ---
@@ -130,6 +133,7 @@ private SiddhiRuntime createSiddhiRuntime(SiddhiPolicyDefinition policyDef) {
try {
executionPlanRuntime = siddhiManager.createExecutionPlanRuntime(executionPlan);
+ executionPlanRuntime.handleExceptionWith(new SiddhiPolicyExceptionHandler());
--- End diff --
My patch is to extend capability of customizing exception handler for siddhi while it uses FatalExceptionHandler by default, so here we should override our own exception handler `SiddhiPolicyExceptionHandler` and explicitly specify by `handleExceptionWith`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: Eagle 198 integrate new Siddhi versi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-eagle/pull/122
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: Eagle 198 integrate new Siddhi versi...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the pull request:
https://github.com/apache/incubator-eagle/pull/122#issuecomment-195883819
Another problem is Ci failed due to
~~~
Tests in error:
testExternalTimeSlideWindowWithGroupby(org.apache.eagle.alert.state.TestSiddhiStateSnapshotAndRestore)
Tests run: 37, Failures: 0, Errors: 1, Skipped: 1
~~~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: Eagle 198 integrate new Siddhi versi...
Posted by yonzhang <gi...@git.apache.org>.
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/122#issuecomment-196411766
now after 3.0.5, the default exception handler is not FatalExceptionHandler, do we still need SiddhiPolicyExceptionHandler?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---