You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Vimal Sharma <vi...@hortonworks.com> on 2017/01/25 12:28:21 UTC
Review Request 55928: Notification processing to use new instance API
for create and full-update
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55928/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-1499
https://issues.apache.org/jira/browse/ATLAS-1499
Repository: atlas
Description
-------
Atlas Server notifies the entity change listeners(NotificationEntityChangeListener, EntityAuditListener) after any create/update operation on entities.
The create/update routines have been changed in ATLAS-1467. The corresponding changes are required in notification processing.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasAbstractFormatConverter.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasArrayFormatConverter.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasClassificationFormatConverter.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasEntityFormatConverter.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasEnumFormatConverter.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasFormatConverter.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasFormatConverters.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasInstanceRestAdapters.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasMapFormatConverter.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasPrimitiveFormatConverter.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasStructFormatConverter.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 18e397b
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasAbstractFormatConverter.java f1f3d18
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java e3b4efa
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasClassificationFormatConverter.java da71c31
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java 74ab740
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEnumFormatConverter.java 4f22437
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverter.java 079f3be
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java 7c3f536
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 2b13552
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java f390e82
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java 382d1ef
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java 8777510
webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 5107767
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java ee1174a
Diff: https://reviews.apache.org/r/55928/diff/
Testing
-------
Testing not done.
public AtlasEntity getById(final String guid) is not yet implemented. Will be looking into implementing it and then testing the patch
Thanks,
Vimal Sharma
Re: Review Request 55928: Notification processing to use new instance
API for create and full-update
Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55928/
-----------------------------------------------------------
(Updated Jan. 27, 2017, 12:31 p.m.)
Review request for atlas.
Changes
-------
Added test to verify that the Entity change listener records entity create/update when create/update is perfomed using the new Instance API
Bugs: ATLAS-1499
https://issues.apache.org/jira/browse/ATLAS-1499
Repository: atlas
Description
-------
Atlas Server notifies the entity change listeners(NotificationEntityChangeListener, EntityAuditListener) after any create/update operation on entities.
The create/update routines have been changed in ATLAS-1467. The corresponding changes are required in notification processing.
Diffs (updated)
-----
intg/src/test/java/org/apache/atlas/TestUtilsV2.java 4f2916c
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasAbstractFormatConverter.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasArrayFormatConverter.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasClassificationFormatConverter.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasEntityFormatConverter.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasEnumFormatConverter.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasFormatConverter.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasFormatConverters.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasInstanceRestAdapters.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasMapFormatConverter.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasPrimitiveFormatConverter.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasStructFormatConverter.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 1ef803c
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 48bb77e
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java c902f81
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasAbstractFormatConverter.java f1f3d18
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java e3b4efa
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasClassificationFormatConverter.java da71c31
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java 75a7183
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEnumFormatConverter.java 4f22437
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverter.java 079f3be
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java 7c3f536
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 7368c72
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java f390e82
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java 382d1ef
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java 8777510
webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 5107767
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java ee1174a
Diff: https://reviews.apache.org/r/55928/diff/
Testing (updated)
-------
Testing done.
Thanks,
Vimal Sharma