You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/22 18:00:11 UTC

[GitHub] [incubator-tvm] jtuyls commented on pull request #6343: [BYOC][CONTRIB] Vitis-AI codegen integration

jtuyls commented on pull request #6343:
URL: https://github.com/apache/incubator-tvm/pull/6343#issuecomment-696884819


   > @zhiics @comaniac @anilmartha I'd like to revive this PR so we can consider merging it in. As @mbaret pointed, please mark your comments as resolved if they have been addressed. If anything is still outstanding, please make it clear what you'd like @anilmartha to change.
   
   @tmoreau89 @comaniac We are currently working on following pieces to be added based on the comments:
   - Serialization of Vitis-AI build info into the TVM binary stream instead of using the previous directory based approach, see [comment](https://github.com/apache/incubator-tvm/pull/6343#discussion_r479204365). This is currently being verified internally. This should also address organizing Vitis-AI artifacts [comment 1](https://github.com/apache/incubator-tvm/pull/6343#discussion_r484641148) and [comment 2](https://github.com/apache/incubator-tvm/pull/6343#discussion_r483081818).
   - Add additional codegen tests based on [comment](https://github.com/apache/incubator-tvm/pull/6343#discussion_r479237191)
   - Address [comment](https://github.com/apache/incubator-tvm/pull/6343#discussion_r479581117) on 2 subgraphs test
   - Address renaming [comment](https://github.com/apache/incubator-tvm/pull/6343#discussion_r479239611)
   
   We will add these pieces shortly and will tag reviewers to have a look.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org