You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "eitsupi (via GitHub)" <gi...@apache.org> on 2025/02/07 13:02:53 UTC
[PR] MINOR: [CI][R] Ensure install R on ubuntu-24.04 runner for R nightly build jobs [arrow]
eitsupi opened a new pull request, #45464:
URL: https://github.com/apache/arrow/pull/45464
### Rationale for this change
Related to #45377.
As a result of the recent change in the ubuntu-latest GHA runner from ubuntu-22.04 to ubuntu-24.04, it appears that the tools included in the runner from the start have changed and jobs that assume R is already installed will now fail.
Installing R the job should now succeed.
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45377: [CI][R] Ensure install R on ubuntu-24.04 runner for R nightly build jobs [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #45464:
URL: https://github.com/apache/arrow/pull/45464#discussion_r1947532005
##########
.github/workflows/r_nightly.yml:
##########
@@ -60,7 +60,7 @@ jobs:
repository: ursacomputing/crossbow
ref: main
- name: Set up Python
- uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
+ uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
Review Comment:
Right. We should unify end-of-line characters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45377: [CI][R] Ensure install R on ubuntu-24.04 runner for R nightly build jobs [arrow]
Posted by "eitsupi (via GitHub)" <gi...@apache.org>.
eitsupi commented on PR #45464:
URL: https://github.com/apache/arrow/pull/45464#issuecomment-2655076473
Thanks, it seems fixed.
https://github.com/apache/arrow/actions/runs/13287094995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45377: [CI][R] Ensure install R on ubuntu-24.04 runner for R nightly build jobs [arrow]
Posted by "eitsupi (via GitHub)" <gi...@apache.org>.
eitsupi commented on code in PR #45464:
URL: https://github.com/apache/arrow/pull/45464#discussion_r1946512338
##########
.github/workflows/r_nightly.yml:
##########
@@ -60,7 +60,7 @@ jobs:
repository: ursacomputing/crossbow
ref: main
- name: Set up Python
- uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
+ uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
Review Comment:
I don't recall editing this, but perhaps the line ending characters have been changed (there was a warning about mixing LF and CRLF when opened on GitHub. I did the edit in VSCode on GitHub, which probably automatically unified the end-of-line characters).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45377: [CI][R] Ensure install R on ubuntu-24.04 runner for R nightly build jobs [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45464:
URL: https://github.com/apache/arrow/pull/45464#issuecomment-2644561672
```
Only contributors can submit requests to this bot. Please ask someone from the community for help with getting the first commit in.
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/13213548619
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45377: [CI][R] Ensure install R on ubuntu-24.04 runner for R nightly build jobs [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45464:
URL: https://github.com/apache/arrow/pull/45464#issuecomment-2642878203
:warning: GitHub issue #45377 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45377: [CI][R] Ensure install R on ubuntu-24.04 runner for R nightly build jobs [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #45464:
URL: https://github.com/apache/arrow/pull/45464#issuecomment-2653790486
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 18e8f50729c1f7e615f9647f2c4501efef0e7b26.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/37098122065) has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45377: [CI][R] Ensure install R on ubuntu-24.04 runner for R nightly build jobs [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #45464:
URL: https://github.com/apache/arrow/pull/45464#issuecomment-2644673174
`@github-actions crossbow submit` is for jobs defined under `dev/tasks/` but this is defined under `.github/workflows/`...
Can we test this by adding the following?
```diff
diff --git a/.github/workflows/r_nightly.yml b/.github/workflows/r_nightly.yml
index 2da69bd705..20477356f7 100644
--- a/.github/workflows/r_nightly.yml
+++ b/.github/workflows/r_nightly.yml
@@ -21,6 +21,9 @@ name: Upload R Nightly builds
# from the crossbow repository.
on:
+ pull_request:
+ path: '.github/workflows/r_nightly.yml'
+
workflow_dispatch:
inputs:
prefix:
```
(We will need to add some `if:`. Some steps needs secrets that are available only in apache/arrow.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45477: [CI][R] Ensure install R on ubuntu-24.04 runner for R nightly build jobs [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45464:
URL: https://github.com/apache/arrow/pull/45464#issuecomment-2642876349
:x: GitHub issue #45477 could not be retrieved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45377: [CI][R] Ensure install R on ubuntu-24.04 runner for R nightly build jobs [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #45464:
URL: https://github.com/apache/arrow/pull/45464#issuecomment-2655229203
Yay!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45377: [CI][R] Ensure install R on ubuntu-24.04 runner for R nightly build jobs [arrow]
Posted by "eitsupi (via GitHub)" <gi...@apache.org>.
eitsupi commented on PR #45464:
URL: https://github.com/apache/arrow/pull/45464#issuecomment-2644559523
@kou Is it not enough to just run a CI as this like comment?
https://github.com/apache/arrow/pull/13411#issuecomment-1162229336
Just to be sure, I don't have the permissions to run this, do I? (I'm sure it's written somewhere in the docs, but I couldn't find it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45377: [CI][R] Ensure install R on ubuntu-24.04 runner for R nightly build jobs [arrow]
Posted by "eitsupi (via GitHub)" <gi...@apache.org>.
eitsupi commented on PR #45464:
URL: https://github.com/apache/arrow/pull/45464#issuecomment-2644561430
@github-actions crossbow submit r-nightly-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45377: [CI][R] Ensure install R on ubuntu-24.04 runner for R nightly build jobs [arrow]
Posted by "eitsupi (via GitHub)" <gi...@apache.org>.
eitsupi commented on PR #45464:
URL: https://github.com/apache/arrow/pull/45464#issuecomment-2644749400
Thanks for the reply. I understand.
This seems to be a far more difficult issue than I think and I don't have the time to dig deeper into this, so please feel free to close this if you can't merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45377: [CI][R] Ensure install R on ubuntu-24.04 runner for R nightly build jobs [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #45464:
URL: https://github.com/apache/arrow/pull/45464#issuecomment-2642878073
@raulcd @assignUser Do you have any idea how to test this...?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45377: [CI][R] Ensure install R on ubuntu-24.04 runner for R nightly build jobs [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #45464:
URL: https://github.com/apache/arrow/pull/45464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org