You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2015/12/11 13:09:04 UTC
[GitHub] incubator-tinkerpop pull request: TINKERPOP-954 Consistent test di...
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/178
TINKERPOP-954 Consistent test directory usage
https://issues.apache.org/jira/browse/TINKERPOP-954
Got all hard-coded directories in tests using refined methods in `TestHelper`. That basically gets everything behind the `/target/test-case-data` directory in a consistent fashion. I also went a step further and used the class name passed to `TestHelper` (formerly just used to orient the `/target` directory) to include a subdirectory structure which then yields `/target/test-case-data/ClassName` so that it's easy to find the test data output in case it needs to be reviewed.
Ran the full test suite with integration tests and all passed.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-954
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/178.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #178
----
commit da2eb7e427b556cfa7926e53eee55cf591876ad2
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2015-12-10T18:43:49Z
Consolidated all test data directories in a consistent fashion.
Removed references to /tmp and hardcoded references to /target. I think I have them all, but hard to say for sure. Extended TestHelper a little bit with a few more methods and made it easier to find data generated for a specific test.
commit 740ed131e735cdb3ca2561bb52c5b4fa9e9e5541
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2015-12-11T10:14:24Z
Fixed up some problems in the Hadoop plugin tests around hdfs testing.
commit cfdad57c8b6d006e6f011d9341ea585494fa2a17
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2015-12-11T10:17:04Z
Add a bit more javadoc to the getWorkingDirectory method promoted to GraphProvider.
commit 89f027d5797cea499a4ba6030f12d600b6d65c16
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2015-12-11T10:18:24Z
Updated changelog.
commit ad9facbaf49d6df2e1f40fa38f648b5d82821f66
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2015-12-11T11:16:50Z
Add some notes about unit testing to dev docs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-954 Consistent test di...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/178#issuecomment-164510250
* `mvn clean install`: worked
* integration tests: worked
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-954 Consistent test di...
Posted by twilmes <gi...@git.apache.org>.
Github user twilmes commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/178#issuecomment-164530910
Yep, tests are good here.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-954 Consistent test di...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/178
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---