You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "danny0405 (via GitHub)" <gi...@apache.org> on 2023/04/19 03:13:46 UTC

[GitHub] [hudi] danny0405 commented on a diff in pull request #8491: [HUDI-6095] Refactor the judgment condition of WorkloadProfile

danny0405 commented on code in PR #8491:
URL: https://github.com/apache/hudi/pull/8491#discussion_r1170763841


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/BaseCommitActionExecutor.java:
##########
@@ -230,10 +230,6 @@ protected String getSchemaToStoreInCommit() {
     return config.getSchema();
   }
 
-  protected boolean isWorkloadProfileNeeded() {
-    return true;
-  }
-

Review Comment:
   There is no use case for it to return false right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org