You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Alok Lal <al...@hortonworks.com> on 2015/09/30 02:11:15 UTC
Review Request 38868: RANGER-672 v0.4 plugins can't download policies
from v0.5 server
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38868/
-----------------------------------------------------------
Review request for ranger and Madhan Neethiraj.
Bugs: RANGER-672
https://issues.apache.org/jira/browse/RANGER-672
Repository: ranger
Description
-------
old api to download policies must be callable without a user. However, it was calling a protected api in servicerest. That part of code was changed to avoid calling into protected rest endpoint. Other endpoints in assetrest that can be called without a user in context were checked to make sure that they did not call protected rest apis in servicerest.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 8a637a0
security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 19dbfaa
Diff: https://reviews.apache.org/r/38868/diff/
Testing
-------
existing tests work. Invoking of old api to download policies does not give 404 anymore.
Thanks,
Alok Lal
Re: Review Request 38868: RANGER-672 v0.4 plugins can't download
policies from v0.5 server
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38868/#review101050
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Sept. 30, 2015, 12:11 a.m., Alok Lal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38868/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2015, 12:11 a.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-672
> https://issues.apache.org/jira/browse/RANGER-672
>
>
> Repository: ranger
>
>
> Description
> -------
>
> old api to download policies must be callable without a user. However, it was calling a protected api in servicerest. That part of code was changed to avoid calling into protected rest endpoint. Other endpoints in assetrest that can be called without a user in context were checked to make sure that they did not call protected rest apis in servicerest.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 8a637a0
> security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 19dbfaa
>
> Diff: https://reviews.apache.org/r/38868/diff/
>
>
> Testing
> -------
>
> existing tests work. Invoking of old api to download policies does not give 404 anymore.
>
>
> Thanks,
>
> Alok Lal
>
>