[GitHub] [pulsar] gaoran10 commented on a diff in pull request #19546: [improve][broker] PIP-192 Added Deleted and Init states in ServiceUnitState

["gaoran10 (via GitHub)" <gi...@apache.org>]

gaoran10 commented on code in PR #19546:
URL: https://github.com/apache/pulsar/pull/19546#discussion_r1111672002


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java:
##########
@@ -268,11 +338,13 @@ public synchronized void close() throws PulsarServerException {
                 log.info("Successfully closed the channel producer.");
             }
 
-            // TODO: clean brokerRegistry
+            if (brokerRegistry != null) {
+                brokerRegistry = null;

Review Comment:
   Ok, thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org