You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/11/16 08:25:59 UTC
[GitHub] [avro] RikHeijdens opened a new pull request, #1968: AVRO-3674: Namespaced schema lookup failures
RikHeijdens opened a new pull request, #1968:
URL: https://github.com/apache/avro/pull/1968
<!--
*Thank you very much for contributing to Apache Avro - we are happy that you want to help us improve Avro. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Avro a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/AVRO/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "AVRO-XXXX: [component] Title of the pull request", where *AVRO-XXXX* should be replaced by the actual issue number.
The *component* is optional, but can help identify the correct reviewers faster: either the language ("java", "python") or subsystem such as "build" or "doc" are good candidates.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests. You can [build the entire project](https://github.com/apache/avro/blob/master/BUILD.md) or just the [language-specific SDK](https://avro.apache.org/project/how-to-contribute/#unit-tests).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Every commit message references Jira issues in their subject lines. In addition, commits follow the guidelines from [How to write a good git commit message](https://chris.beams.io/posts/git-commit/)
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
-->
## What is the purpose of the change
[AVRO-3674](https://issues.apache.org/jira/browse/AVRO-3674)
This PR introduces a test-case and a potential fix to describe and perhaps fix the issue described in AVRO-3674.
## Verifying this change
This change added tests and can be verified as follows:
* Run cargo test from `lang/rust/avro`
## Documentation
- Does this pull request introduce a new feature? No
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RikHeijdens commented on pull request #1968: AVRO-3674: Namespaced schema lookup failures
Posted by GitBox <gi...@apache.org>.
RikHeijdens commented on PR #1968:
URL: https://github.com/apache/avro/pull/1968#issuecomment-1319883772
That's fine! I suppose that is because I created a PR from a fork of this repository. Feel free to close this PR after creating a new branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RikHeijdens commented on a diff in pull request #1968: AVRO-3674: Namespaced schema lookup failures
Posted by GitBox <gi...@apache.org>.
RikHeijdens commented on code in PR #1968:
URL: https://github.com/apache/avro/pull/1968#discussion_r1023670948
##########
lang/rust/avro/src/types.rs:
##########
@@ -2391,4 +2417,148 @@ Field with name '"b"' is not a member of the map items"#,
"field b record is invalid against the schema"
); // this should pass, but doesn't
}
+
+ #[test]
+ fn test_avro_3674_validate_namespace_resolution() {
+ use crate::ser::Serializer;
+ use serde::Serialize;
+
+ let schema = Schema::parse_str(
+ r#"{
+ "type": "record",
+ "name": "NamespacedMessage",
+ "namespace": "com.domain",
+ "fields": [
+ {
+ "type": "record",
+ "name": "field_a",
+ "fields": [
+ {
+ "name": "enum_a",
+ "type": {
+ "type": "enum",
+ "name": "EnumType",
+ "symbols": [
+ "SYMBOL_1",
+ "SYMBOL_2"
+ ],
+ "default": "SYMBOL_1"
+ }
+ },
+ {
+ "name": "enum_b",
+ "type": "EnumType"
+ }
+ ]
+ }
+ ]
+ }"#,
+ )
+ .unwrap();
+
+ #[derive(Serialize)]
+ enum EnumType {
+ #[serde(rename = "SYMBOL_1")]
+ Symbol1,
+ #[serde(rename = "SYMBOL_2")]
+ Symbol2,
+ }
+
+ #[derive(Serialize)]
+ struct FieldA {
+ enum_a: EnumType,
+ enum_b: EnumType,
+ }
+
+ #[derive(Serialize)]
+ struct NamespacedMessage {
+ field_a: FieldA,
+ }
+
+ let msg = NamespacedMessage {
+ field_a: FieldA {
+ enum_a: EnumType::Symbol2,
+ enum_b: EnumType::Symbol1,
+ },
+ };
+
+ let mut ser = Serializer::default();
+ let test_value: Value = msg.serialize(&mut ser).unwrap();
+ assert!(test_value.validate(&schema), "test_value should validate");
+ // TODO (rikheijdens): I believe this should also resolve?
+ //assert!(test_value.resolve(&schema).is_ok(), "test_value should resolve");
Review Comment:
@martin-g Note my attempt at a fix in https://github.com/apache/avro/pull/1968/commits/f2d778d8469b337b14ceee9066016da842d39aaa does not allow the schema to resolve where as this is the case in the test below which does not use a namespace, therefore I believe this may require more work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g closed pull request #1968: AVRO-3674: Namespaced schema lookup failures
Posted by GitBox <gi...@apache.org>.
martin-g closed pull request #1968: AVRO-3674: Namespaced schema lookup failures
URL: https://github.com/apache/avro/pull/1968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1968: AVRO-3674: Namespaced schema lookup failures
Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #1968:
URL: https://github.com/apache/avro/pull/1968#issuecomment-1319873485
I am unable to push to your branch, so I will create a new PR.
Your commits will be preserved!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1968: AVRO-3674: Namespaced schema lookup failures
Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #1968:
URL: https://github.com/apache/avro/pull/1968#issuecomment-1319926779
Closing in favour of https://github.com/apache/avro/pull/1971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org