You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by GitBox <gi...@apache.org> on 2020/04/29 15:44:19 UTC
[GitHub] [ignite-website] dmagda commented on a change in pull request #10: Seo updates April 28
dmagda commented on a change in pull request #10:
URL: https://github.com/apache/ignite-website/pull/10#discussion_r417416842
##########
File path: index.html
##########
@@ -273,9 +278,9 @@ <h3>Applications Acceleration & Data Caching</h3>
using Ignite as an in-memory data grid.
</p>
- <a href="/use-cases/in-memory-data-grid.html" class="btn btn-primary" title="In-Memory Data Grid"
+ <a href="/use-cases/in-memory-data-grid.html" role="button" class="btn btn-primary" title="In-Memory Data Grid"
onclick="ga('send', 'event', 'apache_ignite_use_cases', 'homepage_click', 'data_grid');">
- Learn More</a>
+ Learn More About In-Memory Data Grid</a>
Review comment:
Please revert this change, that's too much for the button title. I believe we can sacrifice this SEO optimization in favor of better readability. Data Grid keyword is already mentioned three times on the front page.
##########
File path: index.html
##########
@@ -304,9 +309,9 @@ <h3>Digital Integration Hub</h3>
through Apache Ignite’s functionally rich, unified and consistent APIs.
</p>
- <a href="/use-cases/digital-integration-hub.html" class="btn btn-primary" title="Digital Integration Hub"
+ <a href="/use-cases/digital-integration-hub.html" role="button" class="btn btn-primary" aria-label="Learn More About Digital Integration Hub" title="Digital Integration Hub"
onclick="ga('send', 'event', 'apache_ignite_use_cases', 'homepage_click', 'digital_hub');">
- Learn More</a>
+ Learn More About Digital Integration Hub</a>
Review comment:
Please revert this change, that's too much for the button title. I believe we can sacrifice this SEO optimization in favor of better readability. Digital Hub keyword is already mentioned a couple of times on this page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org