[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #3075: Fixing failures on RamDisk due to Java API Files.getFileStore()

[GitBox <gi...@apache.org>]

michaelandrepearce commented on a change in pull request #3075: Fixing failures on RamDisk due to Java API Files.getFileStore() 
URL: https://github.com/apache/activemq-artemis/pull/3075#discussion_r406681828
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/files/FileStoreMonitor.java
 ##########
 @@ -73,8 +75,8 @@ public FileStoreMonitor addStore(File file) throws IOException {
             try {
                addStore(Files.getFileStore(file.toPath()));
             } catch (IOException e) {
-               logger.error("Error getting file store for " + file.getAbsolutePath(), e);
-               throw e;
+               logger.warn("Error getting file store for " + file.getAbsolutePath() + ". Trying dummy FileStore", e);
 
 Review comment:
   This will mean now real filesystems where we need to trust the store has been successful will silently fail. E.g. if permission or actual io issue with disk

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services