[GitHub] [cassandra] belliottsmith commented on a change in pull request #1045: CASSANDRA-16663 Request-Based Native Transport Rate-Limiting

[GitBox <gi...@apache.org>]

belliottsmith commented on a change in pull request #1045:
URL: https://github.com/apache/cassandra/pull/1045#discussion_r685910832



##########
File path: src/java/org/apache/cassandra/transport/PreV5Handlers.java
##########
@@ -107,20 +110,16 @@ private void releaseItem(Flusher.FlushItem<Message.Response> item)
             // The only exception to this is if the global request rate limit has been breached, which means
             // we'll have to wait until a scheduled wakeup task unpauses the connection.
             //
-            // note: this path is only relevant when part of a pre-V5 pipeline, as only in this case is
+            // Note: This path is only relevant when part of a pre-V5 pipeline, as only in this case is
             // paused ever set to true. In pipelines configured for V5 or later, backpressure and control
             // over the inbound pipeline's autoread status are handled by the FrameDecoder/FrameProcessor.
             ChannelConfig config = item.channel.config();
 
-            if (!config.isAutoRead())
+            if (!config.isAutoRead()

Review comment:
       could presumably just check `pauseTrigger` in this case? We should maintain that `pauseTrigger != NONE` => `!config.isAutoRead()`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org