You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2020/04/04 13:48:45 UTC
[GitHub] [myfaces] astappiev opened a new pull request #92: Add Ukrainian
translation for Faces Messages
astappiev opened a new pull request #92: Add Ukrainian translation for Faces Messages
URL: https://github.com/apache/myfaces/pull/92
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] tandraschko commented on issue #92: Add Ukrainian
translation for Faces Messages
Posted by GitBox <gi...@apache.org>.
tandraschko commented on issue #92: Add Ukrainian translation for Faces Messages
URL: https://github.com/apache/myfaces/pull/92#issuecomment-609065956
Same here, please add a JIRA first
and also please create PRs for at least 2.3.x, 3.0.x and master branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] tandraschko commented on issue #92: Add Ukrainian
translation for Faces Messages
Posted by GitBox <gi...@apache.org>.
tandraschko commented on issue #92: Add Ukrainian translation for Faces Messages
URL: https://github.com/apache/myfaces/pull/92#issuecomment-612529087
src/test can just be ignored, it's really only for the unittests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] astappiev commented on issue #92: Add Ukrainian
translation for Faces Messages
Posted by GitBox <gi...@apache.org>.
astappiev commented on issue #92: Add Ukrainian translation for Faces Messages
URL: https://github.com/apache/myfaces/pull/92#issuecomment-615800593
Where does `org.apache.myfaces.renderkit.html.HtmlMessagesRenderer.IN_FIELD` message used? There is only one word and it is untranslated in many languages, should I keep it as is?
```
org.apache.myfaces.renderkit.html.HtmlMessagesRenderer.IN_FIELD = \u0020in {0}
```
* `\u0020` is a space character
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] astappiev commented on issue #92: Add Ukrainian
translation for Faces Messages
Posted by GitBox <gi...@apache.org>.
astappiev commented on issue #92: Add Ukrainian translation for Faces Messages
URL: https://github.com/apache/myfaces/pull/92#issuecomment-612482750
I found a few more messages bundles:
- shared\src\test\resources\javax\faces\Messages.properties
- shared-public\src\test\resources\javax\faces\Messages.properties
- api\src\main\javascript\META-INF\resources\myfaces\_impl\i18n\Messages.js
Does it make sense to translate any of them? In particular, the first two are in the `test` folder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] astappiev edited a comment on issue #92: Add Ukrainian
translation for Faces Messages
Posted by GitBox <gi...@apache.org>.
astappiev edited a comment on issue #92: Add Ukrainian translation for Faces Messages
URL: https://github.com/apache/myfaces/pull/92#issuecomment-615787268
What to do with Portuguese and Brazilian Portuguese?
We do not separate these languages, and therefore we renamed `Messages_pt_BR.properties` to `Messages_pt.properties` and updated the last one.
In this repository, I created a new file, but does it makes sense to keep two files identical (right now Messages_pt.properties is slightly better, but as we didn't change any sentences it can be backported)? Should I rename `Messages_pt_BR.properties` to `Messages_pt.properties` in the PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] tandraschko commented on issue #92: Add Ukrainian
translation for Faces Messages
Posted by GitBox <gi...@apache.org>.
tandraschko commented on issue #92: Add Ukrainian translation for Faces Messages
URL: https://github.com/apache/myfaces/pull/92#issuecomment-615815235
about pt pt_BR:
i think we should leave it as it is in older branches and rename it in master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] astappiev commented on issue #92: Add Ukrainian
translation for Faces Messages
Posted by GitBox <gi...@apache.org>.
astappiev commented on issue #92: Add Ukrainian translation for Faces Messages
URL: https://github.com/apache/myfaces/pull/92#issuecomment-615794842
https://issues.apache.org/jira/browse/MYFACES-4331
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] werpu commented on issue #92: Add Ukrainian translation
for Faces Messages
Posted by GitBox <gi...@apache.org>.
werpu commented on issue #92: Add Ukrainian translation for Faces Messages
URL: https://github.com/apache/myfaces/pull/92#issuecomment-612483889
Hi I only can speak for the messages.js, no need to translate those, we will drop the multi language support in the next gen of the jsf.js, from then onwards only english messages will be shown coming out of the framework (not that the end user ever sees those). But that is just the javascript part, cannot comment on the rest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] tandraschko commented on issue #92: Add Ukrainian
translation for Faces Messages
Posted by GitBox <gi...@apache.org>.
tandraschko commented on issue #92: Add Ukrainian translation for Faces Messages
URL: https://github.com/apache/myfaces/pull/92#issuecomment-615674051
Yep of course
I really wonder why we have wrong encoding and nobody mentioned it over the years
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] tandraschko commented on issue #92: Add Ukrainian
translation for Faces Messages
Posted by GitBox <gi...@apache.org>.
tandraschko commented on issue #92: Add Ukrainian translation for Faces Messages
URL: https://github.com/apache/myfaces/pull/92#issuecomment-615814447
i think it's unused
we should remove it in master at least
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] tandraschko commented on issue #92: Add Ukrainian
translation for Faces Messages
Posted by GitBox <gi...@apache.org>.
tandraschko commented on issue #92: Add Ukrainian translation for Faces Messages
URL: https://github.com/apache/myfaces/pull/92#issuecomment-615396124
any news? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] astappiev commented on issue #92: Add Ukrainian
translation for Faces Messages
Posted by GitBox <gi...@apache.org>.
astappiev commented on issue #92: Add Ukrainian translation for Faces Messages
URL: https://github.com/apache/myfaces/pull/92#issuecomment-615787268
What to do with Portuguese and Brazilian Portuguese?
We have a single language for both, and therefore we renamed `Messages_pt_BR.properties` to `Messages_pt.properties` and updated the last one.
In this repository, I created a new file, but does it makes sense to keep two files identical (right now Messages_pt.properties is slightly better, but as we didn't change any sentences it can be backported)? Should I rename `Messages_pt_BR.properties` to `Messages_pt.properties` in the PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] astappiev edited a comment on issue #92: Add Ukrainian
translation for Faces Messages
Posted by GitBox <gi...@apache.org>.
astappiev edited a comment on issue #92: Add Ukrainian translation for Faces Messages
URL: https://github.com/apache/myfaces/pull/92#issuecomment-615787268
What to do with Portuguese and Brazilian Portuguese?
We do not separate these languages, and therefore we renamed `Messages_pt_BR.properties` to `Messages_pt.properties` and updated the last one.
In this repository, I created a new file, but does it makes sense to keep two files identical (right now Messages_pt.properties is slightly better, but as we didn't change any sentences it can be backported)? Should I rename `Messages_pt_BR.properties` to `Messages_pt.properties` in the PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] astappiev commented on issue #92: Add Ukrainian
translation for Faces Messages
Posted by GitBox <gi...@apache.org>.
astappiev commented on issue #92: Add Ukrainian translation for Faces Messages
URL: https://github.com/apache/myfaces/pull/92#issuecomment-615891611
Created additional merge requests for `master` and `3.0.x` branches.
- In master, I renamed `pt_BR` to `pt`. In other branches added additionally.
- I didn't remove any fields anywhere
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] tandraschko merged pull request #92: Add Ukrainian
translation for Faces Messages
Posted by GitBox <gi...@apache.org>.
tandraschko merged pull request #92: Add Ukrainian translation for Faces Messages
URL: https://github.com/apache/myfaces/pull/92
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] tandraschko edited a comment on issue #92: Add Ukrainian
translation for Faces Messages
Posted by GitBox <gi...@apache.org>.
tandraschko edited a comment on issue #92: Add Ukrainian translation for Faces Messages
URL: https://github.com/apache/myfaces/pull/92#issuecomment-615814447
i think it's unused (IN_FIELD)
we should remove it in master at least
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] astappiev commented on issue #92: Add Ukrainian
translation for Faces Messages
Posted by GitBox <gi...@apache.org>.
astappiev commented on issue #92: Add Ukrainian translation for Faces Messages
URL: https://github.com/apache/myfaces/pull/92#issuecomment-615469976
Hi,
I added all other messages files that we updated (used in our project);
- `Messages.properties`: removed few trailing spaces
- `Messages_en.properties`: same as above
- `Messages_de.properties`: fixed character encodings, spaces
- `Messages_es.properties`: encodings, updated order (to compare with base more easily), added missing variables (like `{2}: ` prefixes)
- `Messages_it.properties`: like above
- `Messages_pt.properties`: copied from `Messages_pt_BR.properties`, updated like above
Will it be useful to merge? If not, I will revert and only finish Ukrainian translation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services