You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Phillips <no...@github.com> on 2015/04/07 05:02:29 UTC

[jclouds] Using a custom ConnectorFactory for ssh-agent that only tries netcat (#721)

See http://markmail.org/thread/oto47qk2kzcdtebb
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/721

-- Commit Summary --

  * Using a custom ConnectorFactory for ssh-agent that only tries netcat

-- File Changes --

    M drivers/sshj/src/main/java/org/jclouds/sshj/config/SshjSshClientModule.java (9)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/721.patch
https://github.com/jclouds/jclouds/pull/721.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/721

Re: [jclouds] Using a custom ConnectorFactory for ssh-agent that only tries netcat (#721)

Posted by Ignasi Barrera <no...@github.com>.
Yes! :) Thanks for taking care of this!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/721#issuecomment-91121070

Re: [jclouds] Using a custom ConnectorFactory for ssh-agent that only tries netcat (#721)

Posted by Andrew Phillips <no...@github.com>.
> All is well — Merged build finished.

Phew ;-)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/721#issuecomment-90597950

Re: [jclouds] Using a custom ConnectorFactory for ssh-agent that only tries netcat (#721)

Posted by Andrew Phillips <no...@github.com>.
@nacx: Just to be sure...is this OK for you?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/721#issuecomment-91096783

Re: [jclouds] Using a custom ConnectorFactory for ssh-agent that only tries netcat (#721)

Posted by Ignasi Barrera <no...@github.com>.
I assume the same fix has to be applied to the [jsch driver](https://github.com/jclouds/jclouds/blob/master/drivers/jsch/src/main/java/org/jclouds/ssh/jsch/config/JschSshClientModule.java#L55-L61)?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/721#issuecomment-90576089

Re: [jclouds] Using a custom ConnectorFactory for ssh-agent that only tries netcat (#721)

Posted by Andrew Phillips <no...@github.com>.
Backported to [1.9.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=0e2ee14)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/721#issuecomment-91247353

Re: [jclouds] Using a custom ConnectorFactory for ssh-agent that only tries netcat (#721)

Posted by Andrew Phillips <no...@github.com>.
> I assume the same fix has to be applied to the jsch driver?

Not yet...testing this one first. Good point! ;-)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/721#issuecomment-90577830

Re: [jclouds] Using a custom ConnectorFactory for ssh-agent that only tries netcat (#721)

Posted by Andrew Phillips <no...@github.com>.
Comment from @nacx: "I've built your branch and I've been able to list nodes without issues (in OSX)." Now to find out what the build problem is...

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/721#issuecomment-90569677

Re: [jclouds] Using a custom ConnectorFactory for ssh-agent that only tries netcat (#721)

Posted by Ignasi Barrera <no...@github.com>.
Yep, I'd backport it too. Thanks @demobox!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/721#issuecomment-91241591

Re: [jclouds] Using a custom ConnectorFactory for ssh-agent that only tries netcat (#721)

Posted by Andrew Phillips <no...@github.com>.
Closed #721.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/721#event-275270624

Re: [jclouds] Using a custom ConnectorFactory for ssh-agent that only tries netcat (#721)

Posted by Andrew Phillips <no...@github.com>.
Closed #721.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/721#event-277196258

Re: [jclouds] Using a custom ConnectorFactory for ssh-agent that only tries netcat (#721)

Posted by Andrew Phillips <no...@github.com>.
Looks like a Jenkins issue - let's try this again...

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/721#issuecomment-90574235

Re: [jclouds] Using a custom ConnectorFactory for ssh-agent that only tries netcat (#721)

Posted by Andrew Phillips <no...@github.com>.
> Failed — Merged build finished.

Another Jenkins error, by the looks of things? Just cleared the workspace.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/721#issuecomment-90579956

Re: [jclouds] Using a custom ConnectorFactory for ssh-agent that only tries netcat (#721)

Posted by Andrew Phillips <no...@github.com>.
Merged to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=search;s=Andrew+Phillips;st=author).

@nacx: Also backport to 1.9.x?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/721#issuecomment-91238084