Re: [PR] chore: Clarify rehash setting in hash utils [datafusion]

["Jefffrey (via GitHub)" <gi...@apache.org>]

Jefffrey commented on PR #20154:
URL: https://github.com/apache/datafusion/pull/20154#issuecomment-4293383811

   I do think it would be a good idea to split the naming/doc fixes and nested type hash fixes into separate PRs.
   
   > Also, for the inconsistencies, can you describe what is "fixed" by resolving them. Is there a potential wrong results bug? Something else? If it is wrong results, I wonder why we haven't seen it before
   
   I think this was the main question I had in the original issue, in that I didn't understand if it was intentional to omit rehash for nested types or not. From what I've seen rehash seems to be a performance optimization, so "fixing" for nested types would need some benchmarks to see performance impacts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org