[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #5550: Spark - Add missing override in Spark 3.1 JMH

[GitBox <gi...@apache.org>]

aokolnychyi commented on code in PR #5550:
URL: https://github.com/apache/iceberg/pull/5550#discussion_r947236355


##########
spark/v3.1/spark/src/jmh/java/org/apache/iceberg/spark/source/WritersBenchmark.java:
##########
@@ -79,6 +79,7 @@ public abstract class WritersBenchmark extends IcebergSourceBenchmark {
   private PartitionSpec unpartitionedSpec;
   private PartitionSpec partitionedSpec;
 
+  @Override
   protected abstract FileFormat fileFormat();

Review Comment:
   What about just removing this method? We already have one in the parent class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org