You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/08/25 16:48:01 UTC

Review Request 37760: LENS-755: rename LogicalTableCrudCommand to ConceptualTableCrudCommand and PhysicalTableCrudCommand to LogicalTableCrudCommand

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37760/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-755
    https://issues.apache.org/jira/browse/LENS-755


Repository: lens


Description
-------

in accordance with http://lens.apache.org/user/olap-cube.html#Conceptual_Tables


Diffs
-----

  lens-cli/src/main/java/org/apache/lens/cli/commands/ConceptualTableCrudCommand.java PRE-CREATION 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java cfee32fe09b5cef3f23aa739f32e50c86c4d9ee8 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java 1f70337303a9f5710a1bb5b0312e21d1f9af5860 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 1759d9c9683c01baef3168460e3c626f805fbeb7 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java e2f1c50f3a4aa192b54edc6b7d34d8565140a971 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LogicalTableCrudCommand.java 3c78e436c245bed2644e97bd0b3269e332cc9240 
  lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java a1ccec682330d48f116e06a085d07db179888327 

Diff: https://reviews.apache.org/r/37760/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 37760: LENS-755: rename LogicalTableCrudCommand to ConceptualTableCrudCommand and PhysicalTableCrudCommand to LogicalTableCrudCommand

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37760/
-----------------------------------------------------------

(Updated Aug. 27, 2015, 5:43 p.m.)


Review request for lens.


Bugs: LENS-755
    https://issues.apache.org/jira/browse/LENS-755


Repository: lens


Description
-------

in accordance with http://lens.apache.org/user/olap-cube.html#Conceptual_Tables


Diffs (updated)
-----

  lens-cli/src/main/java/org/apache/lens/cli/commands/ConceptualTableCrudCommand.java PRE-CREATION 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java cfee32fe09b5cef3f23aa739f32e50c86c4d9ee8 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java 1f70337303a9f5710a1bb5b0312e21d1f9af5860 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 1759d9c9683c01baef3168460e3c626f805fbeb7 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java e2f1c50f3a4aa192b54edc6b7d34d8565140a971 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LogicalTableCrudCommand.java 3c78e436c245bed2644e97bd0b3269e332cc9240 
  lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java a1ccec682330d48f116e06a085d07db179888327 

Diff: https://reviews.apache.org/r/37760/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 37760: LENS-755: rename LogicalTableCrudCommand to ConceptualTableCrudCommand and PhysicalTableCrudCommand to LogicalTableCrudCommand

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37760/#review96490
-----------------------------------------------------------

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Aug. 25, 2015, 2:48 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37760/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2015, 2:48 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-755
>     https://issues.apache.org/jira/browse/LENS-755
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> in accordance with http://lens.apache.org/user/olap-cube.html#Conceptual_Tables
> 
> 
> Diffs
> -----
> 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/ConceptualTableCrudCommand.java PRE-CREATION 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java cfee32fe09b5cef3f23aa739f32e50c86c4d9ee8 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java 1f70337303a9f5710a1bb5b0312e21d1f9af5860 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 1759d9c9683c01baef3168460e3c626f805fbeb7 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java e2f1c50f3a4aa192b54edc6b7d34d8565140a971 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LogicalTableCrudCommand.java 3c78e436c245bed2644e97bd0b3269e332cc9240 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java a1ccec682330d48f116e06a085d07db179888327 
> 
> Diff: https://reviews.apache.org/r/37760/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>