You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2023/09/09 02:58:59 UTC
[GitHub] [spark] beliefer opened a new pull request, #42861: [SPARK-45108][SQL] Improve the InjectRuntimeFilter for check probably shuffle
beliefer opened a new pull request, #42861:
URL: https://github.com/apache/spark/pull/42861
### What changes were proposed in this pull request?
`InjectRuntimeFilter` needs to check probably shuffle. But the current code may lead to duplicate call of `isProbablyShuffleJoin` if we need the right side of `Join` node as the application side.
### Why are the changes needed?
To avoid the duplicate call of `isProbablyShuffleJoin`.
### Does this PR introduce _any_ user-facing change?
'No'.
Just update the inner implementation.
### How was this patch tested?
Exists test cases.
### Was this patch authored or co-authored using generative AI tooling?
'No'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #42861: [SPARK-45108][SQL] Improve the InjectRuntimeFilter for check probably shuffle
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #42861:
URL: https://github.com/apache/spark/pull/42861#issuecomment-1720864374
ping @cloud-fan @viirya cc @somani
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #42861: [SPARK-45108][SQL] Improve the InjectRuntimeFilter for check probably shuffle
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #42861:
URL: https://github.com/apache/spark/pull/42861#issuecomment-1713222669
In fact, the GA passed.
https://github.com/beliefer/spark/actions/runs/6129346872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #42861: [SPARK-45108][SQL] Improve the InjectRuntimeFilter for check probably shuffle
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #42861:
URL: https://github.com/apache/spark/pull/42861#issuecomment-1729409286
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #42861: [SPARK-45108][SQL] Improve the InjectRuntimeFilter for check probably shuffle
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #42861:
URL: https://github.com/apache/spark/pull/42861#issuecomment-1713321511
ping @viirya @wangyum cc @somani
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #42861: [SPARK-45108][SQL] Improve the InjectRuntimeFilter for check probably shuffle
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #42861:
URL: https://github.com/apache/spark/pull/42861#issuecomment-1730628240
@cloud-fan Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #42861: [SPARK-45108][SQL] Improve the InjectRuntimeFilter for check probably shuffle
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #42861: [SPARK-45108][SQL] Improve the InjectRuntimeFilter for check probably shuffle
URL: https://github.com/apache/spark/pull/42861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org