You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/10/25 16:04:23 UTC

[GitHub] [cloudstack] SadiJr opened a new pull request #5625: [UI] Change permission to access console proxy button

SadiJr opened a new pull request #5625:
URL: https://github.com/apache/cloudstack/pull/5625


   ### Description
   
   This PR fixes #5623
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [x] Trivial
   
   ### How Has This Been Tested?
   Its tested in a local lab, trying to reproduce the steps of the *issue* #5623.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5625: [UI] Change permission to access console proxy button

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5625:
URL: https://github.com/apache/cloudstack/pull/5625#issuecomment-956051035


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5625 (SL-JID-798)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] sureshanaparti commented on pull request #5625: [UI] Change permission to access console proxy button

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5625:
URL: https://github.com/apache/cloudstack/pull/5625#issuecomment-995833301


   Hi @SadiJr Is this PR good to go in 4.16.1 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] sureshanaparti commented on pull request #5625: [UI] Change permission to access console proxy button

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5625:
URL: https://github.com/apache/cloudstack/pull/5625#issuecomment-995984082


   > @sureshanaparti I guess yes, but for me, it is fine to go into main only.
   
   ok, thanks for confirming @SadiJr 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] SadiJr commented on pull request #5625: [UI] Change permission to access console proxy button

Posted by GitBox <gi...@apache.org>.
SadiJr commented on pull request #5625:
URL: https://github.com/apache/cloudstack/pull/5625#issuecomment-995979159


   @sureshanaparti I guess yes, but for me, it is fine to go into main only.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rohityadavcloud merged pull request #5625: [UI] Change permission to access console proxy button

Posted by GitBox <gi...@apache.org>.
rohityadavcloud merged pull request #5625:
URL: https://github.com/apache/cloudstack/pull/5625


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5625: [UI] Change permission to access console proxy button

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5625:
URL: https://github.com/apache/cloudstack/pull/5625#issuecomment-956048507


   @utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] utchoang commented on pull request #5625: [UI] Change permission to access console proxy button

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5625:
URL: https://github.com/apache/cloudstack/pull/5625#issuecomment-956047124


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org