You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "EnricoMi (via GitHub)" <gi...@apache.org> on 2024/03/26 18:56:48 UTC
[PR] [SPARK-47573][K8S] Support custom driver log url [spark]
EnricoMi opened a new pull request, #45728:
URL: https://github.com/apache/spark/pull/45728
### What changes were proposed in this pull request?
Add config `spark.ui.custom.driver.log.url` to Kubernetes resource manager allow setting log url templates similar to `spark.ui.custom.executor.log.url` (#45464).
Allows for
--conf spark.ui.custom.driver.log.url="https://my-custom.url/api/logs?applicationId={{APP_ID}}
Supports these variables:
APP_ID: The unique application id
KUBERNETES_NAMESPACE: The namespace where the executor pods run
KUBERNETES_POD_NAME: The name of the pod that contains the executor
FILE_NAME: The name of the log, which is always "log"
Adds driver pod environment variable `SPARK_DRIVER_POD_NAME`.
### Why are the changes needed?
Running Spark on Kubernetes requires persisting the logs elsewhere. Having the Spark UI link to those logs is very useful. This should be possible for driver logs similar to executor logs.
### Does this PR introduce _any_ user-facing change?
Spark UI provides links to logs when run on Kubernetes.
### How was this patch tested?
Unit test and manually tested on minikube K8S cluster.
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47573][K8S] Support custom driver log url [spark]
Posted by "EnricoMi (via GitHub)" <gi...@apache.org>.
EnricoMi commented on PR #45728:
URL: https://github.com/apache/spark/pull/45728#issuecomment-2067722179
@dongjoon-hyun What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47573][K8S] Support custom driver log url [spark]
Posted by "EnricoMi (via GitHub)" <gi...@apache.org>.
EnricoMi commented on PR #45728:
URL: https://github.com/apache/spark/pull/45728#issuecomment-2021253513
CC @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org