You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by sj...@apache.org on 2025/10/25 12:56:12 UTC

(maven-war-plugin) branch master updated: Remove unused parameter - useJvmChmod

This is an automated email from the ASF dual-hosted git repository.

sjaranowski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-war-plugin.git


The following commit(s) were added to refs/heads/master by this push:
     new 0562ffe  Remove unused parameter - useJvmChmod
0562ffe is described below

commit 0562ffed4d569249e0ea0a6e3148e82e83ca9674
Author: Slawomir Jaranowski <s....@gmail.com>
AuthorDate: Sat Oct 25 12:49:03 2025 +0200

    Remove unused parameter - useJvmChmod
---
 .../org/apache/maven/plugins/war/AbstractWarMojo.java | 19 -------------------
 .../plugins/war/packaging/WarPackagingContext.java    |  6 ------
 .../apache/maven/plugins/war/AbstractWarMojoTest.java |  1 -
 3 files changed, 26 deletions(-)

diff --git a/src/main/java/org/apache/maven/plugins/war/AbstractWarMojo.java b/src/main/java/org/apache/maven/plugins/war/AbstractWarMojo.java
index 5c14fd7..f76abed 100644
--- a/src/main/java/org/apache/maven/plugins/war/AbstractWarMojo.java
+++ b/src/main/java/org/apache/maven/plugins/war/AbstractWarMojo.java
@@ -332,14 +332,6 @@ public abstract class AbstractWarMojo extends AbstractMojo {
     @Parameter(defaultValue = "false")
     private boolean supportMultiLineFiltering;
 
-    /**
-     * Use jvmChmod rather that cli chmod and forking process.
-     *
-     * @since 2.4
-     */
-    @Parameter(defaultValue = "true")
-    private boolean useJvmChmod;
-
     /**
      * The archive configuration to use. See <a href="http://maven.apache.org/shared/maven-archiver/index.html">Maven
      * Archiver Reference</a>.
@@ -534,7 +526,6 @@ public abstract class AbstractWarMojo extends AbstractMojo {
                 this.artifactFactory,
                 resourceEncoding,
                 propertiesEncoding,
-                useJvmChmod,
                 failOnMissingWebXml,
                 outputTimestamp);
 
@@ -594,8 +585,6 @@ public abstract class AbstractWarMojo extends AbstractMojo {
 
         private boolean filteringDeploymentDescriptors;
 
-        private boolean useJvmChmod;
-
         private final Boolean failOnMissingWebXml;
 
         private final Collection<String> outdatedResources;
@@ -612,7 +601,6 @@ public abstract class AbstractWarMojo extends AbstractMojo {
          * @param artifactFactory the artifact factory
          * @param resourceEncoding the resource encoding
          * @param propertiesEncoding the encoding to use for properties files
-         * @param useJvmChmod use Jvm chmod or not
          * @param failOnMissingWebXml flag to check whether we should ignore missing web.xml or not
          * @param outputTimestamp the output timestamp for reproducible archive creation
          */
@@ -627,7 +615,6 @@ public abstract class AbstractWarMojo extends AbstractMojo {
                 ArtifactFactory artifactFactory,
                 String resourceEncoding,
                 String propertiesEncoding,
-                boolean useJvmChmod,
                 final Boolean failOnMissingWebXml,
                 String outputTimestamp) {
             this.webappDirectory = webappDirectory;
@@ -645,7 +632,6 @@ public abstract class AbstractWarMojo extends AbstractMojo {
             for (String overlayId : overlayManager.getOverlayIds()) {
                 webappStructure.getStructure(overlayId);
             }
-            this.useJvmChmod = useJvmChmod;
             this.failOnMissingWebXml = failOnMissingWebXml;
 
             if (!webappDirectory.exists()) {
@@ -817,11 +803,6 @@ public abstract class AbstractWarMojo extends AbstractMojo {
             return propertiesEncoding;
         }
 
-        @Override
-        public boolean isUseJvmChmod() {
-            return useJvmChmod;
-        }
-
         @Override
         public Boolean isFailOnMissingWebXml() {
             return failOnMissingWebXml;
diff --git a/src/main/java/org/apache/maven/plugins/war/packaging/WarPackagingContext.java b/src/main/java/org/apache/maven/plugins/war/packaging/WarPackagingContext.java
index 09deea3..781444b 100644
--- a/src/main/java/org/apache/maven/plugins/war/packaging/WarPackagingContext.java
+++ b/src/main/java/org/apache/maven/plugins/war/packaging/WarPackagingContext.java
@@ -214,12 +214,6 @@ public interface WarPackagingContext {
      */
     String getPropertiesEncoding();
 
-    /**
-     * @return to use jvmChmod rather than forking chmod cli
-     * @since 2.4
-     */
-    boolean isUseJvmChmod();
-
     /**
      * Returns the flag that switch on/off the missing web.xml validation.
      *
diff --git a/src/test/java/org/apache/maven/plugins/war/AbstractWarMojoTest.java b/src/test/java/org/apache/maven/plugins/war/AbstractWarMojoTest.java
index cbbdf57..21135b4 100644
--- a/src/test/java/org/apache/maven/plugins/war/AbstractWarMojoTest.java
+++ b/src/test/java/org/apache/maven/plugins/war/AbstractWarMojoTest.java
@@ -68,7 +68,6 @@ public abstract class AbstractWarMojoTest extends AbstractMojoTestCase {
             throws Exception {
         setVariableValueToObject(mojo, "filters", filters);
         setVariableValueToObject(mojo, "mavenFileFilter", lookup(MavenFileFilter.class.getName()));
-        setVariableValueToObject(mojo, "useJvmChmod", Boolean.TRUE);
 
         MavenExecutionRequest request = new DefaultMavenExecutionRequest()
                 .setSystemProperties(System.getProperties())