You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Brandon Li (JIRA)" <ji...@apache.org> on 2012/09/16 17:47:07 UTC
[jira] [Created] (HADOOP-8818) Should use equals() rather than ==
to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
Brandon Li created HADOOP-8818:
----------------------------------
Summary: Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
Key: HADOOP-8818
URL: https://issues.apache.org/jira/browse/HADOOP-8818
Project: Hadoop Common
Issue Type: Bug
Components: fs, io
Reporter: Brandon Li
Assignee: Brandon Li
Priority: Minor
Attachments: HADOOP-8818.patch
Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8818) Should use equals() rather than ==
to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456690#comment-13456690 ]
Hudson commented on HADOOP-8818:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2758 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2758/])
HADOOP-8818. Use equals instead == in MD5MD5CRC32FileChecksum and TFileDumper. Contributed by Brandon Li. (Revision 1385374)
Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1385374
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/MD5MD5CRC32FileChecksum.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFileDumper.java
> Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8818
> URL: https://issues.apache.org/jira/browse/HADOOP-8818
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs, io
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HADOOP-8818.patch
>
>
> Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (HADOOP-8818) Should use equals() rather
than == to compare String or Text in MD5MD5CRC32FileChecksum and
TFileDumper
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456668#comment-13456668 ]
Suresh Srinivas edited comment on HADOOP-8818 at 9/17/12 8:08 AM:
------------------------------------------------------------------
+1 for the patch. Created HADOOP-8821 to track the findbugs issue.
was (Author: sureshms):
+1 for the patch. Create HADOOP-8821 to track the findbugs issue.
> Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8818
> URL: https://issues.apache.org/jira/browse/HADOOP-8818
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs, io
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8818.patch
>
>
> Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8818) Should use equals() rather than ==
to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456980#comment-13456980 ]
Hudson commented on HADOOP-8818:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1168 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1168/])
HADOOP-8818. Use equals instead == in MD5MD5CRC32FileChecksum and TFileDumper. Contributed by Brandon Li. (Revision 1385374)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1385374
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/MD5MD5CRC32FileChecksum.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFileDumper.java
> Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8818
> URL: https://issues.apache.org/jira/browse/HADOOP-8818
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs, io
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HADOOP-8818.patch
>
>
> Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8818) Should use equals() rather than ==
to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456668#comment-13456668 ]
Suresh Srinivas commented on HADOOP-8818:
-----------------------------------------
+1 for the patch. Create HADOOP-8821 to track the findbugs issue.
> Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8818
> URL: https://issues.apache.org/jira/browse/HADOOP-8818
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs, io
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8818.patch
>
>
> Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8818) Should use equals() rather than ==
to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456676#comment-13456676 ]
Hudson commented on HADOOP-8818:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2797 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2797/])
HADOOP-8818. Use equals instead == in MD5MD5CRC32FileChecksum and TFileDumper. Contributed by Brandon Li. (Revision 1385374)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1385374
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/MD5MD5CRC32FileChecksum.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFileDumper.java
> Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8818
> URL: https://issues.apache.org/jira/browse/HADOOP-8818
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs, io
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HADOOP-8818.patch
>
>
> Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8818) Should use equals() rather than ==
to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
Posted by "Brandon Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Li updated HADOOP-8818:
-------------------------------
Status: Patch Available (was: Open)
> Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8818
> URL: https://issues.apache.org/jira/browse/HADOOP-8818
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs, io
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8818.patch
>
>
> Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8818) Should use equals() rather than ==
to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
Posted by "Brandon Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Li updated HADOOP-8818:
-------------------------------
Affects Version/s: 3.0.0
> Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8818
> URL: https://issues.apache.org/jira/browse/HADOOP-8818
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs, io
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8818.patch
>
>
> Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8818) Should use equals() rather than ==
to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456597#comment-13456597 ]
Hadoop QA commented on HADOOP-8818:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12545319/HADOOP-8818.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1474//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/1474//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1474//console
This message is automatically generated.
> Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8818
> URL: https://issues.apache.org/jira/browse/HADOOP-8818
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs, io
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8818.patch
>
>
> Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8818) Should use equals() rather than ==
to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457030#comment-13457030 ]
Hudson commented on HADOOP-8818:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1199 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1199/])
HADOOP-8818. Use equals instead == in MD5MD5CRC32FileChecksum and TFileDumper. Contributed by Brandon Li. (Revision 1385374)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1385374
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/MD5MD5CRC32FileChecksum.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFileDumper.java
> Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8818
> URL: https://issues.apache.org/jira/browse/HADOOP-8818
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs, io
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HADOOP-8818.patch
>
>
> Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8818) Should use equals() rather than ==
to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
Posted by "Brandon Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Li updated HADOOP-8818:
-------------------------------
Attachment: HADOOP-8818.patch
> Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8818
> URL: https://issues.apache.org/jira/browse/HADOOP-8818
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs, io
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8818.patch
>
>
> Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8818) Should use equals() rather than ==
to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456674#comment-13456674 ]
Hudson commented on HADOOP-8818:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2734 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2734/])
HADOOP-8818. Use equals instead == in MD5MD5CRC32FileChecksum and TFileDumper. Contributed by Brandon Li. (Revision 1385374)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1385374
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/MD5MD5CRC32FileChecksum.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFileDumper.java
> Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8818
> URL: https://issues.apache.org/jira/browse/HADOOP-8818
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs, io
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HADOOP-8818.patch
>
>
> Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8818) Should use equals() rather than ==
to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-8818:
------------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I committed the patch to trunk. Thank you Brandon.
> Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8818
> URL: https://issues.apache.org/jira/browse/HADOOP-8818
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs, io
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HADOOP-8818.patch
>
>
> Should use equals() rather than == to compare String or Text in MD5MD5CRC32FileChecksum and TFileDumper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira