You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by "dominikriemer (via GitHub)" <gi...@apache.org> on 2023/01/20 19:45:42 UTC

[GitHub] [streampipes] dominikriemer opened a new pull request, #1135: Sp 1133

dominikriemer opened a new pull request, #1135:
URL: https://github.com/apache/streampipes/pull/1135

   <!--
     ~ Licensed to the Apache Software Foundation (ASF) under one or more
     ~ contributor license agreements.  See the NOTICE file distributed with
     ~ this work for additional information regarding copyright ownership.
     ~ The ASF licenses this file to You under the Apache License, Version 2.0
     ~ (the "License"); you may not use this file except in compliance with
     ~ the License.  You may obtain a copy of the License at
     ~
     ~    http://www.apache.org/licenses/LICENSE-2.0
     ~
     ~ Unless required by applicable law or agreed to in writing, software
     ~ distributed under the License is distributed on an "AS IS" BASIS,
     ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
     ~ See the License for the specific language governing permissions and
     ~ limitations under the License.
     ~
     -->
     
     <!--
   Thanks for contributing! Here are some tips you can follow to help us incorporate your contribution quickly and easily:
   1. If this is your first time, please read our contributor guidelines:
       - https://streampipes.apache.org/getinvolved.html
       - https://cwiki.apache.org/confluence/display/STREAMPIPES/Getting+Started
   2. Make sure the PR title is formatted like: `[#<GitHub issue id>] PR title ...`
   3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., `[WIP][#<GitHub issue id>] PR title ...`.
   4. Please write your PR title to summarize what this PR proposes/fixes.
   5. Link the PR to the corresponding GitHub issue (if present) in the `Development` section in the right menu bar. 
   6. Be sure to keep the PR description updated to reflect all changes.
   7. If possible, provide a concise example to reproduce the issue for a faster review.
   8. Make sure tests pass via `mvn clean install`.
   9. (Optional) If the contribution is large, please file an Apache ICLA
       - http://apache.org/licenses/icla.pdf
   -->
   
   ### Purpose
   <!--
   Please clarify what changes you are proposing and describe how those changes will address the issue.
   Furthermore, describe potential consequences the changes might have.
   -->
   
   Adds support to functions to create output data streams so that results of functions can be played back into StreamPipes.
   
   ### Remarks
   <!--
   Is there anything left we need to pay attention on?
   Are there some references that might be important? E.g. links to Confluence, or discussions
   on the mailing list or GitHub.
   -->
   PR introduces (a) breaking change(s): yes
   
   PR introduces (a) deprecation(s): no
   
   The StreamPipes function API was slightly changed to return a `FunctionConfig` instead of a pure `FunctionId`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [streampipes] dominikriemer merged pull request #1135: Sp 1133

Posted by "dominikriemer (via GitHub)" <gi...@apache.org>.
dominikriemer merged PR #1135:
URL: https://github.com/apache/streampipes/pull/1135


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [streampipes] dominikriemer commented on a diff in pull request #1135: Sp 1133

Posted by "dominikriemer (via GitHub)" <gi...@apache.org>.
dominikriemer commented on code in PR #1135:
URL: https://github.com/apache/streampipes/pull/1135#discussion_r1083757522


##########
streampipes-config/src/main/java/org/apache/streampipes/config/backend/DefaultMessagingSettings.java:
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.streampipes.config.backend;
+
+import org.apache.streampipes.model.config.MessagingSettings;
+import org.apache.streampipes.model.config.SpDataFormat;
+import org.apache.streampipes.model.config.SpProtocol;
+
+import java.util.Arrays;
+import java.util.List;
+
+public class DefaultMessagingSettings {
+
+  public static MessagingSettings make() {
+    List<SpProtocol> protocolList;
+    if (System.getenv(BackendConfigKeys.PRIORITIZED_PROTOCOL) != null) {
+      switch (System.getenv(BackendConfigKeys.PRIORITIZED_PROTOCOL).toLowerCase()) {
+        case "mqtt":
+          protocolList = Arrays.asList(SpProtocol.MQTT, SpProtocol.KAFKA, SpProtocol.JMS, SpProtocol.NATS);

Review Comment:
   This is used in the configuration view, where users can change the priority of protocols used for inter-pipeline communication (e.g., when "NATS" is selected, pipeline elements supporting nats and kafka would communicate over Nats, and "Kafka" would be selected as the second choice in case Nats is not supported by one of the two connected pipeline elements).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [streampipes] bossenti commented on a diff in pull request #1135: Sp 1133

Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on code in PR #1135:
URL: https://github.com/apache/streampipes/pull/1135#discussion_r1082988644


##########
streampipes-config/src/main/java/org/apache/streampipes/config/backend/DefaultMessagingSettings.java:
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.streampipes.config.backend;
+
+import org.apache.streampipes.model.config.MessagingSettings;
+import org.apache.streampipes.model.config.SpDataFormat;
+import org.apache.streampipes.model.config.SpProtocol;
+
+import java.util.Arrays;
+import java.util.List;
+
+public class DefaultMessagingSettings {
+
+  public static MessagingSettings make() {
+    List<SpProtocol> protocolList;
+    if (System.getenv(BackendConfigKeys.PRIORITIZED_PROTOCOL) != null) {
+      switch (System.getenv(BackendConfigKeys.PRIORITIZED_PROTOCOL).toLowerCase()) {
+        case "mqtt":
+          protocolList = Arrays.asList(SpProtocol.MQTT, SpProtocol.KAFKA, SpProtocol.JMS, SpProtocol.NATS);

Review Comment:
   just out of curiosity: why do we return here a list of all protocols? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org