[GitHub] [airflow] vincbeck commented on a diff in pull request #34349: Let auth managers provide their own API endpoints

["vincbeck (via GitHub)" <gi...@apache.org>]

vincbeck commented on code in PR #34349:
URL: https://github.com/apache/airflow/pull/34349#discussion_r1324959310


##########
airflow/auth/managers/base_auth_manager.py:
##########
@@ -50,6 +50,10 @@ def get_cli_commands() -> list[CLICommand]:
         """
         return []
 
+    def get_blueprint(self) -> None | Blueprint:

Review Comment:
   I would suggest mentioning "api" in the name at least for better understanding
   
   ```suggestion
       def get_api_blueprint(self) -> None | Blueprint:
   ```



##########
airflow/www/extensions/init_views.py:
##########
@@ -310,3 +311,12 @@ def init_api_experimental(app):
     )
     app.register_blueprint(endpoints.api_experimental, url_prefix="/api/experimental")
     app.extensions["csrf"].exempt(endpoints.api_experimental)
+
+
+def init_api_auth_provider(app):
+    """Initialize the API offered by the authentication provider."""

Review Comment:
   ```suggestion
       """Initialize the API offered by the auth manager."""
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org