You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/11/08 20:47:20 UTC

[GitHub] [cloudstack] stephankruggg commented on pull request #6874: Add logs to script and command execution

stephankruggg commented on PR #6874:
URL: https://github.com/apache/cloudstack/pull/6874#issuecomment-1307806417

   @DaanHoogland, as discussed [here](https://github.com/apache/cloudstack/pull/4707#discussion_r578495829), the isEnabled check is detrimental in terms of code legibility. In my opinion, this check's barely noticeable performance gain is not sufficient to counter this negative impact, so it should not be used in this scenario.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org