You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/25 03:22:34 UTC
[GitHub] [arrow-rs] HaoYang670 opened a new issue, #2156: The `GenericStringBuilder` should use `GenericBinaryBuilder`
HaoYang670 opened a new issue, #2156:
URL: https://github.com/apache/arrow-rs/issues/2156
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
Currently, the string builder uses the list builder:
```rust
pub struct GenericStringBuilder<OffsetSize: OffsetSizeTrait> {
builder: GenericListBuilder<OffsetSize, UInt8Builder>,
}
```
This requires another child array to be built, which leads to more memory overhead.
**Describe the solution you'd like**
I want the string builder to use the binary array.
Also I hope there would be some performance improvement in the `bench_string`. (At least, there should be no performance regression)
**Describe alternatives you've considered**
We could not do this if there is performance regression.
**Additional context**
Add any other context or screenshots about the feature request here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold closed issue #2156: The `GenericStringBuilder` should use `GenericBinaryBuilder`
Posted by GitBox <gi...@apache.org>.
tustvold closed issue #2156: The `GenericStringBuilder` should use `GenericBinaryBuilder`
URL: https://github.com/apache/arrow-rs/issues/2156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] HaoYang670 commented on issue #2156: The `GenericStringBuilder` should use `GenericBinaryBuilder`
Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on issue #2156:
URL: https://github.com/apache/arrow-rs/issues/2156#issuecomment-1193512179
I will work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org