You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@gmail.com> on 2020/02/15 05:07:42 UTC

Review Request 72120: RANGER-2729: RANGER-2660 should creates external users rather internal

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72120/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-2729
    https://issues.apache.org/jira/browse/RANGER-2729


Repository: ranger


Description
-------

**Problem Statement:** it seems RANGER-2660 creates internal users when a policy user does not exist in the ranger.

**Proposed Solution:** 
In Ranger there is already a method createServiceConfigUser() in XUserMgr class which can create an external user in ranger admin for given username. In this patch I am proposing to use XUserMgr.createServiceConfigUser()


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java 318f9f505 


Diff: https://reviews.apache.org/r/72120/diff/1/


Testing
-------


Thanks,

Pradeep Agrawal


Re: Review Request 72120: RANGER-2729: RANGER-2660 should creates external users rather internal

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72120/#review219639
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Feb. 17, 2020, 1:19 a.m., Pradeep Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72120/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2020, 1:19 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nitin Galave, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2729
>     https://issues.apache.org/jira/browse/RANGER-2729
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> **Problem Statement:** it seems RANGER-2660 creates internal users when a policy user does not exist in the ranger.
> 
> **Proposed Solution:** 
> In Ranger there is already a method createServiceConfigUser() in XUserMgr class which can create an external user in ranger admin for given username. In this patch I am proposing to use XUserMgr.createServiceConfigUser()
> 
> This patch also exposes an API to create an external user by providing the name of user attribute only in VXUser object
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java 318f9f505 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 1c29d8245 
>   security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 1e8a09379 
> 
> 
> Diff: https://reviews.apache.org/r/72120/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>


Re: Review Request 72120: RANGER-2729: RANGER-2660 should creates external users rather internal

Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72120/
-----------------------------------------------------------

(Updated Feb. 17, 2020, 1:19 a.m.)


Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nitin Galave, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

Description changes


Bugs: RANGER-2729
    https://issues.apache.org/jira/browse/RANGER-2729


Repository: ranger


Description (updated)
-------

**Problem Statement:** it seems RANGER-2660 creates internal users when a policy user does not exist in the ranger.

**Proposed Solution:** 
In Ranger there is already a method createServiceConfigUser() in XUserMgr class which can create an external user in ranger admin for given username. In this patch I am proposing to use XUserMgr.createServiceConfigUser()

This patch also exposes an API to create an external user by providing the name of user attribute only in VXUser object


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java 318f9f505 


Diff: https://reviews.apache.org/r/72120/diff/1/


Testing
-------


Thanks,

Pradeep Agrawal