You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/10 05:33:25 UTC
[GitHub] [incubator-tvm] jroesch opened a new pull request #6437: [RFC][Formatting] Apply black to entire Python code base.
jroesch opened a new pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437
As per the recent RFC https://discuss.tvm.apache.org/t/rfc-introduce-automatic-formatting-of-python-code/7843/10.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on a change in pull request #6437: [RFC][Formatting] Add scripts for applying Black to the Python code.
Posted by GitBox <gi...@apache.org>.
jroesch commented on a change in pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#discussion_r487332773
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
+trap cleanup 0
+
+
+if [ -x "$(command -v black)" ]; then
+ BLACK=black
+else
+ echo "Cannot find black"
+ exit 1
+fi
+
+# Print out specific version
+
+echo "Version Information: $(${BLACK} --version)"
+
+
+IFS=$'\n' read -a FILES -d'\n' < <(git diff --name-only HEAD $1 -- "*.py" "*.pyi") || true
+echo "read returned $?"
+echo "Files: $FILES"
+
+if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
+ echo "Running black on Python files against revision" $1):
+ CMD=( "black" "${FILES[@]}" )
+ echo "${CMD[@]}"
+ "${CMD[@]}"
+ exit 0
+fi
+
+echo "Running black in checking mode"
+black --diff --check
Review comment:
I think diff and check at same time give that behavior if I understand correctly, check makes it return a -1 status code which should fail this entire script.
##########
File path: python/tvm/relay/frontend/mxnet_qnn_op_utils.py
##########
@@ -277,6 +277,8 @@ def quantize_conv_weights_bias_channel_mkldnn_from_var(weights_var,
def get_mkldnn_requantize_scale_outDtype(min_output_range,
max_output_range,
out_dtype):
+ """Get the MKLDNN requantized scale."""
+ quantized_out_range = (
Review comment:
These are a bunch of random edits that made the results of black happier.
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
Review comment:
I think this is hold over from my copy paste from the clang-format script, we shouldn't need this.
##########
File path: pyproject.toml
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[tool.black]
+line-length = 100
+target-version = ['py36']
+include = '\.pyi?$'
+exclude = '''
+
+(
+ /(
+ \.github
+ | \.tvm
+ | \.tvm_test_data
+ | \.vscode
+ | \.venv
+ | cmake\/
+ | conda\/
+ | docker\/
+ | golang\/
+ | include\/
+ | jvm\/
+ | licenses\/
+ | nnvm\/
+ | rust\/
+ | src\/
+ | tests\/
+ | vta\/
+ | web\/
+ )/|tests/lint/add_asf_header.py|tests/lint/check_file_type.py|python/tvm/topi/testing/pool3d_python.py|python/topi/python/test_topi_pooling.py
Review comment:
These two files actually trigger an internal error with black and I was going to open up a follow up issue to fix these.
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
+trap cleanup 0
+
+
+if [ -x "$(command -v black)" ]; then
+ BLACK=black
+else
+ echo "Cannot find black"
+ exit 1
+fi
+
+# Print out specific version
+
+echo "Version Information: $(${BLACK} --version)"
+
+
+IFS=$'\n' read -a FILES -d'\n' < <(git diff --name-only HEAD $1 -- "*.py" "*.pyi") || true
+echo "read returned $?"
+echo "Files: $FILES"
+
+if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
+ echo "Running black on Python files against revision" $1):
+ CMD=( "black" "${FILES[@]}" )
+ echo "${CMD[@]}"
+ "${CMD[@]}"
+ exit 0
+fi
+
+echo "Running black in checking mode"
+black --diff --check
Review comment:
I think diff and check at same time give that behavior if I understand correctly, check makes it return a -1 status code which should fail this entire script.
##########
File path: python/tvm/relay/frontend/mxnet_qnn_op_utils.py
##########
@@ -277,6 +277,8 @@ def quantize_conv_weights_bias_channel_mkldnn_from_var(weights_var,
def get_mkldnn_requantize_scale_outDtype(min_output_range,
max_output_range,
out_dtype):
+ """Get the MKLDNN requantized scale."""
+ quantized_out_range = (
Review comment:
These are a bunch of random edits that made the results of black happier.
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
Review comment:
I think this is hold over from my copy paste from the clang-format script, we shouldn't need this.
##########
File path: pyproject.toml
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[tool.black]
+line-length = 100
+target-version = ['py36']
+include = '\.pyi?$'
+exclude = '''
+
+(
+ /(
+ \.github
+ | \.tvm
+ | \.tvm_test_data
+ | \.vscode
+ | \.venv
+ | cmake\/
+ | conda\/
+ | docker\/
+ | golang\/
+ | include\/
+ | jvm\/
+ | licenses\/
+ | nnvm\/
+ | rust\/
+ | src\/
+ | tests\/
+ | vta\/
+ | web\/
+ )/|tests/lint/add_asf_header.py|tests/lint/check_file_type.py|python/tvm/topi/testing/pool3d_python.py|python/topi/python/test_topi_pooling.py
Review comment:
These two files actually trigger an internal error with black and I was going to open up a follow up issue to fix these.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on a change in pull request #6437: [RFC][Formatting] Add scripts for applying Black to the Python code.
Posted by GitBox <gi...@apache.org>.
jroesch commented on a change in pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#discussion_r487333981
##########
File path: pyproject.toml
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[tool.black]
+line-length = 100
+target-version = ['py36']
+include = '\.pyi?$'
+exclude = '''
+
+(
+ /(
+ \.github
+ | \.tvm
+ | \.tvm_test_data
+ | \.vscode
+ | \.venv
+ | cmake\/
+ | conda\/
+ | docker\/
+ | golang\/
+ | include\/
+ | jvm\/
+ | licenses\/
+ | nnvm\/
+ | rust\/
+ | src\/
+ | tests\/
+ | vta\/
+ | web\/
+ )/|tests/lint/add_asf_header.py|tests/lint/check_file_type.py|python/tvm/topi/testing/pool3d_python.py|python/topi/python/test_topi_pooling.py
Review comment:
These two files actually trigger an internal error with black and I was going to open up a follow up issue to fix these.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on pull request #6437: [RFC][Formatting] Add scripts for applying Black to the Python code.
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#issuecomment-690930637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] leandron commented on a change in pull request #6437: [RFC][Formatting] Add scripts for applying Black to the Python code.
Posted by GitBox <gi...@apache.org>.
leandron commented on a change in pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#discussion_r486956462
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
Review comment:
Is this temp file `/tmp/$$.black-format.txt` supposed to be created by redirecting the output of command in line 67?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on pull request #6437: [RFC][Formatting] Apply black to entire Python code base.
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#issuecomment-690594159
@areusch @tqchen @comaniac I can rollback the formatting, the first 3 or 4 commits were focused on formatting then I went through the process to see if it would actually work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6437: [RFC][Formatting] Apply black to entire Python code base.
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#issuecomment-690520497
It is a bit hard to review 1000 files...maybe just take a look at the pyproject.toml file and assume other parts are correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] areusch commented on a change in pull request #6437: [RFC][Formatting] Add scripts for applying Black to the Python code.
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#discussion_r486617414
##########
File path: pyproject.toml
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[tool.black]
+line-length = 100
+target-version = ['py36']
+include = '\.pyi?$'
+exclude = '''
+
+(
+ /(
+ \.github
+ | \.tvm
+ | \.tvm_test_data
+ | \.vscode
+ | \.venv
+ | cmake\/
+ | conda\/
+ | docker\/
+ | golang\/
+ | include\/
+ | jvm\/
+ | licenses\/
+ | nnvm\/
+ | rust\/
+ | src\/
+ | tests\/
+ | vta\/
+ | web\/
+ )/|tests/lint/add_asf_header.py|tests/lint/check_file_type.py|python/tvm/topi/testing/pool3d_python.py|python/topi/python/test_topi_pooling.py
Review comment:
can you break these line by line and sort?
##########
File path: python/tvm/relay/frontend/mxnet_qnn_op_utils.py
##########
@@ -277,6 +277,8 @@ def quantize_conv_weights_bias_channel_mkldnn_from_var(weights_var,
def get_mkldnn_requantize_scale_outDtype(min_output_range,
max_output_range,
out_dtype):
+ """Get the MKLDNN requantized scale."""
+ quantized_out_range = (
Review comment:
what's up with this line?
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
Review comment:
right now `-i` does both inplace format and check, do we want that?
##########
File path: python/tvm/te/hybrid/calls.py
##########
@@ -27,7 +27,7 @@
from .util import _internal_assert
-# pylint: disable=redefined-builtin
+# pylint: disable=redefined-builtin,invalid-name
Review comment:
same question here--do we need to update pylint?
##########
File path: python/tvm/contrib/hexagon.py
##########
@@ -14,8 +14,8 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
-'''Utility for Hexagon backend'''
+# pylint: disable=invalid-name
Review comment:
how come we need this?
##########
File path: python/tvm/support.py
##########
@@ -27,6 +27,7 @@ def libinfo():
The dictionary of compile-time info.
"""
return {k: v for k, v in GetLibInfo().items()} # pylint: disable=unnecessary-comprehension
+ }
Review comment:
there are a lot of these extra closing braces or insertions that look like `function_call(` with no close `)` added. merge mistake? seems like nothing can possibly pass til they're deleted...
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
+trap cleanup 0
+
+
+if [ -x "$(command -v black)" ]; then
+ BLACK=black
+else
+ echo "Cannot find black"
+ exit 1
+fi
+
+# Print out specific version
+
+echo "Version Information: $(${BLACK} --version)"
+
+
+IFS=$'\n' read -a FILES -d'\n' < <(git diff --name-only HEAD $1 -- "*.py" "*.pyi") || true
+echo "read returned $?"
+echo "Files: $FILES"
+
+if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
+ echo "Running black on Python files against revision" $1):
+ CMD=( "black" "${FILES[@]}" )
+ echo "${CMD[@]}"
+ "${CMD[@]}"
+ exit 0
+fi
+
+echo "Running black in checking mode"
+black --diff --check
Review comment:
I think you either want --diff and assert on an empty output or --check, I don't know what both do?
##########
File path: pyproject.toml
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[tool.black]
+line-length = 100
+target-version = ['py36']
+include = '\.pyi?$'
+exclude = '''
+
+(
+ /(
+ \.github
+ | \.tvm
+ | \.tvm_test_data
+ | \.vscode
+ | \.venv
+ | cmake\/
+ | conda\/
+ | docker\/
+ | golang\/
+ | include\/
+ | jvm\/
+ | licenses\/
+ | nnvm\/
+ | rust\/
+ | src\/
+ | tests\/
+ | vta\/
+ | web\/
+ )/|tests/lint/add_asf_header.py|tests/lint/check_file_type.py|python/tvm/topi/testing/pool3d_python.py|python/topi/python/test_topi_pooling.py
Review comment:
can you break these line by line and sort?
##########
File path: python/tvm/relay/frontend/mxnet_qnn_op_utils.py
##########
@@ -277,6 +277,8 @@ def quantize_conv_weights_bias_channel_mkldnn_from_var(weights_var,
def get_mkldnn_requantize_scale_outDtype(min_output_range,
max_output_range,
out_dtype):
+ """Get the MKLDNN requantized scale."""
+ quantized_out_range = (
Review comment:
what's up with this line?
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
Review comment:
right now `-i` does both inplace format and check, do we want that?
##########
File path: python/tvm/te/hybrid/calls.py
##########
@@ -27,7 +27,7 @@
from .util import _internal_assert
-# pylint: disable=redefined-builtin
+# pylint: disable=redefined-builtin,invalid-name
Review comment:
same question here--do we need to update pylint?
##########
File path: python/tvm/contrib/hexagon.py
##########
@@ -14,8 +14,8 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
-'''Utility for Hexagon backend'''
+# pylint: disable=invalid-name
Review comment:
how come we need this?
##########
File path: python/tvm/support.py
##########
@@ -27,6 +27,7 @@ def libinfo():
The dictionary of compile-time info.
"""
return {k: v for k, v in GetLibInfo().items()} # pylint: disable=unnecessary-comprehension
+ }
Review comment:
there are a lot of these extra closing braces or insertions that look like `function_call(` with no close `)` added. merge mistake? seems like nothing can possibly pass til they're deleted...
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
+trap cleanup 0
+
+
+if [ -x "$(command -v black)" ]; then
+ BLACK=black
+else
+ echo "Cannot find black"
+ exit 1
+fi
+
+# Print out specific version
+
+echo "Version Information: $(${BLACK} --version)"
+
+
+IFS=$'\n' read -a FILES -d'\n' < <(git diff --name-only HEAD $1 -- "*.py" "*.pyi") || true
+echo "read returned $?"
+echo "Files: $FILES"
+
+if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
+ echo "Running black on Python files against revision" $1):
+ CMD=( "black" "${FILES[@]}" )
+ echo "${CMD[@]}"
+ "${CMD[@]}"
+ exit 0
+fi
+
+echo "Running black in checking mode"
+black --diff --check
Review comment:
I think you either want --diff and assert on an empty output or --check, I don't know what both do?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on a change in pull request #6437: [RFC][Formatting] Add scripts for applying Black to the Python code.
Posted by GitBox <gi...@apache.org>.
jroesch commented on a change in pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#discussion_r487332773
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
+trap cleanup 0
+
+
+if [ -x "$(command -v black)" ]; then
+ BLACK=black
+else
+ echo "Cannot find black"
+ exit 1
+fi
+
+# Print out specific version
+
+echo "Version Information: $(${BLACK} --version)"
+
+
+IFS=$'\n' read -a FILES -d'\n' < <(git diff --name-only HEAD $1 -- "*.py" "*.pyi") || true
+echo "read returned $?"
+echo "Files: $FILES"
+
+if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
+ echo "Running black on Python files against revision" $1):
+ CMD=( "black" "${FILES[@]}" )
+ echo "${CMD[@]}"
+ "${CMD[@]}"
+ exit 0
+fi
+
+echo "Running black in checking mode"
+black --diff --check
Review comment:
I think diff and check at same time give that behavior if I understand correctly, check makes it return a -1 status code which should fail this entire script.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on a change in pull request #6437: [RFC][Formatting] Add scripts for applying Black to the Python code.
Posted by GitBox <gi...@apache.org>.
jroesch commented on a change in pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#discussion_r487332857
##########
File path: python/tvm/relay/frontend/mxnet_qnn_op_utils.py
##########
@@ -277,6 +277,8 @@ def quantize_conv_weights_bias_channel_mkldnn_from_var(weights_var,
def get_mkldnn_requantize_scale_outDtype(min_output_range,
max_output_range,
out_dtype):
+ """Get the MKLDNN requantized scale."""
+ quantized_out_range = (
Review comment:
These are a bunch of random edits that made the results of black happier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] leandron commented on a change in pull request #6437: [RFC][Formatting] Add scripts for applying Black to the Python code.
Posted by GitBox <gi...@apache.org>.
leandron commented on a change in pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#discussion_r486956462
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
Review comment:
Is this temp file `/tmp/$$.black-format.txt` supposed to be created by redirecting the output of command in line 67?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on a change in pull request #6437: [RFC][Formatting] Add scripts for applying Black to the Python code.
Posted by GitBox <gi...@apache.org>.
jroesch commented on a change in pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#discussion_r487333480
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
Review comment:
I think this is hold over from my copy paste from the clang-format script, we shouldn't need this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on pull request #6437: [RFC][Formatting] Apply black to entire Python code base.
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#issuecomment-689997944
cc @tqchen @areusch @comaniac @u99127 @jwfromm @mbrookhart @junrushao1994
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on pull request #6437: [RFC][Formatting] Add scripts for applying Black to the Python code.
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#issuecomment-691357110
I think I addressed all the comments, and bumped the CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on pull request #6437: [RFC][Formatting] Add scripts for applying Black to the Python code.
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#issuecomment-690821576
@tqchen recommended that we first format the entire code base using these settings then try to land the CI parts, going to open a second PR with the fully formatted repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on pull request #6437: [RFC][Formatting] Add scripts for applying Black to the Python code.
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#issuecomment-690821576
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on a change in pull request #6437: [RFC][Formatting] Add scripts for applying Black to the Python code.
Posted by GitBox <gi...@apache.org>.
jroesch commented on a change in pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#discussion_r487332773
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
+trap cleanup 0
+
+
+if [ -x "$(command -v black)" ]; then
+ BLACK=black
+else
+ echo "Cannot find black"
+ exit 1
+fi
+
+# Print out specific version
+
+echo "Version Information: $(${BLACK} --version)"
+
+
+IFS=$'\n' read -a FILES -d'\n' < <(git diff --name-only HEAD $1 -- "*.py" "*.pyi") || true
+echo "read returned $?"
+echo "Files: $FILES"
+
+if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
+ echo "Running black on Python files against revision" $1):
+ CMD=( "black" "${FILES[@]}" )
+ echo "${CMD[@]}"
+ "${CMD[@]}"
+ exit 0
+fi
+
+echo "Running black in checking mode"
+black --diff --check
Review comment:
I think diff and check at same time give that behavior if I understand correctly, check makes it return a -1 status code which should fail this entire script.
##########
File path: python/tvm/relay/frontend/mxnet_qnn_op_utils.py
##########
@@ -277,6 +277,8 @@ def quantize_conv_weights_bias_channel_mkldnn_from_var(weights_var,
def get_mkldnn_requantize_scale_outDtype(min_output_range,
max_output_range,
out_dtype):
+ """Get the MKLDNN requantized scale."""
+ quantized_out_range = (
Review comment:
These are a bunch of random edits that made the results of black happier.
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
Review comment:
I think this is hold over from my copy paste from the clang-format script, we shouldn't need this.
##########
File path: pyproject.toml
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[tool.black]
+line-length = 100
+target-version = ['py36']
+include = '\.pyi?$'
+exclude = '''
+
+(
+ /(
+ \.github
+ | \.tvm
+ | \.tvm_test_data
+ | \.vscode
+ | \.venv
+ | cmake\/
+ | conda\/
+ | docker\/
+ | golang\/
+ | include\/
+ | jvm\/
+ | licenses\/
+ | nnvm\/
+ | rust\/
+ | src\/
+ | tests\/
+ | vta\/
+ | web\/
+ )/|tests/lint/add_asf_header.py|tests/lint/check_file_type.py|python/tvm/topi/testing/pool3d_python.py|python/topi/python/test_topi_pooling.py
Review comment:
These two files actually trigger an internal error with black and I was going to open up a follow up issue to fix these.
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
+trap cleanup 0
+
+
+if [ -x "$(command -v black)" ]; then
+ BLACK=black
+else
+ echo "Cannot find black"
+ exit 1
+fi
+
+# Print out specific version
+
+echo "Version Information: $(${BLACK} --version)"
+
+
+IFS=$'\n' read -a FILES -d'\n' < <(git diff --name-only HEAD $1 -- "*.py" "*.pyi") || true
+echo "read returned $?"
+echo "Files: $FILES"
+
+if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
+ echo "Running black on Python files against revision" $1):
+ CMD=( "black" "${FILES[@]}" )
+ echo "${CMD[@]}"
+ "${CMD[@]}"
+ exit 0
+fi
+
+echo "Running black in checking mode"
+black --diff --check
Review comment:
I think diff and check at same time give that behavior if I understand correctly, check makes it return a -1 status code which should fail this entire script.
##########
File path: python/tvm/relay/frontend/mxnet_qnn_op_utils.py
##########
@@ -277,6 +277,8 @@ def quantize_conv_weights_bias_channel_mkldnn_from_var(weights_var,
def get_mkldnn_requantize_scale_outDtype(min_output_range,
max_output_range,
out_dtype):
+ """Get the MKLDNN requantized scale."""
+ quantized_out_range = (
Review comment:
These are a bunch of random edits that made the results of black happier.
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
Review comment:
I think this is hold over from my copy paste from the clang-format script, we shouldn't need this.
##########
File path: pyproject.toml
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[tool.black]
+line-length = 100
+target-version = ['py36']
+include = '\.pyi?$'
+exclude = '''
+
+(
+ /(
+ \.github
+ | \.tvm
+ | \.tvm_test_data
+ | \.vscode
+ | \.venv
+ | cmake\/
+ | conda\/
+ | docker\/
+ | golang\/
+ | include\/
+ | jvm\/
+ | licenses\/
+ | nnvm\/
+ | rust\/
+ | src\/
+ | tests\/
+ | vta\/
+ | web\/
+ )/|tests/lint/add_asf_header.py|tests/lint/check_file_type.py|python/tvm/topi/testing/pool3d_python.py|python/topi/python/test_topi_pooling.py
Review comment:
These two files actually trigger an internal error with black and I was going to open up a follow up issue to fix these.
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
+trap cleanup 0
+
+
+if [ -x "$(command -v black)" ]; then
+ BLACK=black
+else
+ echo "Cannot find black"
+ exit 1
+fi
+
+# Print out specific version
+
+echo "Version Information: $(${BLACK} --version)"
+
+
+IFS=$'\n' read -a FILES -d'\n' < <(git diff --name-only HEAD $1 -- "*.py" "*.pyi") || true
+echo "read returned $?"
+echo "Files: $FILES"
+
+if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
+ echo "Running black on Python files against revision" $1):
+ CMD=( "black" "${FILES[@]}" )
+ echo "${CMD[@]}"
+ "${CMD[@]}"
+ exit 0
+fi
+
+echo "Running black in checking mode"
+black --diff --check
Review comment:
I think diff and check at same time give that behavior if I understand correctly, check makes it return a -1 status code which should fail this entire script.
##########
File path: python/tvm/relay/frontend/mxnet_qnn_op_utils.py
##########
@@ -277,6 +277,8 @@ def quantize_conv_weights_bias_channel_mkldnn_from_var(weights_var,
def get_mkldnn_requantize_scale_outDtype(min_output_range,
max_output_range,
out_dtype):
+ """Get the MKLDNN requantized scale."""
+ quantized_out_range = (
Review comment:
These are a bunch of random edits that made the results of black happier.
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
Review comment:
I think this is hold over from my copy paste from the clang-format script, we shouldn't need this.
##########
File path: pyproject.toml
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[tool.black]
+line-length = 100
+target-version = ['py36']
+include = '\.pyi?$'
+exclude = '''
+
+(
+ /(
+ \.github
+ | \.tvm
+ | \.tvm_test_data
+ | \.vscode
+ | \.venv
+ | cmake\/
+ | conda\/
+ | docker\/
+ | golang\/
+ | include\/
+ | jvm\/
+ | licenses\/
+ | nnvm\/
+ | rust\/
+ | src\/
+ | tests\/
+ | vta\/
+ | web\/
+ )/|tests/lint/add_asf_header.py|tests/lint/check_file_type.py|python/tvm/topi/testing/pool3d_python.py|python/topi/python/test_topi_pooling.py
Review comment:
These two files actually trigger an internal error with black and I was going to open up a follow up issue to fix these.
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
+trap cleanup 0
+
+
+if [ -x "$(command -v black)" ]; then
+ BLACK=black
+else
+ echo "Cannot find black"
+ exit 1
+fi
+
+# Print out specific version
+
+echo "Version Information: $(${BLACK} --version)"
+
+
+IFS=$'\n' read -a FILES -d'\n' < <(git diff --name-only HEAD $1 -- "*.py" "*.pyi") || true
+echo "read returned $?"
+echo "Files: $FILES"
+
+if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
+ echo "Running black on Python files against revision" $1):
+ CMD=( "black" "${FILES[@]}" )
+ echo "${CMD[@]}"
+ "${CMD[@]}"
+ exit 0
+fi
+
+echo "Running black in checking mode"
+black --diff --check
Review comment:
I think diff and check at same time give that behavior if I understand correctly, check makes it return a -1 status code which should fail this entire script.
##########
File path: python/tvm/relay/frontend/mxnet_qnn_op_utils.py
##########
@@ -277,6 +277,8 @@ def quantize_conv_weights_bias_channel_mkldnn_from_var(weights_var,
def get_mkldnn_requantize_scale_outDtype(min_output_range,
max_output_range,
out_dtype):
+ """Get the MKLDNN requantized scale."""
+ quantized_out_range = (
Review comment:
These are a bunch of random edits that made the results of black happier.
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
Review comment:
I think this is hold over from my copy paste from the clang-format script, we shouldn't need this.
##########
File path: pyproject.toml
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[tool.black]
+line-length = 100
+target-version = ['py36']
+include = '\.pyi?$'
+exclude = '''
+
+(
+ /(
+ \.github
+ | \.tvm
+ | \.tvm_test_data
+ | \.vscode
+ | \.venv
+ | cmake\/
+ | conda\/
+ | docker\/
+ | golang\/
+ | include\/
+ | jvm\/
+ | licenses\/
+ | nnvm\/
+ | rust\/
+ | src\/
+ | tests\/
+ | vta\/
+ | web\/
+ )/|tests/lint/add_asf_header.py|tests/lint/check_file_type.py|python/tvm/topi/testing/pool3d_python.py|python/topi/python/test_topi_pooling.py
Review comment:
These two files actually trigger an internal error with black and I was going to open up a follow up issue to fix these.
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
+trap cleanup 0
+
+
+if [ -x "$(command -v black)" ]; then
+ BLACK=black
+else
+ echo "Cannot find black"
+ exit 1
+fi
+
+# Print out specific version
+
+echo "Version Information: $(${BLACK} --version)"
+
+
+IFS=$'\n' read -a FILES -d'\n' < <(git diff --name-only HEAD $1 -- "*.py" "*.pyi") || true
+echo "read returned $?"
+echo "Files: $FILES"
+
+if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
+ echo "Running black on Python files against revision" $1):
+ CMD=( "black" "${FILES[@]}" )
+ echo "${CMD[@]}"
+ "${CMD[@]}"
+ exit 0
+fi
+
+echo "Running black in checking mode"
+black --diff --check
Review comment:
I think diff and check at same time give that behavior if I understand correctly, check makes it return a -1 status code which should fail this entire script.
##########
File path: python/tvm/relay/frontend/mxnet_qnn_op_utils.py
##########
@@ -277,6 +277,8 @@ def quantize_conv_weights_bias_channel_mkldnn_from_var(weights_var,
def get_mkldnn_requantize_scale_outDtype(min_output_range,
max_output_range,
out_dtype):
+ """Get the MKLDNN requantized scale."""
+ quantized_out_range = (
Review comment:
These are a bunch of random edits that made the results of black happier.
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
Review comment:
I think this is hold over from my copy paste from the clang-format script, we shouldn't need this.
##########
File path: pyproject.toml
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[tool.black]
+line-length = 100
+target-version = ['py36']
+include = '\.pyi?$'
+exclude = '''
+
+(
+ /(
+ \.github
+ | \.tvm
+ | \.tvm_test_data
+ | \.vscode
+ | \.venv
+ | cmake\/
+ | conda\/
+ | docker\/
+ | golang\/
+ | include\/
+ | jvm\/
+ | licenses\/
+ | nnvm\/
+ | rust\/
+ | src\/
+ | tests\/
+ | vta\/
+ | web\/
+ )/|tests/lint/add_asf_header.py|tests/lint/check_file_type.py|python/tvm/topi/testing/pool3d_python.py|python/topi/python/test_topi_pooling.py
Review comment:
These two files actually trigger an internal error with black and I was going to open up a follow up issue to fix these.
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
+trap cleanup 0
+
+
+if [ -x "$(command -v black)" ]; then
+ BLACK=black
+else
+ echo "Cannot find black"
+ exit 1
+fi
+
+# Print out specific version
+
+echo "Version Information: $(${BLACK} --version)"
+
+
+IFS=$'\n' read -a FILES -d'\n' < <(git diff --name-only HEAD $1 -- "*.py" "*.pyi") || true
+echo "read returned $?"
+echo "Files: $FILES"
+
+if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
+ echo "Running black on Python files against revision" $1):
+ CMD=( "black" "${FILES[@]}" )
+ echo "${CMD[@]}"
+ "${CMD[@]}"
+ exit 0
+fi
+
+echo "Running black in checking mode"
+black --diff --check
Review comment:
I think diff and check at same time give that behavior if I understand correctly, check makes it return a -1 status code which should fail this entire script.
##########
File path: python/tvm/relay/frontend/mxnet_qnn_op_utils.py
##########
@@ -277,6 +277,8 @@ def quantize_conv_weights_bias_channel_mkldnn_from_var(weights_var,
def get_mkldnn_requantize_scale_outDtype(min_output_range,
max_output_range,
out_dtype):
+ """Get the MKLDNN requantized scale."""
+ quantized_out_range = (
Review comment:
These are a bunch of random edits that made the results of black happier.
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
Review comment:
I think this is hold over from my copy paste from the clang-format script, we shouldn't need this.
##########
File path: pyproject.toml
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[tool.black]
+line-length = 100
+target-version = ['py36']
+include = '\.pyi?$'
+exclude = '''
+
+(
+ /(
+ \.github
+ | \.tvm
+ | \.tvm_test_data
+ | \.vscode
+ | \.venv
+ | cmake\/
+ | conda\/
+ | docker\/
+ | golang\/
+ | include\/
+ | jvm\/
+ | licenses\/
+ | nnvm\/
+ | rust\/
+ | src\/
+ | tests\/
+ | vta\/
+ | web\/
+ )/|tests/lint/add_asf_header.py|tests/lint/check_file_type.py|python/tvm/topi/testing/pool3d_python.py|python/topi/python/test_topi_pooling.py
Review comment:
These two files actually trigger an internal error with black and I was going to open up a follow up issue to fix these.
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
+trap cleanup 0
+
+
+if [ -x "$(command -v black)" ]; then
+ BLACK=black
+else
+ echo "Cannot find black"
+ exit 1
+fi
+
+# Print out specific version
+
+echo "Version Information: $(${BLACK} --version)"
+
+
+IFS=$'\n' read -a FILES -d'\n' < <(git diff --name-only HEAD $1 -- "*.py" "*.pyi") || true
+echo "read returned $?"
+echo "Files: $FILES"
+
+if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
+ echo "Running black on Python files against revision" $1):
+ CMD=( "black" "${FILES[@]}" )
+ echo "${CMD[@]}"
+ "${CMD[@]}"
+ exit 0
+fi
+
+echo "Running black in checking mode"
+black --diff --check
Review comment:
I think diff and check at same time give that behavior if I understand correctly, check makes it return a -1 status code which should fail this entire script.
##########
File path: python/tvm/relay/frontend/mxnet_qnn_op_utils.py
##########
@@ -277,6 +277,8 @@ def quantize_conv_weights_bias_channel_mkldnn_from_var(weights_var,
def get_mkldnn_requantize_scale_outDtype(min_output_range,
max_output_range,
out_dtype):
+ """Get the MKLDNN requantized scale."""
+ quantized_out_range = (
Review comment:
These are a bunch of random edits that made the results of black happier.
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
Review comment:
I think this is hold over from my copy paste from the clang-format script, we shouldn't need this.
##########
File path: pyproject.toml
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[tool.black]
+line-length = 100
+target-version = ['py36']
+include = '\.pyi?$'
+exclude = '''
+
+(
+ /(
+ \.github
+ | \.tvm
+ | \.tvm_test_data
+ | \.vscode
+ | \.venv
+ | cmake\/
+ | conda\/
+ | docker\/
+ | golang\/
+ | include\/
+ | jvm\/
+ | licenses\/
+ | nnvm\/
+ | rust\/
+ | src\/
+ | tests\/
+ | vta\/
+ | web\/
+ )/|tests/lint/add_asf_header.py|tests/lint/check_file_type.py|python/tvm/topi/testing/pool3d_python.py|python/topi/python/test_topi_pooling.py
Review comment:
These two files actually trigger an internal error with black and I was going to open up a follow up issue to fix these.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #6437: [RFC][Formatting] Add scripts for applying Black to the Python code.
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6437: [RFC][Formatting] Add scripts for applying Black to the Python code.
Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#discussion_r486620292
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
+trap cleanup 0
+
+
+if [ -x "$(command -v black)" ]; then
+ BLACK=black
+else
+ echo "Cannot find black"
+ exit 1
+fi
+
+# Print out specific version
+
+echo "Version Information: $(${BLACK} --version)"
Review comment:
Seems like `BLACK` is only used for displaying the version. If so, how about move this line to the if-block so that we can get rid of `BLACK` at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] leandron commented on a change in pull request #6437: [RFC][Formatting] Add scripts for applying Black to the Python code.
Posted by GitBox <gi...@apache.org>.
leandron commented on a change in pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#discussion_r486956462
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
Review comment:
Is this temp file `/tmp/$$.black-format.txt` supposed to be created by redirecting the output of command in line 67?
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
Review comment:
Is this temp file `/tmp/$$.black-format.txt` supposed to be created by redirecting the output of command in line 67?
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
Review comment:
Is this temp file `/tmp/$$.black-format.txt` supposed to be created by redirecting the output of command in line 67?
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
Review comment:
Is this temp file `/tmp/$$.black-format.txt` supposed to be created by redirecting the output of command in line 67?
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
Review comment:
Is this temp file `/tmp/$$.black-format.txt` supposed to be created by redirecting the output of command in line 67?
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
Review comment:
Is this temp file `/tmp/$$.black-format.txt` supposed to be created by redirecting the output of command in line 67?
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
Review comment:
Is this temp file `/tmp/$$.black-format.txt` supposed to be created by redirecting the output of command in line 67?
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
Review comment:
Is this temp file `/tmp/$$.black-format.txt` supposed to be created by redirecting the output of command in line 67?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on a change in pull request #6437: [RFC][Formatting] Apply black to entire Python code base.
Posted by GitBox <gi...@apache.org>.
jroesch commented on a change in pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#discussion_r486547524
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,76 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
+trap cleanup 0
+
+
+if [ -x "$(command -v black)" ]; then
+ BLACK=black
+else
+ echo "Cannot find black"
+ exit 1
+fi
+
+# Print out specific version
+${BLACK} --version
+
+FILES=$(git diff --name-only HEAD $1 -- "*.py" "*.pyi" | tr '\n' ' ')
Review comment:
honestly I hate bash and struggle through as much as possible will defer to you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6437: [RFC][Formatting] Add scripts for applying Black to the Python code.
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#issuecomment-691506743
There is some flakiness in the CI. Please retrigger and let's merge it in
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6437: [RFC][Formatting] Add scripts for applying Black to the Python code.
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#issuecomment-691506743
There is some flakiness in the CI. Please retrigger and let's merge it in
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on a change in pull request #6437: [RFC][Formatting] Apply black to entire Python code base.
Posted by GitBox <gi...@apache.org>.
jroesch commented on a change in pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#discussion_r486554772
##########
File path: pyproject.toml
##########
@@ -0,0 +1,29 @@
+[tool.black]
+line-length = 88
Review comment:
@tqchen confirmed this should be 100.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] areusch commented on a change in pull request #6437: [RFC][Formatting] Add scripts for applying Black to the Python code.
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#discussion_r486617414
##########
File path: pyproject.toml
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[tool.black]
+line-length = 100
+target-version = ['py36']
+include = '\.pyi?$'
+exclude = '''
+
+(
+ /(
+ \.github
+ | \.tvm
+ | \.tvm_test_data
+ | \.vscode
+ | \.venv
+ | cmake\/
+ | conda\/
+ | docker\/
+ | golang\/
+ | include\/
+ | jvm\/
+ | licenses\/
+ | nnvm\/
+ | rust\/
+ | src\/
+ | tests\/
+ | vta\/
+ | web\/
+ )/|tests/lint/add_asf_header.py|tests/lint/check_file_type.py|python/tvm/topi/testing/pool3d_python.py|python/topi/python/test_topi_pooling.py
Review comment:
can you break these line by line and sort?
##########
File path: python/tvm/relay/frontend/mxnet_qnn_op_utils.py
##########
@@ -277,6 +277,8 @@ def quantize_conv_weights_bias_channel_mkldnn_from_var(weights_var,
def get_mkldnn_requantize_scale_outDtype(min_output_range,
max_output_range,
out_dtype):
+ """Get the MKLDNN requantized scale."""
+ quantized_out_range = (
Review comment:
what's up with this line?
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
Review comment:
right now `-i` does both inplace format and check, do we want that?
##########
File path: python/tvm/te/hybrid/calls.py
##########
@@ -27,7 +27,7 @@
from .util import _internal_assert
-# pylint: disable=redefined-builtin
+# pylint: disable=redefined-builtin,invalid-name
Review comment:
same question here--do we need to update pylint?
##########
File path: python/tvm/contrib/hexagon.py
##########
@@ -14,8 +14,8 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
-'''Utility for Hexagon backend'''
+# pylint: disable=invalid-name
Review comment:
how come we need this?
##########
File path: python/tvm/support.py
##########
@@ -27,6 +27,7 @@ def libinfo():
The dictionary of compile-time info.
"""
return {k: v for k, v in GetLibInfo().items()} # pylint: disable=unnecessary-comprehension
+ }
Review comment:
there are a lot of these extra closing braces or insertions that look like `function_call(` with no close `)` added. merge mistake? seems like nothing can possibly pass til they're deleted...
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
+trap cleanup 0
+
+
+if [ -x "$(command -v black)" ]; then
+ BLACK=black
+else
+ echo "Cannot find black"
+ exit 1
+fi
+
+# Print out specific version
+
+echo "Version Information: $(${BLACK} --version)"
+
+
+IFS=$'\n' read -a FILES -d'\n' < <(git diff --name-only HEAD $1 -- "*.py" "*.pyi") || true
+echo "read returned $?"
+echo "Files: $FILES"
+
+if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
+ echo "Running black on Python files against revision" $1):
+ CMD=( "black" "${FILES[@]}" )
+ echo "${CMD[@]}"
+ "${CMD[@]}"
+ exit 0
+fi
+
+echo "Running black in checking mode"
+black --diff --check
Review comment:
I think you either want --diff and assert on an empty output or --check, I don't know what both do?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] areusch commented on a change in pull request #6437: [RFC][Formatting] Add scripts for applying Black to the Python code.
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#discussion_r486617414
##########
File path: pyproject.toml
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[tool.black]
+line-length = 100
+target-version = ['py36']
+include = '\.pyi?$'
+exclude = '''
+
+(
+ /(
+ \.github
+ | \.tvm
+ | \.tvm_test_data
+ | \.vscode
+ | \.venv
+ | cmake\/
+ | conda\/
+ | docker\/
+ | golang\/
+ | include\/
+ | jvm\/
+ | licenses\/
+ | nnvm\/
+ | rust\/
+ | src\/
+ | tests\/
+ | vta\/
+ | web\/
+ )/|tests/lint/add_asf_header.py|tests/lint/check_file_type.py|python/tvm/topi/testing/pool3d_python.py|python/topi/python/test_topi_pooling.py
Review comment:
can you break these line by line and sort?
##########
File path: python/tvm/relay/frontend/mxnet_qnn_op_utils.py
##########
@@ -277,6 +277,8 @@ def quantize_conv_weights_bias_channel_mkldnn_from_var(weights_var,
def get_mkldnn_requantize_scale_outDtype(min_output_range,
max_output_range,
out_dtype):
+ """Get the MKLDNN requantized scale."""
+ quantized_out_range = (
Review comment:
what's up with this line?
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
Review comment:
right now `-i` does both inplace format and check, do we want that?
##########
File path: python/tvm/te/hybrid/calls.py
##########
@@ -27,7 +27,7 @@
from .util import _internal_assert
-# pylint: disable=redefined-builtin
+# pylint: disable=redefined-builtin,invalid-name
Review comment:
same question here--do we need to update pylint?
##########
File path: python/tvm/contrib/hexagon.py
##########
@@ -14,8 +14,8 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
-'''Utility for Hexagon backend'''
+# pylint: disable=invalid-name
Review comment:
how come we need this?
##########
File path: python/tvm/support.py
##########
@@ -27,6 +27,7 @@ def libinfo():
The dictionary of compile-time info.
"""
return {k: v for k, v in GetLibInfo().items()} # pylint: disable=unnecessary-comprehension
+ }
Review comment:
there are a lot of these extra closing braces or insertions that look like `function_call(` with no close `)` added. merge mistake? seems like nothing can possibly pass til they're deleted...
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
+trap cleanup 0
+
+
+if [ -x "$(command -v black)" ]; then
+ BLACK=black
+else
+ echo "Cannot find black"
+ exit 1
+fi
+
+# Print out specific version
+
+echo "Version Information: $(${BLACK} --version)"
+
+
+IFS=$'\n' read -a FILES -d'\n' < <(git diff --name-only HEAD $1 -- "*.py" "*.pyi") || true
+echo "read returned $?"
+echo "Files: $FILES"
+
+if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
+ echo "Running black on Python files against revision" $1):
+ CMD=( "black" "${FILES[@]}" )
+ echo "${CMD[@]}"
+ "${CMD[@]}"
+ exit 0
+fi
+
+echo "Running black in checking mode"
+black --diff --check
Review comment:
I think you either want --diff and assert on an empty output or --check, I don't know what both do?
##########
File path: pyproject.toml
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[tool.black]
+line-length = 100
+target-version = ['py36']
+include = '\.pyi?$'
+exclude = '''
+
+(
+ /(
+ \.github
+ | \.tvm
+ | \.tvm_test_data
+ | \.vscode
+ | \.venv
+ | cmake\/
+ | conda\/
+ | docker\/
+ | golang\/
+ | include\/
+ | jvm\/
+ | licenses\/
+ | nnvm\/
+ | rust\/
+ | src\/
+ | tests\/
+ | vta\/
+ | web\/
+ )/|tests/lint/add_asf_header.py|tests/lint/check_file_type.py|python/tvm/topi/testing/pool3d_python.py|python/topi/python/test_topi_pooling.py
Review comment:
can you break these line by line and sort?
##########
File path: python/tvm/relay/frontend/mxnet_qnn_op_utils.py
##########
@@ -277,6 +277,8 @@ def quantize_conv_weights_bias_channel_mkldnn_from_var(weights_var,
def get_mkldnn_requantize_scale_outDtype(min_output_range,
max_output_range,
out_dtype):
+ """Get the MKLDNN requantized scale."""
+ quantized_out_range = (
Review comment:
what's up with this line?
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
Review comment:
right now `-i` does both inplace format and check, do we want that?
##########
File path: python/tvm/te/hybrid/calls.py
##########
@@ -27,7 +27,7 @@
from .util import _internal_assert
-# pylint: disable=redefined-builtin
+# pylint: disable=redefined-builtin,invalid-name
Review comment:
same question here--do we need to update pylint?
##########
File path: python/tvm/contrib/hexagon.py
##########
@@ -14,8 +14,8 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
-'''Utility for Hexagon backend'''
+# pylint: disable=invalid-name
Review comment:
how come we need this?
##########
File path: python/tvm/support.py
##########
@@ -27,6 +27,7 @@ def libinfo():
The dictionary of compile-time info.
"""
return {k: v for k, v in GetLibInfo().items()} # pylint: disable=unnecessary-comprehension
+ }
Review comment:
there are a lot of these extra closing braces or insertions that look like `function_call(` with no close `)` added. merge mistake? seems like nothing can possibly pass til they're deleted...
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
+trap cleanup 0
+
+
+if [ -x "$(command -v black)" ]; then
+ BLACK=black
+else
+ echo "Cannot find black"
+ exit 1
+fi
+
+# Print out specific version
+
+echo "Version Information: $(${BLACK} --version)"
+
+
+IFS=$'\n' read -a FILES -d'\n' < <(git diff --name-only HEAD $1 -- "*.py" "*.pyi") || true
+echo "read returned $?"
+echo "Files: $FILES"
+
+if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
+ echo "Running black on Python files against revision" $1):
+ CMD=( "black" "${FILES[@]}" )
+ echo "${CMD[@]}"
+ "${CMD[@]}"
+ exit 0
+fi
+
+echo "Running black in checking mode"
+black --diff --check
Review comment:
I think you either want --diff and assert on an empty output or --check, I don't know what both do?
##########
File path: pyproject.toml
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[tool.black]
+line-length = 100
+target-version = ['py36']
+include = '\.pyi?$'
+exclude = '''
+
+(
+ /(
+ \.github
+ | \.tvm
+ | \.tvm_test_data
+ | \.vscode
+ | \.venv
+ | cmake\/
+ | conda\/
+ | docker\/
+ | golang\/
+ | include\/
+ | jvm\/
+ | licenses\/
+ | nnvm\/
+ | rust\/
+ | src\/
+ | tests\/
+ | vta\/
+ | web\/
+ )/|tests/lint/add_asf_header.py|tests/lint/check_file_type.py|python/tvm/topi/testing/pool3d_python.py|python/topi/python/test_topi_pooling.py
Review comment:
can you break these line by line and sort?
##########
File path: python/tvm/relay/frontend/mxnet_qnn_op_utils.py
##########
@@ -277,6 +277,8 @@ def quantize_conv_weights_bias_channel_mkldnn_from_var(weights_var,
def get_mkldnn_requantize_scale_outDtype(min_output_range,
max_output_range,
out_dtype):
+ """Get the MKLDNN requantized scale."""
+ quantized_out_range = (
Review comment:
what's up with this line?
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
Review comment:
right now `-i` does both inplace format and check, do we want that?
##########
File path: python/tvm/te/hybrid/calls.py
##########
@@ -27,7 +27,7 @@
from .util import _internal_assert
-# pylint: disable=redefined-builtin
+# pylint: disable=redefined-builtin,invalid-name
Review comment:
same question here--do we need to update pylint?
##########
File path: python/tvm/contrib/hexagon.py
##########
@@ -14,8 +14,8 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
-'''Utility for Hexagon backend'''
+# pylint: disable=invalid-name
Review comment:
how come we need this?
##########
File path: python/tvm/support.py
##########
@@ -27,6 +27,7 @@ def libinfo():
The dictionary of compile-time info.
"""
return {k: v for k, v in GetLibInfo().items()} # pylint: disable=unnecessary-comprehension
+ }
Review comment:
there are a lot of these extra closing braces or insertions that look like `function_call(` with no close `)` added. merge mistake? seems like nothing can possibly pass til they're deleted...
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
+trap cleanup 0
+
+
+if [ -x "$(command -v black)" ]; then
+ BLACK=black
+else
+ echo "Cannot find black"
+ exit 1
+fi
+
+# Print out specific version
+
+echo "Version Information: $(${BLACK} --version)"
+
+
+IFS=$'\n' read -a FILES -d'\n' < <(git diff --name-only HEAD $1 -- "*.py" "*.pyi") || true
+echo "read returned $?"
+echo "Files: $FILES"
+
+if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
+ echo "Running black on Python files against revision" $1):
+ CMD=( "black" "${FILES[@]}" )
+ echo "${CMD[@]}"
+ "${CMD[@]}"
+ exit 0
+fi
+
+echo "Running black in checking mode"
+black --diff --check
Review comment:
I think you either want --diff and assert on an empty output or --check, I don't know what both do?
##########
File path: pyproject.toml
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[tool.black]
+line-length = 100
+target-version = ['py36']
+include = '\.pyi?$'
+exclude = '''
+
+(
+ /(
+ \.github
+ | \.tvm
+ | \.tvm_test_data
+ | \.vscode
+ | \.venv
+ | cmake\/
+ | conda\/
+ | docker\/
+ | golang\/
+ | include\/
+ | jvm\/
+ | licenses\/
+ | nnvm\/
+ | rust\/
+ | src\/
+ | tests\/
+ | vta\/
+ | web\/
+ )/|tests/lint/add_asf_header.py|tests/lint/check_file_type.py|python/tvm/topi/testing/pool3d_python.py|python/topi/python/test_topi_pooling.py
Review comment:
can you break these line by line and sort?
##########
File path: python/tvm/relay/frontend/mxnet_qnn_op_utils.py
##########
@@ -277,6 +277,8 @@ def quantize_conv_weights_bias_channel_mkldnn_from_var(weights_var,
def get_mkldnn_requantize_scale_outDtype(min_output_range,
max_output_range,
out_dtype):
+ """Get the MKLDNN requantized scale."""
+ quantized_out_range = (
Review comment:
what's up with this line?
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
Review comment:
right now `-i` does both inplace format and check, do we want that?
##########
File path: python/tvm/te/hybrid/calls.py
##########
@@ -27,7 +27,7 @@
from .util import _internal_assert
-# pylint: disable=redefined-builtin
+# pylint: disable=redefined-builtin,invalid-name
Review comment:
same question here--do we need to update pylint?
##########
File path: python/tvm/contrib/hexagon.py
##########
@@ -14,8 +14,8 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
-'''Utility for Hexagon backend'''
+# pylint: disable=invalid-name
Review comment:
how come we need this?
##########
File path: python/tvm/support.py
##########
@@ -27,6 +27,7 @@ def libinfo():
The dictionary of compile-time info.
"""
return {k: v for k, v in GetLibInfo().items()} # pylint: disable=unnecessary-comprehension
+ }
Review comment:
there are a lot of these extra closing braces or insertions that look like `function_call(` with no close `)` added. merge mistake? seems like nothing can possibly pass til they're deleted...
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
+trap cleanup 0
+
+
+if [ -x "$(command -v black)" ]; then
+ BLACK=black
+else
+ echo "Cannot find black"
+ exit 1
+fi
+
+# Print out specific version
+
+echo "Version Information: $(${BLACK} --version)"
+
+
+IFS=$'\n' read -a FILES -d'\n' < <(git diff --name-only HEAD $1 -- "*.py" "*.pyi") || true
+echo "read returned $?"
+echo "Files: $FILES"
+
+if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
+ echo "Running black on Python files against revision" $1):
+ CMD=( "black" "${FILES[@]}" )
+ echo "${CMD[@]}"
+ "${CMD[@]}"
+ exit 0
+fi
+
+echo "Running black in checking mode"
+black --diff --check
Review comment:
I think you either want --diff and assert on an empty output or --check, I don't know what both do?
##########
File path: pyproject.toml
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[tool.black]
+line-length = 100
+target-version = ['py36']
+include = '\.pyi?$'
+exclude = '''
+
+(
+ /(
+ \.github
+ | \.tvm
+ | \.tvm_test_data
+ | \.vscode
+ | \.venv
+ | cmake\/
+ | conda\/
+ | docker\/
+ | golang\/
+ | include\/
+ | jvm\/
+ | licenses\/
+ | nnvm\/
+ | rust\/
+ | src\/
+ | tests\/
+ | vta\/
+ | web\/
+ )/|tests/lint/add_asf_header.py|tests/lint/check_file_type.py|python/tvm/topi/testing/pool3d_python.py|python/topi/python/test_topi_pooling.py
Review comment:
can you break these line by line and sort?
##########
File path: python/tvm/relay/frontend/mxnet_qnn_op_utils.py
##########
@@ -277,6 +277,8 @@ def quantize_conv_weights_bias_channel_mkldnn_from_var(weights_var,
def get_mkldnn_requantize_scale_outDtype(min_output_range,
max_output_range,
out_dtype):
+ """Get the MKLDNN requantized scale."""
+ quantized_out_range = (
Review comment:
what's up with this line?
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
Review comment:
right now `-i` does both inplace format and check, do we want that?
##########
File path: python/tvm/te/hybrid/calls.py
##########
@@ -27,7 +27,7 @@
from .util import _internal_assert
-# pylint: disable=redefined-builtin
+# pylint: disable=redefined-builtin,invalid-name
Review comment:
same question here--do we need to update pylint?
##########
File path: python/tvm/contrib/hexagon.py
##########
@@ -14,8 +14,8 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
-'''Utility for Hexagon backend'''
+# pylint: disable=invalid-name
Review comment:
how come we need this?
##########
File path: python/tvm/support.py
##########
@@ -27,6 +27,7 @@ def libinfo():
The dictionary of compile-time info.
"""
return {k: v for k, v in GetLibInfo().items()} # pylint: disable=unnecessary-comprehension
+ }
Review comment:
there are a lot of these extra closing braces or insertions that look like `function_call(` with no close `)` added. merge mistake? seems like nothing can possibly pass til they're deleted...
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
+trap cleanup 0
+
+
+if [ -x "$(command -v black)" ]; then
+ BLACK=black
+else
+ echo "Cannot find black"
+ exit 1
+fi
+
+# Print out specific version
+
+echo "Version Information: $(${BLACK} --version)"
+
+
+IFS=$'\n' read -a FILES -d'\n' < <(git diff --name-only HEAD $1 -- "*.py" "*.pyi") || true
+echo "read returned $?"
+echo "Files: $FILES"
+
+if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
+ echo "Running black on Python files against revision" $1):
+ CMD=( "black" "${FILES[@]}" )
+ echo "${CMD[@]}"
+ "${CMD[@]}"
+ exit 0
+fi
+
+echo "Running black in checking mode"
+black --diff --check
Review comment:
I think you either want --diff and assert on an empty output or --check, I don't know what both do?
##########
File path: pyproject.toml
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[tool.black]
+line-length = 100
+target-version = ['py36']
+include = '\.pyi?$'
+exclude = '''
+
+(
+ /(
+ \.github
+ | \.tvm
+ | \.tvm_test_data
+ | \.vscode
+ | \.venv
+ | cmake\/
+ | conda\/
+ | docker\/
+ | golang\/
+ | include\/
+ | jvm\/
+ | licenses\/
+ | nnvm\/
+ | rust\/
+ | src\/
+ | tests\/
+ | vta\/
+ | web\/
+ )/|tests/lint/add_asf_header.py|tests/lint/check_file_type.py|python/tvm/topi/testing/pool3d_python.py|python/topi/python/test_topi_pooling.py
Review comment:
can you break these line by line and sort?
##########
File path: python/tvm/relay/frontend/mxnet_qnn_op_utils.py
##########
@@ -277,6 +277,8 @@ def quantize_conv_weights_bias_channel_mkldnn_from_var(weights_var,
def get_mkldnn_requantize_scale_outDtype(min_output_range,
max_output_range,
out_dtype):
+ """Get the MKLDNN requantized scale."""
+ quantized_out_range = (
Review comment:
what's up with this line?
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
Review comment:
right now `-i` does both inplace format and check, do we want that?
##########
File path: python/tvm/te/hybrid/calls.py
##########
@@ -27,7 +27,7 @@
from .util import _internal_assert
-# pylint: disable=redefined-builtin
+# pylint: disable=redefined-builtin,invalid-name
Review comment:
same question here--do we need to update pylint?
##########
File path: python/tvm/contrib/hexagon.py
##########
@@ -14,8 +14,8 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
-'''Utility for Hexagon backend'''
+# pylint: disable=invalid-name
Review comment:
how come we need this?
##########
File path: python/tvm/support.py
##########
@@ -27,6 +27,7 @@ def libinfo():
The dictionary of compile-time info.
"""
return {k: v for k, v in GetLibInfo().items()} # pylint: disable=unnecessary-comprehension
+ }
Review comment:
there are a lot of these extra closing braces or insertions that look like `function_call(` with no close `)` added. merge mistake? seems like nothing can possibly pass til they're deleted...
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
+trap cleanup 0
+
+
+if [ -x "$(command -v black)" ]; then
+ BLACK=black
+else
+ echo "Cannot find black"
+ exit 1
+fi
+
+# Print out specific version
+
+echo "Version Information: $(${BLACK} --version)"
+
+
+IFS=$'\n' read -a FILES -d'\n' < <(git diff --name-only HEAD $1 -- "*.py" "*.pyi") || true
+echo "read returned $?"
+echo "Files: $FILES"
+
+if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
+ echo "Running black on Python files against revision" $1):
+ CMD=( "black" "${FILES[@]}" )
+ echo "${CMD[@]}"
+ "${CMD[@]}"
+ exit 0
+fi
+
+echo "Running black in checking mode"
+black --diff --check
Review comment:
I think you either want --diff and assert on an empty output or --check, I don't know what both do?
##########
File path: pyproject.toml
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[tool.black]
+line-length = 100
+target-version = ['py36']
+include = '\.pyi?$'
+exclude = '''
+
+(
+ /(
+ \.github
+ | \.tvm
+ | \.tvm_test_data
+ | \.vscode
+ | \.venv
+ | cmake\/
+ | conda\/
+ | docker\/
+ | golang\/
+ | include\/
+ | jvm\/
+ | licenses\/
+ | nnvm\/
+ | rust\/
+ | src\/
+ | tests\/
+ | vta\/
+ | web\/
+ )/|tests/lint/add_asf_header.py|tests/lint/check_file_type.py|python/tvm/topi/testing/pool3d_python.py|python/topi/python/test_topi_pooling.py
Review comment:
can you break these line by line and sort?
##########
File path: python/tvm/relay/frontend/mxnet_qnn_op_utils.py
##########
@@ -277,6 +277,8 @@ def quantize_conv_weights_bias_channel_mkldnn_from_var(weights_var,
def get_mkldnn_requantize_scale_outDtype(min_output_range,
max_output_range,
out_dtype):
+ """Get the MKLDNN requantized scale."""
+ quantized_out_range = (
Review comment:
what's up with this line?
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
Review comment:
right now `-i` does both inplace format and check, do we want that?
##########
File path: python/tvm/te/hybrid/calls.py
##########
@@ -27,7 +27,7 @@
from .util import _internal_assert
-# pylint: disable=redefined-builtin
+# pylint: disable=redefined-builtin,invalid-name
Review comment:
same question here--do we need to update pylint?
##########
File path: python/tvm/contrib/hexagon.py
##########
@@ -14,8 +14,8 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
-'''Utility for Hexagon backend'''
+# pylint: disable=invalid-name
Review comment:
how come we need this?
##########
File path: python/tvm/support.py
##########
@@ -27,6 +27,7 @@ def libinfo():
The dictionary of compile-time info.
"""
return {k: v for k, v in GetLibInfo().items()} # pylint: disable=unnecessary-comprehension
+ }
Review comment:
there are a lot of these extra closing braces or insertions that look like `function_call(` with no close `)` added. merge mistake? seems like nothing can possibly pass til they're deleted...
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,72 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
+trap cleanup 0
+
+
+if [ -x "$(command -v black)" ]; then
+ BLACK=black
+else
+ echo "Cannot find black"
+ exit 1
+fi
+
+# Print out specific version
+
+echo "Version Information: $(${BLACK} --version)"
+
+
+IFS=$'\n' read -a FILES -d'\n' < <(git diff --name-only HEAD $1 -- "*.py" "*.pyi") || true
+echo "read returned $?"
+echo "Files: $FILES"
+
+if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
+ echo "Running black on Python files against revision" $1):
+ CMD=( "black" "${FILES[@]}" )
+ echo "${CMD[@]}"
+ "${CMD[@]}"
+ exit 0
+fi
+
+echo "Running black in checking mode"
+black --diff --check
Review comment:
I think you either want --diff and assert on an empty output or --check, I don't know what both do?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6437: [RFC][Formatting] Add scripts for applying Black to the Python code.
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#issuecomment-691506743
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6437: [RFC][Formatting] Add scripts for applying Black to the Python code.
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#issuecomment-691506743
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on pull request #6437: [RFC][Formatting] Add scripts for applying Black to the Python code.
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#issuecomment-690676307
@junrushao1994 @comaniac @areusch I just added the scripts and cleaned some things up, take another pass if you can
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] areusch commented on a change in pull request #6437: [RFC][Formatting] Apply black to entire Python code base.
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#discussion_r486529234
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,76 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
+trap cleanup 0
+
+
+if [ -x "$(command -v black)" ]; then
+ BLACK=black
+else
+ echo "Cannot find black"
+ exit 1
+fi
+
+# Print out specific version
+${BLACK} --version
+
+FILES=$(git diff --name-only HEAD $1 -- "*.py" "*.pyi" | tr '\n' ' ')
Review comment:
can we use array style here?
`IFS=$'\n' read -a FILES -d'\n' < <(git diff --name-only HEAD $1 -- "*.py" "*.pyi")`
`CMD=( "black" "--check" "${FILES[@]}" )`
`"${CMD[@]}"`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on pull request #6437: [RFC][Formatting] Add scripts for applying Black to the Python code.
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#issuecomment-690930637
This is blocked on #6448 and #6451, once we land those two it should be possible to add the checking to the CI, format once more and land this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6437: [RFC][Formatting] Apply black to entire Python code base.
Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #6437:
URL: https://github.com/apache/incubator-tvm/pull/6437#discussion_r486506436
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,76 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
Review comment:
```suggestion
echo "Run black-format on Python files that changed since <commit>"
```
##########
File path: tests/lint/git-black.sh
##########
@@ -0,0 +1,76 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+set -e
+set -u
+set -o pipefail
+
+if [[ "$1" == "-i" ]]; then
+ INPLACE_FORMAT=1
+ shift 1
+else
+ INPLACE_FORMAT=0
+fi
+
+if [[ "$#" -lt 1 ]]; then
+ echo "Usage: tests/lint/git-black.sh [-i] <commit>"
+ echo ""
+ echo "Run black-format on files that changed since <commit>"
+ echo "Examples:"
+ echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1"
+ echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master"
+ echo "You can also add -i option to do inplace format"
+ exit 1
+fi
+
+cleanup()
+{
+ rm -rf /tmp/$$.black-format.txt
+}
+trap cleanup 0
+
+
+if [ -x "$(command -v black)" ]; then
+ BLACK=black
+else
+ echo "Cannot find black"
+ exit 1
+fi
+
+# Print out specific version
+${BLACK} --version
+
+FILES=$(git diff --name-only HEAD $1 -- "*.py" "*.pyi" | tr '\n' ' ')
+echo $FILES
+
+if [[ ${INPLACE_FORMAT} -eq 1 ]]; then
+ echo "Running black in place on your working tree." $1
+ CMD="black --check $FILES"
+ echo $CMD
+ eval $CMD
+ exit 0
+fi
+
+echo "Running git-black against" $1
Review comment:
```suggestion
echo "Running git-black on Python files against" $1
```
##########
File path: pyproject.toml
##########
@@ -0,0 +1,29 @@
+[tool.black]
+line-length = 88
Review comment:
So we are using 88 as the TVM standard column length for Python codes? I know this is the default and the suggested value in black so just want to double confirm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org